Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable] 1.45.1 release #74574

Merged
merged 11 commits into from
Jul 24, 2020
Merged

[stable] 1.45.1 release #74574

merged 11 commits into from
Jul 24, 2020

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Jul 20, 2020 •
edited
Loading

See RELEASES.md for details on what this contains.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 20, 2020
Closed
@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Jul 21, 2020 •
edited
Loading

#74557 is also stable-nominated, would it also go in this release if accepted?

@Mark-Simulacrum
Copy link
Member Author

Yes, it should.

Mark-Simulacrum and others added 4 commits July 22, 2020 08:36
@Mark-Simulacrum
1.45.1 release
9e5fb40
@Mark-Simulacrum
Update to rustfmt 1.4.17
3092347
@matthewjasper @Mark-Simulacrum
Use ReEmpty(U0) as the implicit region bound in typeck
0f24c5a
@Keruspe @Mark-Simulacrum
rustbuild: drop tool::should_install
452a29c 
Always install when the build succeeds

Fixes rust-lang#74431

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
@Mark-Simulacrum
Bump cargo
3814819 
This is not a user-visible change as Cargo's library API is not exposed by Rust,
but this way the version in 1.45.1 will appropriately match with published Cargo
0.46.1.
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=99

This is targeting Thursday next week, so not super urgent, but I'd like artifacts as soon as possible.

@bors
Copy link
Contributor

bors commented Jul 23, 2020

📌 Commit d01e109 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 23, 2020

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 23, 2020
@Manishearth
Copy link
Member

Perhaps we should p=100 this since nothing else is happening right now? The fetch bug might not affect older branches as much

@mati865
Copy link
Contributor

mati865 commented Jul 23, 2020

The fetch bug might not affect older branches as much

It reproduces on 1.43: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/zlib.20errors/near/204837666

@bors
Copy link
Contributor

bors commented Jul 23, 2020

⌛ Testing commit d01e109 with merge 276d6395ee46ef7f0558b1ed1d1421b94588e5b9...

@bors
Copy link
Contributor

bors commented Jul 23, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 23, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@ehuss
Copy link
Contributor

ehuss commented Jul 23, 2020

Probably needs #74406 and #74418, similar to #74593.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=100

@bors
Copy link
Contributor

bors commented Jul 23, 2020

📌 Commit 7747315 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

rye added 3 commits July 23, 2020 18:27
@rye @Mark-Simulacrum
ci: Set shell: bash as a default, remove duplicates
7d0afb1 
A follow-up to rust-lang#74406, this commit merely removes the `shell: bash`
lines where they are explicitly added in favor of setting defaults for
*all* "run" steps.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@rye @Mark-Simulacrum
ci: Stop setting CI_OVERRIDE_SHELL environment variable
132887c 
This will render the src/ci/exec-with-shell.py script more or less
useless, but we're going to replace that by just using the system bash
instead.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@rye @Mark-Simulacrum
ci: Replace exec-with-shell wrapper with "plain bash"
884ea63 
Also, promote defaults.run.shell from inside only the primary jobs to
the top level.

The src/ci/exec-with-shell.py wrapper script was formerly used to change
out the shell mid-job by intercepting a CI_OVERRIDE_SHELL environment
variable.  Now, instead, we just set `bash` as the global default across
all jobs, and we also delete the exec-with-shell.py script.

Signed-off-by: Kristofer Rye <kristofer.rye@gmail.com>
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=100

@bors
Copy link
Contributor

bors commented Jul 23, 2020

📌 Commit 884ea63 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2020
@bors
Copy link
Contributor

bors commented Jul 23, 2020

⌛ Testing commit 884ea63 with merge 3007f25033a1564968004ccc62b3163233a4fdc6...

@bors
Copy link
Contributor

bors commented Jul 24, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2020
@Mark-Simulacrum
Copy link
Member Author

Seems likely to be spurious. @bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2020
@bors
Copy link
Contributor

bors commented Jul 24, 2020

⌛ Testing commit 884ea63 with merge fe127277de558b0d78672b829a39978edc50c513...

@bors
Copy link
Contributor

bors commented Jul 24, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2020
@Manishearth
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2020
@bors
Copy link
Contributor

bors commented Jul 24, 2020

⌛ Testing commit 884ea63 with merge 14485ee...

@bors
Copy link
Contributor

bors commented Jul 24, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 14485ee to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2020
@bors bors merged commit 14485ee into rust-lang:stable Jul 24, 2020
@cuviper cuviper added this to the 1.45 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.