Add str::[r]split_once #74707
Merged
Add str::[r]split_once #74707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
matklad
added
T-libs-api
matklad
force-pushed
the
split_once
branch
3 times, most recently
from
d520bab to
4a7b4df
Compare
dtolnay
reviewed
Jul 26, 2020
4 tasks
matklad
force-pushed
the
split_once
branch
2 times, most recently
from
91b38b0 to
bb2687d
Compare
matklad
added
the
S-waiting-on-review
|
tests&tracking issue added! |
dtolnay
approved these changes
Jul 26, 2020
|
@bors r+ |
|
📌 Commit bb2687d has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 27, 2020
Add str::[r]split_once This is useful for quick&dirty parsing of key: value config pairs. Used a bunch in Cargo and rust-analyzer: * https://github.com/rust-lang/cargo/search?q=splitn%282&unscoped_q=splitn%282 * https://github.com/rust-analyzer/rust-analyzer/search?q=split_delim&unscoped_q=split_delim In theory, once const-generics are done, this functionality could be achieved without a dedicated method with ```rust match s.splitn(delimier, 2).collect_array::<2>() { Some([prefix, suffix]) => todo!(), None => todo!(), } ``` Even in that world, having a dedicated method seems clearer on the intention. I am not sure about naming -- this is something I've just came up with yesterday, I don't know off the top of my head analogs in other languages. If T-libs thinks this is a reasonable API to have, I'll open a tracking issue and add more thorough tests.
|
⌛ Testing commit bb2687d with merge d1b9d490b3374c4af4239be2875a7ca4f3a02b67... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
This is useful for quick&dirty parsing of key: value config pairs
|
Rebased! Given that the failure seems completely unrelated, I am going to @bors r=dtolnay |
|
📌 Commit 6e9dc7d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6e9dc7d with merge 1c984308eca9a30ec54bed3d3edcbb179a7788ab... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
A different spurious error: @bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6e9dc7d with merge 8725668584b02dce2fd223aed0dd53c1eedc4a57... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
Hm, the same spurious network error: I guess crates.io is not feeling great today? |
|
Ok, lets try this again @bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 29, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#74266 (Clean up E0720 explanation) - rust-lang#74671 (add const generics array coercion test) - rust-lang#74707 (Add str::[r]split_once) - rust-lang#74814 (Fix RefUnwindSafe & UnwinsSafe impls for lazy::SyncLazy) - rust-lang#74859 (Update outdated readme) - rust-lang#74864 (ayu theme: Change doccomment color to `#a1ac88`) - rust-lang#74872 (Enable to ping RISC-V group via triagebot) - rust-lang#74891 (handle ConstEquate in rustdoc) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for quick&dirty parsing of key: value config pairs. Used a bunch in Cargo and rust-analyzer:
In theory, once const-generics are done, this functionality could be achieved without a dedicated method with
Even in that world, having a dedicated method seems clearer on the intention.
I am not sure about naming -- this is something I've just came up with yesterday, I don't know off the top of my head analogs in other languages.
If T-libs thinks this is a reasonable API to have, I'll open a tracking issue and add more thorough tests.