Rollup of 7 pull requests #74810
Closed
Rollup of 7 pull requests #74810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when non-empty sequence of empty IoSlices have been provided to `Write::write_all_vectored`, the buffers would be written as is with `Write::write_vectored` and subsequently the return value `Ok(0)` would be misinterpreted as an error. Avoid writes without any data by advancing the buffers first. This matches the documented behaviour of `Write::write_all_vectored` and is analogous to what happens in `Write::write_all`.
This is useful for quick&dirty parsing of key: value config pairs
This is important for fields, which are incorrectly referred to as "items".
…=KodrAus Avoid writes without any data in `Write::write_all_vectored` Previously, when non-empty sequence of empty IoSlices have been provided to `Write::write_all_vectored`, the buffers would be written as is with `Write::write_vectored` and subsequently the return value `Ok(0)` would be misinterpreted as an error. Avoid writes without any data by advancing the buffers first. This matches the documented behaviour of `Write::write_all_vectored` and is analogous to what happens in `Write::write_all`.
Add str::[r]split_once This is useful for quick&dirty parsing of key: value config pairs. Used a bunch in Cargo and rust-analyzer: * https://github.com/rust-lang/cargo/search?q=splitn%282&unscoped_q=splitn%282 * https://github.com/rust-analyzer/rust-analyzer/search?q=split_delim&unscoped_q=split_delim In theory, once const-generics are done, this functionality could be achieved without a dedicated method with ```rust match s.splitn(delimier, 2).collect_array::<2>() { Some([prefix, suffix]) => todo!(), None => todo!(), } ``` Even in that world, having a dedicated method seems clearer on the intention. I am not sure about naming -- this is something I've just came up with yesterday, I don't know off the top of my head analogs in other languages. If T-libs thinks this is a reasonable API to have, I'll open a tracking issue and add more thorough tests.
Pull out some duplicated code into a new function I debated pulling the actual struct_span_err calls into the new method, but I felt like having to pass in multiple arguments for it and wiring up string formatting outweighed the benefits. Viewing the diff with whitespace ignored is recommended.
…r=JohnTitor Clean up some uses of logging in ui tests The removed test can't possibly trigger anything today as we don't have logging in libstd. The `exec-env` flag was mistakenly used for adding env vars to rustc invocations both in test and in the test suite and there were some accidental renames from RUST_LOG to RUSTC_LOG that I reverted.
…acrum python codes cleanup
…enkov report kind of deprecated item in message This is important for fields, which are incorrectly referred to as "items".
…uillaumeGomez Don't italicize comments in ayu theme Closes rust-lang#74770. Before:  After: 
|
📌 Commit 90c590f has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 90c590f with merge 5c5423895060f83b51eec33f01aecff77f0833ed... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Write::write_all_vectored#74088 (Avoid writes without any data inWrite::write_all_vectored)Failed merges:
r? @ghost