Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Require one of wget or curl. #7498

Merged
merged 1 commit into from
Jul 3, 2013
Merged

Conversation

luqmana
Copy link
Member

@luqmana luqmana commented Jun 30, 2013

Either one works and wget is easier to setup on windows.

bors added a commit that referenced this pull request Jul 3, 2013
Either one works and wget is easier to setup on windows.
@bors bors closed this Jul 3, 2013
@bors bors merged commit 9c3ef89 into rust-lang:master Jul 3, 2013
@pnkfelix
Copy link
Member

pnkfelix commented Jul 9, 2013

Cool. I'm going to try using wget instead of curl for my install on Windows; if it works, then we should update the docs to incorporate the wget approach instead of the curl one.

@sanxiyn sanxiyn mentioned this pull request Jun 3, 2016
eddyb added a commit to eddyb/rust that referenced this pull request Jun 6, 2016
Unsupport wget

wget support was removed in rust-lang#32942 (search for wget in diff), but configure wasn't updated. wget support was introduced in rust-lang#7498 for Windows, but we now use PowerShell on Windows.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 29, 2021
Rename two lints to comply with our lint naming convention

self_named_constructor -> self_named_constructors
append_instead_of_extend -> extend_with_drain

We don't need to `register_renamed` those lints, since I'll backport them to beta, so the old names won't hit stable.

changelog: none
(I'll adapt the changelog before merging rust-lang#7498)
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 12, 2021
Updated changelog for 1.55

This has again been a bit of work, but I'm happy to notice that my English is still improving, and I'm getting faster at these things. That's a very nice side effect of contributing and getting feedback on reviews 😊

Moving on, there were a few things that I was unsure about:
* The PR rust-lang#86717 changes an old entry in the change log, is this worth mentioning? I've left it out for now.
* The stabilization of `cargo clippy --fix` is quite awesome and important IMO. It sadly gets a bit lost in the *Other* entry, as it's the last one. Do we maybe want to move it somewhere else or change the headline order for this release?
* I've listed the introduction of the new `suspicious` group under the *Moves and Deprecations* section. Is this alright, or should it be moved to the *Other* section as well?
* Last but definitely not least, some fun! I've used the 🎉 emoji in the `cargo clippy --fix` entry, is this okay?

Sorry for the bombardment of questions xD

---

The PR already includes the entries for the new metadata collection and website updates. These are not merged yet, but should probably be to make this correct. This might also require the commit hashes to be updated (Not sure on this, though). It would actually be super fitting to get this into this release as we also stabilize `--fix`. TODOs:
* [x] Merge metadata collection PRs:
  1. rust-lang#7279
  2. rust-lang#7298
  3. rust-lang#7420 (Hope to not get any merge conflicts)

---

[Rendered 📰](https://github.com/xFrednet/rust-clippy/blob/changelog-1-55/CHANGELOG.md)

r? `@flip1995`

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants