Make some Ordering methods const #75463

CDirkx · 2020-08-12T20:11:47Z

Constify the following methods of core::cmp::Ordering:

reverse
then

Possible because of #49146 (Allow if and match in constants).

Tracking issue: #76113

Constify the following methods of `core::cmp::Ordering`: - `reverse` - `then` Possible because of rust-lang#49146 (Allow `if` and `match` in constants).

CDirkx · 2020-08-12T20:22:47Z

What are the requirements for making functions const_stable or const_unstable?
Would this change require a const_ordering feature gate?

crlf0710 · 2020-08-28T17:54:29Z

@CDirkx Ping from triage, this needs to get the CI green before review. You'll need to use the #[rustc_const_unstable] attribute. Search within the code, and follow the existing examples will be enough.

ecstatic-morse · 2020-08-30T18:00:26Z

There's no need for these to be unstable IMO now that if and match are stable in a const fn. It's not like these impls are going to change.

CDirkx · 2020-08-30T20:26:45Z

Yeah that is my question, is it enough that #49146 is stabilized to make these methods const_stable, since they are only simple matches? If so, that would also apply to a lot of the methods under const_option (#67441) and const_result ( #67520), as well as some integer methods I believe. I would be happy to make some stabilization PRs for those if that's the descision.

ecstatic-morse · 2020-08-30T20:37:16Z

As I understand it, you're correct and all those methods are eligible for stabilization. (cc @rust-lang/wg-const-eval in case there's an objection). I'll check in with t-libs as well.

In the meantime, I'll happily sign off on the insta-stable version. I guess you just keep the current feature name even though it never did anything?

r? @ecstatic-morse

library/core/src/cmp.rs

ecstatic-morse · 2020-08-30T21:51:27Z

@bors delegate+

r=me with correct release number (1.46 came out this week).

bors · 2020-08-30T21:51:29Z

✌️ @CDirkx can now approve this pull request

`const_ordering` will stabilize in version 1.48.0

CDirkx · 2020-08-30T22:09:08Z

@bors r+

bors · 2020-08-30T22:09:10Z

📌 Commit 12f4624 has been approved by CDirkx

Make some Ordering methods const Constify the following methods of `core::cmp::Ordering`: - `reverse` - `then` Possible because of rust-lang#49146 (Allow `if` and `match` in constants). Tracking issue: rust-lang#76113

bors · 2020-08-31T01:28:47Z

⌛ Testing commit 12f4624 with merge 92290d1...

bors · 2020-08-31T03:18:56Z

☀️ Test successful - checks-actions, checks-azure
Approved by: CDirkx
Pushing 92290d1 to master...

tesuji · 2020-08-31T05:17:12Z

@rustbot modify labels: T-libs

rustbot · 2020-08-31T05:17:13Z

Error: Label relnotes can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

RalfJung · 2020-08-31T09:23:37Z

Eh, shouldn't there be t-libs FCP on this? I don't think there is precedent for insta-stabilizing new const, but the methods seem simple enough. Still, this needs team approval.

Cc @rust-lang/libs

Also @CDirkx, please don't r+ unless you are the reviewer. When you approve in the name of someone else, please do r=<name of reviewer>. (We use r=me as a short-hand to say exactly that, but it is entire incomprehensible unless you already know what it means.^^)

CDirkx · 2020-08-31T13:42:59Z

@RalfJung Ah, yeah I was unsure if that was the intention. Thanks!

This was approved by me prematurely. It needs T-libs approval.

@CDirkx

…Jung Revert rust-lang#75463 This was approved by me prematurely. It needs T-libs approval. Sorry @CDirkx. r? @RalfJung

@ghost

Rollup of 12 pull requests Successful merges: - rust-lang#75945 (Use `env::func()`, not 'the function env::func' in docs for std::env) - rust-lang#76002 (Fix `-Z instrument-coverage` on MSVC) - rust-lang#76003 (Adds two source span utility functions used in source-based coverage) - rust-lang#76059 (Clean up E0764) - rust-lang#76103 (Clean up E0769) - rust-lang#76139 (Make `cow_is_borrowed` methods const) - rust-lang#76154 (Fix rustdoc strings indentation) - rust-lang#76161 (Remove notrust in rustc_middle) - rust-lang#76163 (README: Adjust Linux and macOS support platform and architecture) - rust-lang#76166 (Make `StringReader` private) - rust-lang#76172 (Revert rust-lang#75463) - rust-lang#76178 (Update expect-test to 1.0) Failed merges: r? @ghost

Make some Ordering methods const Resubmission of [PR#75463](rust-lang#75463) as per [PR#76172](rust-lang#76172). Constify the following methods of `core::cmp::Ordering`: - `reverse` - `then` Insta-stabilizes these methods as const under the `const_ordering` feature, as their implementation is a trivial match and the recent stabilization of rust-lang#49146 (Allow `if` and `match` in constants). Note: the `const_ordering` feature has never actually been used as these methods have not been `#[rustc_const_unstable]`. Tracking issue: rust-lang#76113

Stabilize some Option methods as const Stabilize the following methods of `Option` as const: - `is_some` - `is_none` - `as_ref` These methods are currently const under the unstable feature `const_option` (tracking issue: rust-lang#67441). I believe these methods to be eligible for stabilization because of the stabilization of rust-lang#49146 (Allow if and match in constants) and the trivial implementations, see also: [PR#75463](rust-lang#75463). Related: rust-lang#76225

Stabilize some Result methods as const Stabilize the following methods of Result as const: - `is_ok` - `is_err` - `as_ref` A test is also included, analogous to the test for `const_option`. These methods are currently const under the unstable feature `const_result` (tracking issue: rust-lang#67520). I believe these methods to be eligible for stabilization because of the stabilization of rust-lang#49146 (Allow if and match in constants) and the trivial implementations, see also: [PR#75463](rust-lang#75463) and [PR#76135](rust-lang#76135). Note: these methods are the only methods currently under the `const_result` feature, thus this PR results in the removal of the feature. Related: rust-lang#76225

Stabilize some Option methods as const Stabilize the following methods of `Option` as const: - `is_some` - `is_none` - `as_ref` These methods are currently const under the unstable feature `const_option` (tracking issue: rust-lang#67441). I believe these methods to be eligible for stabilization because of the stabilization of rust-lang#49146 (Allow if and match in constants) and the trivial implementations, see also: [PR#75463](rust-lang#75463). Related: rust-lang#76225

Stabilize some Result methods as const Stabilize the following methods of Result as const: - `is_ok` - `is_err` - `as_ref` A test is also included, analogous to the test for `const_option`. These methods are currently const under the unstable feature `const_result` (tracking issue: #67520). I believe these methods to be eligible for stabilization because of the stabilization of #49146 (Allow if and match in constants) and the trivial implementations, see also: [PR#75463](rust-lang/rust#75463) and [PR#76135](rust-lang/rust#76135). Note: these methods are the only methods currently under the `const_result` feature, thus this PR results in the removal of the feature. Related: #76225

Make some Ordering methods const

6b0d44e

Constify the following methods of `core::cmp::Ordering`: - `reverse` - `then` Possible because of rust-lang#49146 (Allow `if` and `match` in constants).

crlf0710 requested a review from sfackler August 28, 2020 17:55

Add unstable const_ordering feature, and some tests.

5fac991

rust-highfive assigned ecstatic-morse Aug 30, 2020

Stabilize feature const_ordering

89fc3fb

ecstatic-morse reviewed Aug 30, 2020

View reviewed changes

library/core/src/cmp.rs Outdated Show resolved Hide resolved

ecstatic-morse reviewed Aug 30, 2020

View reviewed changes

library/core/src/cmp.rs Outdated Show resolved Hide resolved

Update since to correct release

12f4624

`const_ordering` will stabilize in version 1.48.0

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 30, 2020

This was referenced Aug 31, 2020

Stabilize some Option methods as const #76135

Merged

Stabilize some Result methods as const #76136

Merged

Dylan-DPC-zz mentioned this pull request Aug 31, 2020

Rollup of 9 pull requests #76137

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 31, 2020

bors merged commit 92290d1 into rust-lang:master Aug 31, 2020

CDirkx deleted the ordering-const branch August 31, 2020 03:37

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 31, 2020

RalfJung added the relnotes Marks issues that should be documented in the release notes of the next release. label Aug 31, 2020

jyn514 added the A-const-fn label Aug 31, 2020

Dylan-DPC-zz added this to the 1.48 milestone Aug 31, 2020

ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Aug 31, 2020

Revert rust-lang#75463

4404cc5

This was approved by me prematurely. It needs T-libs approval.

tmandry added a commit to tmandry/rust that referenced this pull request Sep 1, 2020

Rollup merge of rust-lang#76172 - ecstatic-morse:revert-75463, r=Ralf…

9d435d2

…Jung Revert rust-lang#75463 This was approved by me prematurely. It needs T-libs approval. Sorry @CDirkx. r? @RalfJung

tmandry mentioned this pull request Sep 1, 2020

Rollup of 12 pull requests #76186

Merged

CDirkx restored the ordering-const branch September 1, 2020 02:22

CDirkx deleted the ordering-const branch September 1, 2020 02:24

RalfJung removed the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 1, 2020

RalfJung removed this from the 1.48 milestone Sep 1, 2020

CDirkx mentioned this pull request Sep 1, 2020

Make some Ordering methods const #76198

Merged

pnkfelix mentioned this pull request Oct 14, 2022

Tracking issue for const Ordering methods #76113

Closed

cuviper added this to the 1.48.0 milestone May 2, 2024

RalfJung added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Dec 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make some Ordering methods const #75463

Make some Ordering methods const #75463

CDirkx commented Aug 12, 2020 •

edited

Loading

CDirkx commented Aug 12, 2020

crlf0710 commented Aug 28, 2020

ecstatic-morse commented Aug 30, 2020

CDirkx commented Aug 30, 2020

ecstatic-morse commented Aug 30, 2020 •

edited

Loading

ecstatic-morse commented Aug 30, 2020

bors commented Aug 30, 2020

CDirkx commented Aug 30, 2020

bors commented Aug 30, 2020

bors commented Aug 31, 2020

bors commented Aug 31, 2020

tesuji commented Aug 31, 2020 •

edited

Loading

rustbot commented Aug 31, 2020

RalfJung commented Aug 31, 2020 •

edited

Loading

CDirkx commented Aug 31, 2020

Make some Ordering methods const #75463

Make some Ordering methods const #75463

Conversation

CDirkx commented Aug 12, 2020 • edited Loading

CDirkx commented Aug 12, 2020

crlf0710 commented Aug 28, 2020

ecstatic-morse commented Aug 30, 2020

CDirkx commented Aug 30, 2020

ecstatic-morse commented Aug 30, 2020 • edited Loading

ecstatic-morse commented Aug 30, 2020

bors commented Aug 30, 2020

CDirkx commented Aug 30, 2020

bors commented Aug 30, 2020

bors commented Aug 31, 2020

bors commented Aug 31, 2020

tesuji commented Aug 31, 2020 • edited Loading

rustbot commented Aug 31, 2020

RalfJung commented Aug 31, 2020 • edited Loading

CDirkx commented Aug 31, 2020

CDirkx commented Aug 12, 2020 •

edited

Loading

ecstatic-morse commented Aug 30, 2020 •

edited

Loading

tesuji commented Aug 31, 2020 •

edited

Loading

RalfJung commented Aug 31, 2020 •

edited

Loading