-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #75688
Rollup of 11 pull requests #75688
Commits on Aug 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e720f42 - Browse repository at this point
Copy the full SHA e720f42View commit details -
docs(marker/copy): clarify that
&T
is alsoCopy
In the current documentation about the `Copy` marker trait, there is a section about "additional implementors", which list additional implementors of the `Copy` trait. The fact that shared references are also `Copy` is mixed with another point, which makes it hard to recognize and make it seem not as important. This clarifies the fact that shared references are also `Copy`, by mentioning it as a separate item in the list of "additional implementors".
Configuration menu - View commit details
-
Copy full SHA for 7835c8c - Browse repository at this point
Copy the full SHA 7835c8cView commit details
Commits on Aug 13, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 9b0f3d1 - Browse repository at this point
Copy the full SHA 9b0f3d1View commit details
Commits on Aug 16, 2020
-
docs(marker/copy): provide example for
&T
beingCopy
In the current documentation about the `Copy` marker trait, there is a section with examples of structs that can implement `Copy`. Currently there is no example for showing that shared references (`&T`) are also `Copy`. It is worth to have a dedicated example for `&T` being `Copy`, because shared references are an integral part of the language and it being `Copy` is not as intuitive as other types that share this behaviour like `i32` or `bool`. The example picks up on the previous non-`Copy` struct and shows that structs can be `Copy`, even when they hold a shared reference to a non-`Copy` type.
Configuration menu - View commit details
-
Copy full SHA for a876b3d - Browse repository at this point
Copy the full SHA a876b3dView commit details -
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Configuration menu - View commit details
-
Copy full SHA for 43dec0e - Browse repository at this point
Copy the full SHA 43dec0eView commit details -
add back emojis that have been removed accidentally
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Configuration menu - View commit details
-
Copy full SHA for dce8644 - Browse repository at this point
Copy the full SHA dce8644View commit details -
add empty line above code block
Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9061da2 - Browse repository at this point
Copy the full SHA 9061da2View commit details -
Code blocks in doc comments are compiled and run, so we show `Copy` works in this example. Co-authored-by: Poliorcetics <poliorcetics@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 56daf63 - Browse repository at this point
Copy the full SHA 56daf63View commit details
Commits on Aug 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b0eb55a - Browse repository at this point
Copy the full SHA b0eb55aView commit details -
Fix stack overflow for recursive types.
Adds a seen set to structurally_same_type to avoid recursing indefinitely when a reference or pointer member introduces a cycle in the visited types.
Configuration menu - View commit details
-
Copy full SHA for db75313 - Browse repository at this point
Copy the full SHA db75313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 154b74e - Browse repository at this point
Copy the full SHA 154b74eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1fa4e0 - Browse repository at this point
Copy the full SHA a1fa4e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80c2c80 - Browse repository at this point
Copy the full SHA 80c2c80View commit details -
Configuration menu - View commit details
-
Copy full SHA for bca48ad - Browse repository at this point
Copy the full SHA bca48adView commit details -
That cache is unlikely to be particularly useful within a single invocation of structurally_same_type, especially compared to memoizing results across _all_ invocations of that function.
Configuration menu - View commit details
-
Copy full SHA for 6c57de1 - Browse repository at this point
Copy the full SHA 6c57de1View commit details -
Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
Configuration menu - View commit details
-
Copy full SHA for 7708abb - Browse repository at this point
Copy the full SHA 7708abbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1321a2d - Browse repository at this point
Copy the full SHA 1321a2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc15dd6 - Browse repository at this point
Copy the full SHA bc15dd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 431a465 - Browse repository at this point
Copy the full SHA 431a465View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4995fc - Browse repository at this point
Copy the full SHA a4995fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 833bbb1 - Browse repository at this point
Copy the full SHA 833bbb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for dae3a4f - Browse repository at this point
Copy the full SHA dae3a4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ac860 - Browse repository at this point
Copy the full SHA c6ac860View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b1d2e3 - Browse repository at this point
Copy the full SHA 3b1d2e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b74f04 - Browse repository at this point
Copy the full SHA 1b74f04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2858074 - Browse repository at this point
Copy the full SHA 2858074View commit details
Commits on Aug 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 7be824e - Browse repository at this point
Copy the full SHA 7be824eView commit details -
rewrite old test so that its attributes are consistent with what we w…
…ant in the language. (Note that the fact this test existed is a slight sign that we may need a crater run on this bugfix...)
Configuration menu - View commit details
-
Copy full SHA for e24aa73 - Browse repository at this point
Copy the full SHA e24aa73View commit details -
When building lint specs map for a given scope, check if forbid prese…
…nt on each insert. Drive-by changes: 1. make `LintLevelsBuilder::push` private to the crate. 2. Add methods to `LintSource` for extracting its name symbol or its span.
Configuration menu - View commit details
-
Copy full SHA for 01e8e9f - Browse repository at this point
Copy the full SHA 01e8e9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef03a5d - Browse repository at this point
Copy the full SHA ef03a5dView commit details -
review suggestion: use existing defn rather than new intern call
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ec4c4f - Browse repository at this point
Copy the full SHA 4ec4c4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c4641b - Browse repository at this point
Copy the full SHA 8c4641bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9d84dc - Browse repository at this point
Copy the full SHA d9d84dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f957bae - Browse repository at this point
Copy the full SHA f957baeView commit details -
docs: add another
derive
forCopy
able structThis adds another `derive` for a `Copy`able struct, so that we are consistent with `derive` annotations.
Jan Riemer committedAug 18, 2020 Configuration menu - View commit details
-
Copy full SHA for 522d177 - Browse repository at this point
Copy the full SHA 522d177View commit details -
Don't emit "is not a logical operator" error outside of associative e…
…xpressions Avoid showing this error where it doesn't make sense by not assuming "and" and "or" were intended to mean "&&" and "||" until after we decide to continue parsing input as an associative expression. Note that the decision of whether or not to continue parsing input as an associative expression doesn't actually depend on this assumption. Fixes rust-lang#75599
Configuration menu - View commit details
-
Copy full SHA for ff73a40 - Browse repository at this point
Copy the full SHA ff73a40View commit details
Commits on Aug 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 3e3a2c8 - Browse repository at this point
Copy the full SHA 3e3a2c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63d2e9b - Browse repository at this point
Copy the full SHA 63d2e9bView commit details -
Rollup merge of rust-lang#73379 - pnkfelix:issue-70819-disallow-overr…
…ide-forbid-in-same-scope, r=petrochenkov Disallow later override of forbid lint in same scope Fix rust-lang#70819 When building lint specs map for a given scope, check if forbid present on each insert. Drive-by changes: 1. make `LintLevelsBuilder::push` private to the crate. 2. Add methods to `LintSource` for extracting its name symbol or its span. 3. Rewrote old test so that its use of lint attributes are consistent with what we want in the language. (Note that the fact this test existed is a slight sign that we may need a crater run on this bugfix...)
Configuration menu - View commit details
-
Copy full SHA for 6af1838 - Browse repository at this point
Copy the full SHA 6af1838View commit details -
Rollup merge of rust-lang#75038 - rust-lang:Havvy-patch-1, r=stevekla…
…bnik See also X-Link mem::{swap, take, replace} Since it's easy to end up at one of these functions when you really wanted the other one, cross link them with descriptions of why you'd want to use them.
Configuration menu - View commit details
-
Copy full SHA for 29b43a8 - Browse repository at this point
Copy the full SHA 29b43a8View commit details -
Rollup merge of rust-lang#75049 - janriemer:patch-1, r=poliorcetics
docs(marker/copy): provide example for `&T` being `Copy` ### Edited 2020-08-16 (most recent) In the current documentation about the `Copy` marker trait, there is a section with examples of structs that can implement `Copy`. Currently there is no example for showing that shared references (`&T`) are also `Copy`. It is worth to have a dedicated example for `&T` being `Copy`, because shared references are an integral part of the language and it being `Copy` is not as intuitive as other types that share this behaviour like `i32` or `bool`. The example picks up on the previous non-`Copy` struct and shows that structs can be `Copy`, even when they hold a shared reference to a non-`Copy` type. ----------------------------------------- ### Edited 2020-08-02, 3:28 p.m. I've just realized that it says "in addition to the **implementors listed below**", which makes this PR kind of "wrong", because `&T` is indeed in the "implementors listed below". Maybe we can instead show an example with `&T` in the [When can my type be Copy](https://doc.rust-lang.org/std/marker/trait.Copy.html#when-can-my-type-be-copy) section. What I really want to achieve is that it becomes more obvious that `&T` is also `Copy`, because, I think, it is very valuable to know and it wasn't obvious for me, until I read something about it in a forum post. What do you think? I would create another PR for that. **Please feel free to close this PR.** ----------------------------------- ### Original post In the current documentation about the `Copy` marker trait, there is a section about "additional implementors", which list additional implementors of the `Copy` trait. The fact that shared references are also `Copy` is mixed with another point, which makes it hard to recognize and make it seem not as important. This clarifies the fact that shared references are also `Copy`, by mentioning it as a separate item in the list of "additional implementors".
Configuration menu - View commit details
-
Copy full SHA for 049a831 - Browse repository at this point
Copy the full SHA 049a831View commit details -
Rollup merge of rust-lang#75480 - ssomers:btree_check_invariant, r=Ma…
…rk-Simulacrum BTreeMap: check some invariants in unit tests
Configuration menu - View commit details
-
Copy full SHA for cb5d1a7 - Browse repository at this point
Copy the full SHA cb5d1a7View commit details -
Rollup merge of rust-lang#75499 - jack-champagne:jack-champagne/issue…
…-75412, r=Dylan-DPC Fix documentation error This should fix rust-lang#75412. Just a quick >= to > sign replacement.
Configuration menu - View commit details
-
Copy full SHA for 5fe695b - Browse repository at this point
Copy the full SHA 5fe695bView commit details -
Rollup merge of rust-lang#75554 - jumbatm:fix-clashing-extern-decl-ov…
…erflow, r=lcnr Fix clashing_extern_declarations stack overflow for recursive types. Fixes rust-lang#75512. Adds a seen set to `structurally_same_type` to avoid recursing indefinitely for types which contain values of the same type through a pointer or reference.
Configuration menu - View commit details
-
Copy full SHA for 0c0323f - Browse repository at this point
Copy the full SHA 0c0323fView commit details -
Rollup merge of rust-lang#75646 - poliorcetics:intra-links-keywords, …
…r=jyn514 Move to intra doc links for keyword documentation Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
Configuration menu - View commit details
-
Copy full SHA for 96c8293 - Browse repository at this point
Copy the full SHA 96c8293View commit details -
Rollup merge of rust-lang#75649 - jyn514:inherent-lang-impls, r=Guill…
…aumeGomez Fix intra-doc links for inherent impls that are both lang items and not the default impl I found in rust-lang#75464 (comment) that `str::to_uppercase()` doesn't resolve while `str::trim()` does. The only real difference is that `to_uppercase` is defined in `alloc`, while trim is defined in `core`. It turns out that rustdoc was ignoring `lang_items.str_alloc_impl()` - it saw them in `collect_trait_impls`, but not for intra-doc links. This uses the same `impls` for all parts of rustdoc, so that there can be no more inconsistency. It does have the slight downside that the matches are no longer exhaustive but it will be very clear if a new lang item is missed because it will panic when you try to document it (and if you don't document it, does rustdoc really need to know about it?). ~~This needs a test case (probably just `str::to_uppercase`).~~ Added. This is best reviewed commit-by-commit. r? @GuillaumeGomez
Configuration menu - View commit details
-
Copy full SHA for 6544893 - Browse repository at this point
Copy the full SHA 6544893View commit details -
Rollup merge of rust-lang#75658 - tgnottingham:issue-75599, r=estebank
Don't emit "is not a logical operator" error outside of associative expressions Avoid showing this error where it doesn't make sense by not assuming "and" and "or" were intended to mean "&&" and "||" until after we decide to continue parsing input as an associative expression. Note that the decision of whether or not to continue parsing input as an associative expression doesn't actually depend on this assumption. Fixes rust-lang#75599 --- First time contributor! Let me know if there are any conventions or policies I should be following that I missed here. Thanks :)
Configuration menu - View commit details
-
Copy full SHA for 24e6035 - Browse repository at this point
Copy the full SHA 24e6035View commit details -
Rollup merge of rust-lang#75665 - GuillaumeGomez:doc-examples-coverag…
…e, r=jyn514 Add doc examples coverage r? @jyn514
Configuration menu - View commit details
-
Copy full SHA for b6daefb - Browse repository at this point
Copy the full SHA b6daefbView commit details -
Rollup merge of rust-lang#75685 - nixphix:docs/unix-ext, r=jyn514
Switch to intra-doc links in /src/sys/unix/ext/*.rs Partial fix for rust-lang#75080 @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc r? @jyn514 These two links are not resolving to either `crate::fs::File...` or `fs::File...` ``` # unix/ext/fs.rs 27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read 130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write ```
Configuration menu - View commit details
-
Copy full SHA for 5013e01 - Browse repository at this point
Copy the full SHA 5013e01View commit details