Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #76373

Closed
wants to merge 51 commits into from

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

the8472 and others added 30 commits August 12, 2020 01:30
…ttemted on a NFS mount under RHEL/CentOS 7.

The syscall is supposed to return ENOSYS in most cases but when calling it on NFS it may leak through
EOPNOTSUPP even though that's supposed to be handled by the kernel and not returned to userspace.
Since it returns ENOSYS in some cases anyway this will trip the  HAS_COPY_FILE_RANGE
detection anyway, so treat EOPNOTSUPP as if it were a ENOSYS.

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/7.8_release_notes/deprecated_functionality#the_literal_copy_file_range_literal_call_has_been_disabled_on_local_file_systems_and_in_nfs
https://bugzilla.redhat.com/show_bug.cgi?id=1783554
… on file size

This solves several problems

- race conditions where a file is truncated while copying from it. if we blindly trusted
  the file size this would lead to an infinite loop
- proc files appearing empty to copy_file_range but not to read/write
  coreutils/coreutils@4b04a0c
- copy_file_range returning 0 for some filesystems (overlay? bind mounts?)
  inside docker, again leading to an infinite loop

Verified

This commit was signed with the committer’s verified signature.
JohnTitor Yuki Okushi

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
typo

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Andrew Hickman <andrew.hickman1@sky.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
It is not always obvious that people could see the docs for `&`
especially for beginners, it also helps learnability.
This removes the incorrect error, but doesn't show the documentation
anywhere.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Now this actually tests the links are generated correctly

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Related to rust-lang#65354

- Pass through the replacement text to `markdown.rs`
- Add some tests
- Add a state machine that actually replaces the text when parsing Markdown

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Often when modifying compiler code you'll miss that you've changed an API used
by unit tests, since x.py check didn't previously catch that.

It's also useful to have this for editing with rust-analyzer and similar tooling
where editing tests previously didn't notify you of errors in test files.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
first_ptr -> slice_as_ptr
first_ptr_mut -> slice_as_mut_ptr
slice_get_ref -> slice_assume_init_ref
slice_get_mut -> slice_assume_init_mut
- Preserve suffixes when displaying
- Rename test file to match `intra-link*`
- Remove unnecessary .clone()s
- Improve comments and naming
- Fix more bugs and add tests
- Escape intra-doc link example in public documentation
tmiasko and others added 21 commits September 4, 2020 20:01
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: matthewjasper <mjjasper1@gmail.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…triplett

Workarounds for copy_file_range issues

fixes rust-lang#75387
fixes rust-lang#75446

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add a regression test for issue-72793

Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…r=matthewjasper

Refactor byteorder to std in rustc_middle

Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ing_issues, r=steveklabnik

Unstable Book: add links to tracking issues for FFI features

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
`impl Rc::new_cyclic`

References rust-lang#75861

r? @Dylan-DPC

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Link vec doc to & reference

It is not always obvious that people could see the docs for `&`
especially for beginners, it also helps learnability.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Remove disambiguators from intra doc link text

Closes rust-lang#65354.
r? @Manishearth

The commits are mostly atomic, but there might be some mix between them here and there. I recommend reading 'refactor ItemLink' and 'refactor RenderedLink' on their own though, lots of churn without any logic changes.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…uillaumeGomez

Fix intra-doc links on pub re-exports

Partial fix for rust-lang#76073 - This removes the incorrect error, but doesn't show the documentation anywhere.
r? @GuillaumeGomez

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…odrAus

Use Arc::clone and Rc::clone in documentation

This PR replaces uses of `x.clone()` by `Rc::clone(&x)` (or `Arc::clone(&x)`) to better match the documentation for those types.

@rustbot modify labels: T-doc

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
rename MaybeUninit slice methods

The `first` methods conceptually point to the whole slice, not just its first element, so rename them to be consistent with the raw ptr methods on ref-slices.

Also, do the equivalent of rust-lang#76047 for the slice reference getters, and make them part of rust-lang#63569 (so far they somehow had no tracking issue).

* first_ptr -> slice_as_ptr
* first_ptr_mut -> slice_as_mut_ptr
* slice_get_ref -> slice_assume_init_ref
* slice_get_mut -> slice_assume_init_mut

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Add missing link in README

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fold length constant in Rvalue::Repeat

Fixes rust-lang#76248.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
x.py check checks tests/examples/benches

This also adds a check for bootstrap to x.py.

r? @ehuss

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ecstatic-morse

inliner: Check for codegen fn attributes compatibility

* Check for target features compatibility
* Check for no_sanitize attribute compatibility

Fixes rust-lang#76259.
@Dylan-DPC-zz Dylan-DPC-zz deleted the rollup-myeqw1o branch September 5, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet