Rollup of 11 pull requests #76376
Merged
Rollup of 11 pull requests #76376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not always obvious that people could see the docs for `&` especially for beginners, it also helps learnability.
This removes the incorrect error, but doesn't show the documentation anywhere.
…r around documenting re-exports
Now this actually tests the links are generated correctly
Proc-macro API currently exposes jointness in `Punct` tokens. That is, `+` in `+one` is **non** joint. Our lexer produces jointness info for all tokens, so we need to censor it *somewhere* Previously we did this in a lexer, but it makes more sense to do this in a proc-macro server.
Related to rust-lang#65354 - Pass through the replacement text to `markdown.rs` - Add some tests - Add a state machine that actually replaces the text when parsing Markdown
Often when modifying compiler code you'll miss that you've changed an API used by unit tests, since x.py check didn't previously catch that. It's also useful to have this for editing with rust-analyzer and similar tooling where editing tests previously didn't notify you of errors in test files.
Cloning a tt is cheap, but not free (there's Arc inside).
- Preserve suffixes when displaying - Rename test file to match `intra-link*` - Remove unnecessary .clone()s - Improve comments and naming - Fix more bugs and add tests - Escape intra-doc link example in public documentation
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
Co-authored-by: matthewjasper <mjjasper1@gmail.com>
Add a regression test for issue-72793 Adds a regression test for rust-lang#72793, which is fixed by rust-lang#75443. Note that this won't close the issue as the snippet still shows ICE with `-Zmir-opt-level=2`. But it makes sense to add a test anyway.
…r=matthewjasper
Refactor byteorder to std in rustc_middle
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
…ing_issues, r=steveklabnik Unstable Book: add links to tracking issues for FFI features
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
Link vec doc to & reference It is not always obvious that people could see the docs for `&` especially for beginners, it also helps learnability.
Remove disambiguators from intra doc link text Closes rust-lang#65354. r? @Manishearth The commits are mostly atomic, but there might be some mix between them here and there. I recommend reading 'refactor ItemLink' and 'refactor RenderedLink' on their own though, lots of churn without any logic changes.
…uillaumeGomez Fix intra-doc links on pub re-exports Partial fix for rust-lang#76073 - This removes the incorrect error, but doesn't show the documentation anywhere. r? @GuillaumeGomez
Fold length constant in Rvalue::Repeat Fixes rust-lang#76248.
x.py check checks tests/examples/benches This also adds a check for bootstrap to x.py. r? @ehuss
…ecstatic-morse inliner: Check for codegen fn attributes compatibility * Check for target features compatibility * Check for no_sanitize attribute compatibility Fixes rust-lang#76259.
Move jointness censoring to proc_macro Proc-macro API currently exposes jointness in `Punct` tokens. That is, `+` in `+one` is **non** joint. Our lexer produces jointness info for all tokens, so we need to censor it *somewhere* Previously we did this in a lexer, but it makes more sense to do this in a proc-macro server. r? @petrochenkov
|
@bors r+ rollup=never p=5 |
|
📌 Commit 85cee57 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Sep 5, 2020
|
Still confirming, but it looks like something about this rollup was a change in caching behavior in Cargo, causing perf to start rebuilding webrender-wrench dependencies. I suspect #76285 might've been the cause... |
|
It's #76399. |
This was referenced Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
impl Rc::new_cyclic#75994 (impl Rc::new_cyclic)Failed merges:
r? @ghost