Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 19 pull requests #76948

Closed
wants to merge 54 commits into from

Commits on Sep 16, 2020

  1. Don't generate bootstrap usage unless it's needed

    Previously, `x.py` would unconditionally run `x.py build` to get the
    help message. After rust-lang#76165,
    when checking the CI stage was moved into `Config`, that would cause an
    assertion failure (but only only in CI!):
    
    ```
    thread 'main' panicked at 'assertion failed: `(left == right)`
      left: `1`,
     right: `2`', src/bootstrap/config.rs:619:49
    ```
    
    This changes bootstrap to only generate a help message when it needs
    to (when someone passes `--help`).
    jyn514 committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    c35ce3f View commit details
    Browse the repository at this point in the history
  2. Update LLVM

    Jethro Beekman committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    1d2290f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ed6c7ef View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c3607bd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e4edc16 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    81b3b66 View commit details
    Browse the repository at this point in the history
  7. Bless miri-unleashed tests

    `const_mut_refs` doesn't actually work in a `const` or `static`
    ecstatic-morse committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    1e1257b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    abc7167 View commit details
    Browse the repository at this point in the history
  9. Pass --target to lint docs

    Otherwise, we may not have a standard library built for the native "host" target
    of the rustc being run.
    Mark-Simulacrum committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    7e24136 View commit details
    Browse the repository at this point in the history
  10. Build rustdoc for cross-compiled targets

    This isn't an issue for most folks who use x.py dist, which will directly depend
    on this. But for x.py build, if we don't properly set target here rustdoc will
    not be built.
    
    Currently, there is not a default-on step for generating a rustc for a given
    target either, so we will fail to build a rustc as well.
    Mark-Simulacrum committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    bd4e0af View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2020

  1. use strip_prefix over starts_with and manual slicing based on pattern…

    … length (clippy::manual_strip)
    matthiaskrgr committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    012974d View commit details
    Browse the repository at this point in the history
  2. Let backends define custom targets

    Add a target_override hook that takes priority over builtin targets.
    khyperia committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    c946c40 View commit details
    Browse the repository at this point in the history
  3. PR feedback

    khyperia committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    48655c2 View commit details
    Browse the repository at this point in the history
  4. Remove redundant to_string

    zzau13 committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    7b5d983 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    76ec3f8 View commit details
    Browse the repository at this point in the history
  6. update Miri

    RalfJung committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    643eb07 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    363aff0 View commit details
    Browse the repository at this point in the history
  8. Use intra-doc links

    denisvasilik committed Sep 17, 2020
    Configuration menu
    Copy the full SHA
    8e9ad31 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3323a26 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    878dfa6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. Don't download/sync llvm-project submodule if download-ci-llvm is set

    llvm-project takes > 1GB storage space and a long time to download.
    It's better to not download it unless needed.
    est31 committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    f05b47c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    28cfa97 View commit details
    Browse the repository at this point in the history
  3. Remove unused libc feature gate

    Libc isn't used by alloc.
    And std and panic_* use libc from crates.io now,
    which isn't feature gated.
    est31 committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    baafc71 View commit details
    Browse the repository at this point in the history
  4. Apply suggestions from code review

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    poliorcetics and Joshua Nelson authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    4c92b3d View commit details
    Browse the repository at this point in the history
  5. Use intra-doc links

    denisvasilik committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    bdb039d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f272896 View commit details
    Browse the repository at this point in the history
  7. Remove DeclareMethods

    khyperia committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    0bc405e View commit details
    Browse the repository at this point in the history
  8. support panic=abort in Miri

    RalfJung committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    0810c3e View commit details
    Browse the repository at this point in the history
  9. bootstrap: move the version number to a plaintext file

    The Rust version number is currently embedded in bootstrap's source
    code, which makes it hard to update it automatically or access it
    outside of ./x.py (as you'd have to parse the source code).
    
    This commit moves the version number to a standalone plaintext file,
    which makes accessing or updating it trivial.
    pietroalbini committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    b9af3e3 View commit details
    Browse the repository at this point in the history
  10. Update library/alloc/src/collections/binary_heap.rs

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    denisvasilik and Joshua Nelson authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    2230d8d View commit details
    Browse the repository at this point in the history
  11. Update library/alloc/src/collections/binary_heap.rs

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    denisvasilik and Joshua Nelson authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    ec7225f View commit details
    Browse the repository at this point in the history
  12. Update library/alloc/src/collections/binary_heap.rs

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    denisvasilik and Joshua Nelson authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    62e0ee1 View commit details
    Browse the repository at this point in the history
  13. Update library/alloc/src/collections/binary_heap.rs

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    denisvasilik and Joshua Nelson authored Sep 18, 2020
    Configuration menu
    Copy the full SHA
    719c40c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    25883aa View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2020

  1. Record tcx.def_span instead of item.span in crate metadata

    This was missed in PR rust-lang#75465. As a result, a few places have been using
    the full body span of functions, instead of just the header span.
    Aaron1011 committed Sep 19, 2020
    Configuration menu
    Copy the full SHA
    0d0a3e1 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#76799 - Mark-Simulacrum:fix-cross-compile-d…

    …ist, r=alexcrichton
    
    Fix cross compiling dist/build invocations
    
    I am uncertain why the first commit is not affecting CI. I suspect it's because we pass --disable-docs on most of our cross-compilation builders. The second commit doesn't affect CI because CI runs x.py dist, not x.py build.
    
    Both commits are standalone; together they should resolve rust-lang#76733. The first commit doesn't really fix that issue but rather just fixes cross-compiled x.py dist, resolving a bug introduced in rust-lang#76549.
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    ca47be8 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#76800 - jyn514:usage, r=Mark-Simulacrum

    Don't generate bootstrap usage unless it's needed
    
    Previously, `x.py` would unconditionally run `x.py build` to get the
    help message. After rust-lang#76165,
    when checking the CI stage was moved into `Config`, that would cause an
    assertion failure (but only only in CI!):
    
    ```
    thread 'main' panicked at 'assertion failed: `(left == right)`
      left: `1`,
     right: `2`', src/bootstrap/config.rs:619:49
    ```
    
    This changes bootstrap to only generate a help message when it needs
    to (when someone passes `--help`).
    
    r? @Mark-Simulacrum
    This should fix the CI failures in rust-lang#76797 and rust-lang#75991.
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    0a2a7b5 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#76806 - jethrogb:jb/update-llvm, r=cuviper

    Update LLVM
    
    This (partially?) addresses rust-lang#74632
    
    r? @cuviper
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    9dd5eeb View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#76807 - ecstatic-morse:const-checking-stage…

    …d-api, r=oli-obk
    
    Use const-checking to forbid use of unstable features in const-stable functions
    
    First step towards rust-lang#76618.
    
    Currently this code isn't ever hit because `qualify_min_const_fn` runs first and catches pretty much everything. One exception is `const_precise_live_drops`, which does not use the newly added code since it runs as part of a separate pass.
    
    Also contains some unrelated refactoring, which is split into separate commits.
    
    r? @oli-obk
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    d58ee82 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#76828 - matthiaskrgr:clippy_manual_strip, r…

    …=lcnr
    
    use strip_prefix over starts_with and manual slicing based on pattern length (clippy::manual_strip)
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    c20e2e2 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#76832 - khyperia:backend_target_override, r…

    …=eddyb
    
    Let backends define custom targets
    
    Add a target_override hook that takes priority over builtin targets.
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    0660bc0 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#76840 - poliorcetics:intra-doc-core-sync-an…

    …d-future, r=jyn514
    
    Move to intra doc links in core/src/future
    
    Helps with rust-lang#75080.
    
    @rustbot modify labels: T-doc A-intra-doc-links
    
    r? @jyn514
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    8274258 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#76845 - Amjad50:fix-intra-docs-links, r=jyn514

    Use intra docs links in core::{ascii, option, str, pattern, hash::map}
    
    Partial fix for rust-lang#75080
    
    @rustbot modify labels: T-doc A-intra-doc-links
    
    r? @jyn514
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    f4958c9 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#76846 - botika:master, r=davidtwco

    Avoiding unnecesary allocations at rustc_errors
    
    Simplify the code avoiding allocations with easy alternative
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    d77f264 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#76848 - RalfJung:miri, r=RalfJung

    update Miri
    
    Let's get rust-lang/miri#1540 shipped.
    Cc @rust-lang/miri r? @ghost
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    acc37f3 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#76853 - denisvasilik:intra-doc-links-core-w…

    …ake, r=jyn514
    
    Use intra-doc links in library/core/src/task/wake.rs
    
    Helps with rust-lang#75080.
    
    @rustbot modify labels: T-doc, A-intra-doc-links
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    18cc1b0 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#76864 - est31:downloaded_llvm_no_clone_sour…

    …ces, r=Mark-Simulacrum
    
    Don't download/sync llvm-project submodule if download-ci-llvm is set
    
    llvm-project takes > 1GB storage space and a long time to download.
    It's better to not download it unless needed.
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    558be8b View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#76866 - est31:master, r=lcnr

    Remove unused feature gates from library/ crates
    
    Removes some unused feature gates from library crates. It's likely not a complete list as I only tested a subset for which it's more likely that it is unused.
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    b173c62 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#76871 - RalfJung:miri-panic-abort, r=dtolnay

    support panic=abort in Miri
    
    This is needed for rust-lang/miri#1058 on Windows: we cannot run the inline-assembly versions of `abort`, so fall back to the intrinsic (which Miri supports).
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    6144a3e View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#76872 - khyperia:remove_declare_methods, r=…

    …eddyb
    
    Remove DeclareMethods
    
    Most of the `DeclareMethods` API was only used internally by rustc_codegen_llvm. As such, it makes no sense to require other backends to implement them.
    
    (`get_declared_value` and `declare_cfn` were used, in one place, specific to the `main` symbol, which I've replaced with a more specialized function to allow more flexibility in implementation - the intent is that `declare_c_main` can go away once we do something more clever, e.g. @eddyb has ideas around having a MIR shim or somesuch we can explore in a follow-up PR)
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    d89d8a1 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#76875 - denisvasilik:intra-doc-links-alloc-…

    …binary-heap, r=jyn514
    
    Move to intra-doc links in library/alloc/src/collections/binary_heap.rs
    
    Helps with rust-lang#75080.
    
    @rustbot modify labels: T-doc, A-intra-doc-links
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    2f58ec2 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#76878 - pietroalbini:version, r=Mark-Simula…

    …crum
    
    Move the version number to a plaintext file
    
    The Rust version number is currently embedded in bootstrap's source code, which makes it hard to update it automatically or access it outside of ./x.py (as you'd have to parse the source code).
    
    This PR moves the version number to a standalone plaintext file, which makes accessing or updating it trivial.
    
    r? @Mark-Simulacrum
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    a47d593 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#76881 - hameerabbasi:issue-53325, r=oli-obk

    Add allocation information to undefined behaviour errors.
    
    So far I'm looking on information on whether the error messages are suitable.
    
    Fixes rust-lang#53325.
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    7ff0ad1 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#76898 - Aaron1011:fix/item-def-span, r=oli-obk

    Record `tcx.def_span` instead of `item.span` in crate metadata
    
    This was missed in PR rust-lang#75465. As a result, a few places have been using
    the full body span of functions, instead of just the header span.
    Dylan-DPC authored Sep 19, 2020
    Configuration menu
    Copy the full SHA
    0a2a7fb View commit details
    Browse the repository at this point in the history