Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloc vec use imported path #77340

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Alloc vec use imported path #77340

merged 1 commit into from
Sep 30, 2020

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Sep 29, 2020

mem::ManuallyDrop::new -> ManuallyDrop::new

cc @the8472

mem::ManuallyDrop::new -> ManuallyDrop::new
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2020
@the8472
Copy link
Member

the8472 commented Sep 29, 2020

Uh, why are you doing a dozen PRs to make tiny changes to my specialization PR? You could have reviewed it when it was open for months, then I could have finished it immediately 😟
But sure, nothing wrong with the change itself.

@kennytm
Copy link
Member

kennytm commented Sep 29, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 29, 2020

📌 Commit f9b625f has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Sep 29, 2020

Uh, why are you doing a dozen PRs to make tiny changes to my specialization PR? You could have reviewed it when it was open for months, then I could have finished it immediately worried

Yeah, I wonder why all my PRs is related to your PR. I wish it could reviewed it last time but probably I missed it, by the time I saw it it was already merged. Since I was copying word by word on vec for one of my project so I easily noticed the typos. Feel free to ping to regarding vec next time, at least I don't need to send so many PRs and have more eyes to look at it.

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 30, 2020
…as-schievink

Rollup of 12 pull requests

Successful merges:

 - rust-lang#77037 (more tiny clippy cleanups)
 - rust-lang#77233 (BTreeMap: keep an eye out on the size of the main components)
 - rust-lang#77280 (Ensure that all LLVM components requested by tests are available on CI)
 - rust-lang#77284 (library: Forward compiler-builtins "mem" feature)
 - rust-lang#77296 (liveness: Use Option::None to represent absent live nodes)
 - rust-lang#77322 (Add unstable book docs for `-Zunsound-mir-opts`)
 - rust-lang#77328 (Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn())
 - rust-lang#77331 (Add test for async/await combined with const-generics.)
 - rust-lang#77338 (Fix typo in alloc vec comment)
 - rust-lang#77340 (Alloc vec use imported path)
 - rust-lang#77345 (Add test for issue rust-lang#74761)
 - rust-lang#77348 (Update books)

Failed merges:

r? `@ghost`
@bors bors merged commit fea2ad8 into rust-lang:master Sep 30, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 30, 2020
@pickfire pickfire deleted the patch-9 branch October 1, 2020 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants