Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark repr128 as incomplete_features #77488

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Mark repr128 as incomplete_features #77488

merged 2 commits into from
Oct 23, 2020

Conversation

varkor
Copy link
Member

@varkor varkor commented Oct 3, 2020 •
edited
Loading

As mentioned in #56071 and noticed in #77457, repr(u128) and repr(i128) do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.

Closes #77457.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2020
@jonas-schievink
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 11, 2020

📌 Commit db0438b has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 11, 2020
@RalfJung
Copy link
Member

With PRs like this, it is rather unfortunate that the stdlib sets #![allow(incomplete_features)]... I suppose that's mostly due to const generics, so it'll be hard to do anything about this?

@varkor
Copy link
Member Author

varkor commented Oct 12, 2020

I suppose that's mostly due to const generics, so it'll be hard to do anything about this?

I believe so. It's possible some of the uses may only require min_const_generics, which would avoid this problem. It could be worth trying to switch.

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 12, 2020
@JohnTitor
Rollup merge of rust-lang#77488 - varkor:repr128-incomplete_features,…
357c683 
… r=jonas-schievink

Mark `repr128` as `incomplete_features`

As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.

Closes rust-lang#77457.
@JohnTitor JohnTitor mentioned this pull request Oct 12, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 12, 2020
@JohnTitor
Rollup merge of rust-lang#77488 - varkor:repr128-incomplete_features,…
27a00dc 
… r=jonas-schievink

Mark `repr128` as `incomplete_features`

As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.

Closes rust-lang#77457.
@JohnTitor JohnTitor mentioned this pull request Oct 12, 2020
Closed
@JohnTitor
Copy link
Member

Failed in https://github.com/rust-lang-ci/rust/runs/1243760569:

---- compile_test stdout ----
thread 'compile_test' panicked at 'Some tests failed', /cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.5.0/src/lib.rs:105:22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    compile_test

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--test compile-test'


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/clippy/Cargo.toml" "--features" "rustc-workspace-hack/all-static" "--"
expected success, got: exit code: 101


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --stage 2 src/tools/clippy

Seems some tests on clippy also need a tweak.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 12, 2020
@bors
Copy link
Contributor

bors commented Oct 17, 2020

☔ The latest upstream changes (presumably #77124) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@varkor varkor force-pushed the repr128-incomplete_features branch from db0438b to 683db31 Compare October 22, 2020 12:23
@varkor
Copy link
Member Author

varkor commented Oct 22, 2020

@bors r=jonas-schievink

@bors
Copy link
Contributor

bors commented Oct 22, 2020

📌 Commit 683db31 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 22, 2020
@Dylan-DPC
Rollup merge of rust-lang#77488 - varkor:repr128-incomplete_features,…
84b134c 
… r=jonas-schievink

Mark `repr128` as `incomplete_features`

As mentioned in rust-lang#56071 and noticed in rust-lang#77457, `repr(u128)` and `repr(i128)` do not work properly due to lack of LLVM support. We should thus warn users trying to use the feature that they may encounter ICEs when using it.

Closes rust-lang#77457.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Oct 22, 2020
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2020
@bors
Auto merge of rust-lang#78270 - JohnTitor:rollup-bldrjh5, r=JohnTitor
07a63e6 
Rollup of 17 pull requests

Successful merges:

 - rust-lang#77268 (Link to "Contributing to Rust" rather than "Getting Started".)
 - rust-lang#77339 (Implement TryFrom between NonZero types.)
 - rust-lang#77488 (Mark `repr128` as `incomplete_features`)
 - rust-lang#77890 (Fixing escaping to ensure generation of welformed json.)
 - rust-lang#77918 (Cleanup network tests)
 - rust-lang#77920 (Avoid extraneous space between visibility kw and ident for statics)
 - rust-lang#77969 (Doc formating consistency between slice sort and sort_unstable, and big O notation consistency)
 - rust-lang#78098 (Clean up and improve some docs)
 - rust-lang#78116 (Make inline const work in range patterns)
 - rust-lang#78153 (Sync LLVM submodule if it has been initialized)
 - rust-lang#78163 (Clean up lib docs)
 - rust-lang#78169 (Update cargo)
 - rust-lang#78231 (Make closures inherit the parent function's target features)
 - rust-lang#78235 (Explain where the closure return type was inferred)
 - rust-lang#78255 (Reduce diagram mess in 'match arms have incompatible types' error)
 - rust-lang#78263 (Add regression test of issue-77668)
 - rust-lang#78265 (Add some inference-related regression tests about incorrect diagnostics)

Failed merges:

r? `@ghost`
@bors bors merged commit da3e41e into rust-lang:master Oct 23, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

Panic in nightly using repr(u128) with constant higher than is representable
8 participants
@varkor @rust-highfive @jonas-schievink @bors @RalfJung @JohnTitor @eddyb @rustbot