Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make closures inherit the parent function's target features #78231

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Make closures inherit the parent function's target features #78231

merged 2 commits into from
Oct 23, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut commented Oct 22, 2020 •
edited
Loading

r? @ghost
Closes #73631

@LeSeulArtichaut LeSeulArtichaut added the F-target_feature_11 target feature 1.1 RFC label Oct 22, 2020
@LeSeulArtichaut LeSeulArtichaut marked this pull request as ready for review October 22, 2020 13:19
@LeSeulArtichaut LeSeulArtichaut changed the title [WIP] Make closures inherit the parent function's target features Make closures inherit the parent function's target features Oct 22, 2020
@LeSeulArtichaut LeSeulArtichaut added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 22, 2020
@LeSeulArtichaut
Copy link
Contributor Author

I don’t know who should review this... maybe r? @petrochenkov cc @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Oct 22, 2020

📌 Commit b4a9854 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2020
@bors
Auto merge of rust-lang#78270 - JohnTitor:rollup-bldrjh5, r=JohnTitor
07a63e6 
Rollup of 17 pull requests

Successful merges:

 - rust-lang#77268 (Link to "Contributing to Rust" rather than "Getting Started".)
 - rust-lang#77339 (Implement TryFrom between NonZero types.)
 - rust-lang#77488 (Mark `repr128` as `incomplete_features`)
 - rust-lang#77890 (Fixing escaping to ensure generation of welformed json.)
 - rust-lang#77918 (Cleanup network tests)
 - rust-lang#77920 (Avoid extraneous space between visibility kw and ident for statics)
 - rust-lang#77969 (Doc formating consistency between slice sort and sort_unstable, and big O notation consistency)
 - rust-lang#78098 (Clean up and improve some docs)
 - rust-lang#78116 (Make inline const work in range patterns)
 - rust-lang#78153 (Sync LLVM submodule if it has been initialized)
 - rust-lang#78163 (Clean up lib docs)
 - rust-lang#78169 (Update cargo)
 - rust-lang#78231 (Make closures inherit the parent function's target features)
 - rust-lang#78235 (Explain where the closure return type was inferred)
 - rust-lang#78255 (Reduce diagram mess in 'match arms have incompatible types' error)
 - rust-lang#78263 (Add regression test of issue-77668)
 - rust-lang#78265 (Add some inference-related regression tests about incorrect diagnostics)

Failed merges:

r? `@ghost`
@bors bors merged commit 00c4dcd into rust-lang:master Oct 23, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 23, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the closure-target_feature branch October 23, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@petrochenkov petrochenkov

Labels
F-target_feature_11 target feature 1.1 RFC S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

target-feature 1.1: should closures inherit target-feature annotations?
5 participants
@LeSeulArtichaut @nikomatsakis @bors @petrochenkov @rustbot