Add built-in support for the armv5te-unknown-linux-uclibcgnueabi target #78142

operutka · 2020-10-20T14:14:49Z

Hi!

I'd like to add built-in support for the armv5te-unknown-linux-uclibcgnueabi target. It's a pretty common target used by many devices like routers and IP cameras. It's mostly a copy-paste of armv5te-unknown-linux-gnueabi. I've tested it on a quite complex application that uses tokio, openssl and a lot of other stuff and everything seems to be working fine.

I'm not sure about the post_link_args but the point is that my linker fails when -ldl isn't specified. Maybe there is a better place where to put this option...

It's my first contribution to Rust itself, so feel free to wash my head 😄

Note: The app mentioned above was built with this in my .cargo/config:

[unstable]
build-std = ["core", "std", "alloc", "proc_macro", "panic_abort"]
build-std-features = ["panic_immediate_abort"]

rust-highfive · 2020-10-20T14:14:52Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Dylan-DPC-zz · 2020-11-24T16:55:41Z

r? @Mark-Simulacrum

operutka · 2020-11-27T11:12:54Z

I've added one small fix that fixes builds when the "panic_immediate_abort" std feature is not enabled (there were some missing symbols, namely _Unwind_Backtrace and _Unwind_VRS_Get). I've tested it with two independent gcc toolchains and all panic strategies seem to work now.

compiler/rustc_target/src/spec/armv5te_unknown_linux_uclibcgnueabi.rs

Mark-Simulacrum · 2020-11-28T13:29:07Z

r? @petrochenkov

I am not sure that we have a firm policy yet on adding tier 3 targets, but since they're essentially unstable I am not majorly opposed to doing so.

compiler/rustc_target/src/spec/mod.rs

petrochenkov · 2020-11-28T13:53:21Z

I don't know anything about this target specifically, but it looks entirely acceptable for tier 3, I only have one question about target naming consistency.

operutka · 2020-11-30T08:28:46Z

I'm just curious - what exactly needs to happen to move a target from tier 3 to tier 2? My goal is to have std builds available, so I don't have to use Rust nightly for production applications.

operutka · 2020-11-30T09:30:35Z

I've fixed the naming inconsistency and squashed the commits.

petrochenkov · 2020-11-30T09:31:50Z

@operutka

what exactly needs to happen to move a target from tier 3 to tier 2?

There's an in-progress target tier RFC describing the tentative rules - rust-lang/rfcs#2803.

@bors r+

bors · 2020-11-30T09:31:52Z

📌 Commit b2ad73e has been approved by petrochenkov

bors · 2020-11-30T11:36:31Z

⌛ Testing commit b2ad73e with merge 7c4baff40baee41be073d70e2631405ee65c0a77...

bors · 2020-11-30T15:51:31Z

💥 Test timed out

petrochenkov · 2020-11-30T20:58:39Z

@bors retry

bors · 2020-12-01T04:53:45Z

⌛ Testing commit b2ad73e with merge 29c4358...

bors · 2020-12-01T07:00:35Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 29c4358 to master...

Pkgsrc changes: * Adjust patches, re-compute line offsets, fix capitalization. * Remove i686/FreeBSD support, no longer provided upstream. * Bump bootstraps to 1.49.0. * Change USE_TOOLS from bsdtar to gtar. * Reduce diffs to pkgsrc-wip package patches. * Allow rust.BUILD_TARGET to override automatic choice of target. * Add an i586/NetBSD (pentium) bootstrap variant (needs testing), not yet added as bootstrap since 1.49 doesn't have that variant. Upstream changes: Version 1.50.0 (2021-02-11) ============================ Language ----------------------- - [You can now use `const` values for `x` in `[x; N]` array expressions.][79270] This has been technically possible since 1.38.0, as it was unintentionally stabilized. - [Assignments to `ManuallyDrop<T>` union fields are now considered safe.][78068] Compiler ----------------------- - [Added tier 3\* support for the `armv5te-unknown-linux-uclibceabi` target.][78142] - [Added tier 3 support for the `aarch64-apple-ios-macabi` target.][77484] - [The `x86_64-unknown-freebsd` is now built with the full toolset.][79484] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries ----------------------- - [`proc_macro::Punct` now implements `PartialEq<char>`.][78636] - [`ops::{Index, IndexMut}` are now implemented for fixed sized arrays of any length.][74989] - [On Unix platforms, the `std::fs::File` type now has a "niche" of `-1`.][74699] This value cannot be a valid file descriptor, and now means `Option<File>` takes up the same amount of space as `File`. Stabilized APIs --------------- - [`bool::then`] - [`btree_map::Entry::or_insert_with_key`] - [`f32::clamp`] - [`f64::clamp`] - [`hash_map::Entry::or_insert_with_key`] - [`Ord::clamp`] - [`RefCell::take`] - [`slice::fill`] - [`UnsafeCell::get_mut`] The following previously stable methods are now `const`. - [`IpAddr::is_ipv4`] - [`IpAddr::is_ipv6`] - [`Layout::size`] - [`Layout::align`] - [`Layout::from_size_align`] - `pow` for all integer types. - `checked_pow` for all integer types. - `saturating_pow` for all integer types. - `wrapping_pow` for all integer types. - `next_power_of_two` for all unsigned integer types. - `checked_power_of_two` for all unsigned integer types. Cargo ----------------------- - [Added the `[build.rustc-workspace-wrapper]` option.][cargo/8976] This option sets a wrapper to execute instead of `rustc`, for workspace members only. - [`cargo:rerun-if-changed` will now, if provided a directory, scan the entire contents of that directory for changes.][cargo/8973] - [Added the `--workspace` flag to the `cargo update` command.][cargo/8725] Misc ---- - [The search results tab and the help button are focusable with keyboard in rustdoc.][79896] - [Running tests will now print the total time taken to execute.][75752] Compatibility Notes ------------------- - [The `compare_and_swap` method on atomics has been deprecated.][79261] It's recommended to use the `compare_exchange` and `compare_exchange_weak` methods instead. - [Changes in how `TokenStream`s are checked have fixed some cases where you could write unhygenic `macro_rules!` macros.][79472] - [`#![test]` as an inner attribute is now considered unstable like other inner macro attributes, and reports an error by default through the `soft_unstable` lint.][79003] - [Overriding a `forbid` lint at the same level that it was set is now a hard error.][78864] - [Dropped support for all cloudabi targets.][78439] - [You can no longer intercept `panic!` calls by supplying your own macro.][78343] It's recommended to use the `#[panic_handler]` attribute to provide your own implementation. - [Semi-colons after item statements (e.g. `struct Foo {};`) now produce a warning.][78296] [74989]: rust-lang/rust#74989 [79261]: rust-lang/rust#79261 [79896]: rust-lang/rust#79896 [79484]: rust-lang/rust#79484 [79472]: rust-lang/rust#79472 [79270]: rust-lang/rust#79270 [79003]: rust-lang/rust#79003 [78864]: rust-lang/rust#78864 [78636]: rust-lang/rust#78636 [78439]: rust-lang/rust#78439 [78343]: rust-lang/rust#78343 [78296]: rust-lang/rust#78296 [78068]: rust-lang/rust#78068 [75752]: rust-lang/rust#75752 [74699]: rust-lang/rust#74699 [78142]: rust-lang/rust#78142 [77484]: rust-lang/rust#77484 [cargo/8976]: rust-lang/cargo#8976 [cargo/8973]: rust-lang/cargo#8973 [cargo/8725]: rust-lang/cargo#8725 [`IpAddr::is_ipv4`]: https://doc.rust-lang.org/stable/std/net/enum.IpAddr.html#method.is_ipv4 [`IpAddr::is_ipv6`]: https://doc.rust-lang.org/stable/std/net/enum.IpAddr.html#method.is_ipv6 [`Layout::align`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.align [`Layout::from_size_align`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.from_size_align [`Layout::size`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.size [`Ord::clamp`]: https://doc.rust-lang.org/stable/std/cmp/trait.Ord.html#method.clamp [`RefCell::take`]: https://doc.rust-lang.org/stable/std/cell/struct.RefCell.html#method.take [`UnsafeCell::get_mut`]: https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.get_mut [`bool::then`]: https://doc.rust-lang.org/stable/std/primitive.bool.html#method.then [`btree_map::Entry::or_insert_with_key`]: https://doc.rust-lang.org/stable/std/collections/btree_map/enum.Entry.html#method.or_insert_with_key [`f32::clamp`]: https://doc.rust-lang.org/stable/std/primitive.f32.html#method.clamp [`f64::clamp`]: https://doc.rust-lang.org/stable/std/primitive.f64.html#method.clamp [`hash_map::Entry::or_insert_with_key`]: https://doc.rust-lang.org/stable/std/collections/hash_map/enum.Entry.html#method.or_insert_with_key [`slice::fill`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.fill

rust-highfive assigned ecstatic-morse Oct 20, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 20, 2020

crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2020

rust-highfive assigned Mark-Simulacrum and unassigned ecstatic-morse Nov 24, 2020

operutka force-pushed the armv5te-unknown-linux-uclibcgnueabi-target branch from ddd7822 to ce67865 Compare November 27, 2020 12:43

petrochenkov reviewed Nov 27, 2020

View reviewed changes

compiler/rustc_target/src/spec/armv5te_unknown_linux_uclibcgnueabi.rs Outdated Show resolved Hide resolved

compiler/rustc_target/src/spec/armv5te_unknown_linux_uclibcgnueabi.rs Outdated Show resolved Hide resolved

operutka requested a review from petrochenkov November 27, 2020 17:29

rust-highfive assigned petrochenkov and unassigned Mark-Simulacrum Nov 28, 2020

petrochenkov reviewed Nov 28, 2020

View reviewed changes

compiler/rustc_target/src/spec/mod.rs Outdated Show resolved Hide resolved

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2020

Add built-in support for the armv5te-unknown-linux-uclibceabi target

b2ad73e

operutka force-pushed the armv5te-unknown-linux-uclibcgnueabi-target branch from 1d4a955 to b2ad73e Compare November 30, 2020 08:48

operutka requested a review from petrochenkov November 30, 2020 09:29

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 1, 2020

bors merged commit 29c4358 into rust-lang:master Dec 1, 2020

rustbot added this to the 1.50.0 milestone Dec 1, 2020

operutka deleted the armv5te-unknown-linux-uclibcgnueabi-target branch December 1, 2020 15:44

davidtwco mentioned this pull request Sep 20, 2023

target tier policy compliance #116004

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add built-in support for the armv5te-unknown-linux-uclibcgnueabi target #78142

Add built-in support for the armv5te-unknown-linux-uclibcgnueabi target #78142

operutka commented Oct 20, 2020

rust-highfive commented Oct 20, 2020

Dylan-DPC-zz commented Nov 24, 2020

operutka commented Nov 27, 2020

Mark-Simulacrum commented Nov 28, 2020

petrochenkov commented Nov 28, 2020

operutka commented Nov 30, 2020

operutka commented Nov 30, 2020

petrochenkov commented Nov 30, 2020

bors commented Nov 30, 2020

bors commented Nov 30, 2020

bors commented Nov 30, 2020

petrochenkov commented Nov 30, 2020

bors commented Dec 1, 2020

bors commented Dec 1, 2020

Add built-in support for the armv5te-unknown-linux-uclibcgnueabi target #78142

Add built-in support for the armv5te-unknown-linux-uclibcgnueabi target #78142

Conversation

operutka commented Oct 20, 2020

rust-highfive commented Oct 20, 2020

Dylan-DPC-zz commented Nov 24, 2020

operutka commented Nov 27, 2020

Mark-Simulacrum commented Nov 28, 2020

petrochenkov commented Nov 28, 2020

operutka commented Nov 30, 2020

operutka commented Nov 30, 2020

petrochenkov commented Nov 30, 2020

bors commented Nov 30, 2020

bors commented Nov 30, 2020

bors commented Nov 30, 2020

petrochenkov commented Nov 30, 2020

bors commented Dec 1, 2020

bors commented Dec 1, 2020