rustc_expand: Mark inner `#![test]` attributes as soft-unstable #79003

petrochenkov · 2020-11-12T21:25:47Z

Custom inner attributes are feature gated (#54726) except for attributes having name test literally, which are not gated for historical reasons.

#![test] is an inner proc macro attribute, so it has all the issues described in #54726 too.
This PR gates it with the soft_unstable lint.

rust-highfive · 2020-11-12T21:25:52Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2020-11-13T00:04:58Z

@bors r+

bors · 2020-11-13T00:04:59Z

📌 Commit cc6baf7 has been approved by estebank

ehuss · 2020-11-15T01:31:52Z

@bors r-

This failed in #79057, as it causes an error in the reference, and tools cannot be broken the week before beta.

The offending code is at https://github.com/rust-lang/reference/blob/e4e4972d013099a2c8eaed88680d7cb0bc7a688d/src/items/functions.md#attributes-on-functions

One suggestion is to change that example in the reference to something else (maybe #![allow(unused)]?).

(FWIW, I'm not entirely clear why this change is being made, as it may break existing projects that use this. I don't see any on crates.io that do, so it's probably not a concern, but it seems a bit aggressive to outright deny it.)

petrochenkov · 2020-11-15T12:02:30Z

Marking as blocked until the end of the no-breakage week.

(FWIW, I'm not entirely clear why this change is being made, as it may break existing projects that use this. I don't see any on crates.io that do, so it's probably not a concern, but it seems a bit aggressive to outright deny it.)

soft_unstable is deny-by-default and I din't want to introduce a new warn-by-default lint for this.
Seems ok given that the case is rare, the lint is allow-able and otherwise easily fixable, and dependent crates are not affected since it's a lint.

petrochenkov · 2020-11-20T16:35:55Z

@bors r=estebank

bors · 2020-11-20T16:35:56Z

📌 Commit 993bb07 has been approved by estebank

bors · 2020-11-20T18:41:08Z

⌛ Testing commit 993bb07 with merge 73d8dbe25ebdd0cb043ac41bc7eb01e3374dfb4e...

bors · 2020-11-20T22:56:08Z

💥 Test timed out

Aaron1011 · 2020-11-20T23:21:28Z

@bors retry

rustc_expand: Mark inner `#![test]` attributes as soft-unstable Custom inner attributes are feature gated (rust-lang#54726) except for attributes having name `test` literally, which are not gated for historical reasons. `#![test]` is an inner proc macro attribute, so it has all the issues described in rust-lang#54726 too. This PR gates it with the `soft_unstable` lint.

bors · 2020-11-21T05:52:21Z

⌛ Testing commit 993bb07 with merge 502c477...

bors · 2020-11-21T08:06:01Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 502c477 to master...

rust-highfive · 2020-11-21T08:07:01Z

📣 Toolstate changed by #79003!

Tested on commit 502c477.
Direct link to PR: #79003

💔 reference on windows: test-pass → test-fail (cc @matthewjasper @ehuss @steveklabnik @Havvy).
💔 reference on linux: test-pass → test-fail (cc @matthewjasper @ehuss @steveklabnik @Havvy).

@matthewjasper

Tested on commit rust-lang/rust@502c477. Direct link to PR: <rust-lang/rust#79003> 💔 reference on windows: test-pass → test-fail (cc @matthewjasper @ehuss @steveklabnik @Havvy). 💔 reference on linux: test-pass → test-fail (cc @matthewjasper @ehuss @steveklabnik @Havvy).

Using `test` causes a deny-by-default lint to trigger. See rust-lang/rust#79003 for more information.

Pkgsrc changes: * Adjust patches, re-compute line offsets, fix capitalization. * Remove i686/FreeBSD support, no longer provided upstream. * Bump bootstraps to 1.49.0. * Change USE_TOOLS from bsdtar to gtar. * Reduce diffs to pkgsrc-wip package patches. * Allow rust.BUILD_TARGET to override automatic choice of target. * Add an i586/NetBSD (pentium) bootstrap variant (needs testing), not yet added as bootstrap since 1.49 doesn't have that variant. Upstream changes: Version 1.50.0 (2021-02-11) ============================ Language ----------------------- - [You can now use `const` values for `x` in `[x; N]` array expressions.][79270] This has been technically possible since 1.38.0, as it was unintentionally stabilized. - [Assignments to `ManuallyDrop<T>` union fields are now considered safe.][78068] Compiler ----------------------- - [Added tier 3\* support for the `armv5te-unknown-linux-uclibceabi` target.][78142] - [Added tier 3 support for the `aarch64-apple-ios-macabi` target.][77484] - [The `x86_64-unknown-freebsd` is now built with the full toolset.][79484] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries ----------------------- - [`proc_macro::Punct` now implements `PartialEq<char>`.][78636] - [`ops::{Index, IndexMut}` are now implemented for fixed sized arrays of any length.][74989] - [On Unix platforms, the `std::fs::File` type now has a "niche" of `-1`.][74699] This value cannot be a valid file descriptor, and now means `Option<File>` takes up the same amount of space as `File`. Stabilized APIs --------------- - [`bool::then`] - [`btree_map::Entry::or_insert_with_key`] - [`f32::clamp`] - [`f64::clamp`] - [`hash_map::Entry::or_insert_with_key`] - [`Ord::clamp`] - [`RefCell::take`] - [`slice::fill`] - [`UnsafeCell::get_mut`] The following previously stable methods are now `const`. - [`IpAddr::is_ipv4`] - [`IpAddr::is_ipv6`] - [`Layout::size`] - [`Layout::align`] - [`Layout::from_size_align`] - `pow` for all integer types. - `checked_pow` for all integer types. - `saturating_pow` for all integer types. - `wrapping_pow` for all integer types. - `next_power_of_two` for all unsigned integer types. - `checked_power_of_two` for all unsigned integer types. Cargo ----------------------- - [Added the `[build.rustc-workspace-wrapper]` option.][cargo/8976] This option sets a wrapper to execute instead of `rustc`, for workspace members only. - [`cargo:rerun-if-changed` will now, if provided a directory, scan the entire contents of that directory for changes.][cargo/8973] - [Added the `--workspace` flag to the `cargo update` command.][cargo/8725] Misc ---- - [The search results tab and the help button are focusable with keyboard in rustdoc.][79896] - [Running tests will now print the total time taken to execute.][75752] Compatibility Notes ------------------- - [The `compare_and_swap` method on atomics has been deprecated.][79261] It's recommended to use the `compare_exchange` and `compare_exchange_weak` methods instead. - [Changes in how `TokenStream`s are checked have fixed some cases where you could write unhygenic `macro_rules!` macros.][79472] - [`#![test]` as an inner attribute is now considered unstable like other inner macro attributes, and reports an error by default through the `soft_unstable` lint.][79003] - [Overriding a `forbid` lint at the same level that it was set is now a hard error.][78864] - [Dropped support for all cloudabi targets.][78439] - [You can no longer intercept `panic!` calls by supplying your own macro.][78343] It's recommended to use the `#[panic_handler]` attribute to provide your own implementation. - [Semi-colons after item statements (e.g. `struct Foo {};`) now produce a warning.][78296] [74989]: rust-lang/rust#74989 [79261]: rust-lang/rust#79261 [79896]: rust-lang/rust#79896 [79484]: rust-lang/rust#79484 [79472]: rust-lang/rust#79472 [79270]: rust-lang/rust#79270 [79003]: rust-lang/rust#79003 [78864]: rust-lang/rust#78864 [78636]: rust-lang/rust#78636 [78439]: rust-lang/rust#78439 [78343]: rust-lang/rust#78343 [78296]: rust-lang/rust#78296 [78068]: rust-lang/rust#78068 [75752]: rust-lang/rust#75752 [74699]: rust-lang/rust#74699 [78142]: rust-lang/rust#78142 [77484]: rust-lang/rust#77484 [cargo/8976]: rust-lang/cargo#8976 [cargo/8973]: rust-lang/cargo#8973 [cargo/8725]: rust-lang/cargo#8725 [`IpAddr::is_ipv4`]: https://doc.rust-lang.org/stable/std/net/enum.IpAddr.html#method.is_ipv4 [`IpAddr::is_ipv6`]: https://doc.rust-lang.org/stable/std/net/enum.IpAddr.html#method.is_ipv6 [`Layout::align`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.align [`Layout::from_size_align`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.from_size_align [`Layout::size`]: https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.size [`Ord::clamp`]: https://doc.rust-lang.org/stable/std/cmp/trait.Ord.html#method.clamp [`RefCell::take`]: https://doc.rust-lang.org/stable/std/cell/struct.RefCell.html#method.take [`UnsafeCell::get_mut`]: https://doc.rust-lang.org/stable/std/cell/struct.UnsafeCell.html#method.get_mut [`bool::then`]: https://doc.rust-lang.org/stable/std/primitive.bool.html#method.then [`btree_map::Entry::or_insert_with_key`]: https://doc.rust-lang.org/stable/std/collections/btree_map/enum.Entry.html#method.or_insert_with_key [`f32::clamp`]: https://doc.rust-lang.org/stable/std/primitive.f32.html#method.clamp [`f64::clamp`]: https://doc.rust-lang.org/stable/std/primitive.f64.html#method.clamp [`hash_map::Entry::or_insert_with_key`]: https://doc.rust-lang.org/stable/std/collections/hash_map/enum.Entry.html#method.or_insert_with_key [`slice::fill`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.fill

rust-highfive assigned estebank Nov 12, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2020

petrochenkov added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 13, 2020

jonas-schievink mentioned this pull request Nov 14, 2020

Rollup of 26 pull requests #79053

Closed

jonas-schievink mentioned this pull request Nov 14, 2020

Rollup of 25 pull requests #79056

Closed

jonas-schievink mentioned this pull request Nov 14, 2020

Rollup of 24 pull requests #79057

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2020

petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 15, 2020

This comment has been minimized.

Sign in to view

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Nov 20, 2020

rustc_expand: Mark inner #![test] attributes as soft-unstable

993bb07

petrochenkov force-pushed the innertest branch from cc6baf7 to 993bb07 Compare November 20, 2020 16:35

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2020

Dylan-DPC-zz mentioned this pull request Nov 21, 2020

Rollup of 9 pull requests #79252

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2020

bors merged commit 502c477 into rust-lang:master Nov 21, 2020

rustbot added this to the 1.50.0 milestone Nov 21, 2020

Havvy added a commit to Havvy/reference that referenced this pull request Nov 21, 2020

Use doc, not test for fn item inner attr example

7488558

Using `test` causes a deny-by-default lint to trigger. See rust-lang/rust#79003 for more information.

Havvy mentioned this pull request Nov 21, 2020

Use doc, not test for fn item inner attr example rust-lang/reference#906

Merged

bors mentioned this pull request Nov 21, 2020

expand/resolve: Turn #[derive] into a regular macro attribute #79078

Merged

petrochenkov mentioned this pull request Mar 17, 2021

Tracking issue for future-incompatibility lint soft_unstable #64266

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustc_expand: Mark inner `#![test]` attributes as soft-unstable #79003

rustc_expand: Mark inner `#![test]` attributes as soft-unstable #79003

petrochenkov commented Nov 12, 2020

rust-highfive commented Nov 12, 2020

estebank commented Nov 13, 2020

bors commented Nov 13, 2020

ehuss commented Nov 15, 2020 •

edited

Loading

petrochenkov commented Nov 15, 2020

This comment has been minimized.

petrochenkov commented Nov 20, 2020

bors commented Nov 20, 2020

bors commented Nov 20, 2020

bors commented Nov 20, 2020

Aaron1011 commented Nov 20, 2020

bors commented Nov 21, 2020

bors commented Nov 21, 2020

rust-highfive commented Nov 21, 2020

rustc_expand: Mark inner #![test] attributes as soft-unstable #79003

rustc_expand: Mark inner #![test] attributes as soft-unstable #79003

Conversation

petrochenkov commented Nov 12, 2020

rust-highfive commented Nov 12, 2020

estebank commented Nov 13, 2020

bors commented Nov 13, 2020

ehuss commented Nov 15, 2020 • edited Loading

petrochenkov commented Nov 15, 2020

This comment has been minimized.

petrochenkov commented Nov 20, 2020

bors commented Nov 20, 2020

bors commented Nov 20, 2020

bors commented Nov 20, 2020

Aaron1011 commented Nov 20, 2020

bors commented Nov 21, 2020

bors commented Nov 21, 2020

rust-highfive commented Nov 21, 2020

rustc_expand: Mark inner `#![test]` attributes as soft-unstable #79003

rustc_expand: Mark inner `#![test]` attributes as soft-unstable #79003

ehuss commented Nov 15, 2020 •

edited

Loading