Resolve typedefs in HashMap gdb/lldb pretty-printers #79234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GetTypedefedType` (LLDB) and `strip_typedefs` (GDB) calls are needed to resolve key and value types completely.
Without these calls, debugger doesn't show the actual type.
* Before (without `GetTypedefedType`):
(lldb) frame variable hm[0]
(T) hm[0] = { ... }
* After (with `GetTypedefedType`):
(lldb) frame variable hm[0]
((i32, alloc::string::String)) hm[0] = { ... }
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
9 tasks
|
@bors r+ |
|
📌 Commit 905ed3b has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 905ed3b with merge d3dc894c5689aae905c4675d7a1a5f32f4b145fa... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry - apple timed out |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2020
…as-schievink Rollup of 10 pull requests Successful merges: - rust-lang#78086 (Improve doc for 'as _') - rust-lang#78853 (rustc_parse: fix ConstBlock expr span) - rust-lang#79234 (Resolve typedefs in HashMap gdb/lldb pretty-printers) - rust-lang#79344 (Convert UNC path to local path to satisfy install script on Windows) - rust-lang#79383 (Fix bold code formatting in keyword docs) - rust-lang#79460 (Remove intermediate vectors from `add_bounds`) - rust-lang#79474 (Change comments on types to doc-comments) - rust-lang#79476 (Sync rustc_codegen_cranelift) - rust-lang#79478 (Expand docs on Peekable::peek_mut) - rust-lang#79486 (Slightly improve code samples in E0591) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetTypedefedType(LLDB) andstrip_typedefs(GDB) calls are needed to resolve key and value types completely.Without these calls, debugger doesn't show the actual type.
Before (without
GetTypedefedType):After (with
GetTypedefedType):Based on intellij-rust/intellij-rust#6258