Convert UNC path to local path to satisfy install script on Windows #79344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
JRF63
changed the title
JRF63
force-pushed
the
fix_install_script_win
branch
from
1cdeba0 to
6b47920
Compare
|
@bors r+ I'm not sure this is quite the right fix, but I think it's not wrong. In theory we should investigate these shell scripts more -- it seems like there should be a way to fix them to support these paths. |
|
📌 Commit 6b47920 has been approved by |
bors
added
S-waiting-on-bors
|
Manually creating each parent directory instead of using This doesn't seem hard to fix on mkdir itself but I found mention of this bug dated 10 years ago. I think I'll try to track it down and do PR at least on MSYS2 so we can revert this (if this gets merged). |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 28, 2020
…as-schievink Rollup of 10 pull requests Successful merges: - rust-lang#78086 (Improve doc for 'as _') - rust-lang#78853 (rustc_parse: fix ConstBlock expr span) - rust-lang#79234 (Resolve typedefs in HashMap gdb/lldb pretty-printers) - rust-lang#79344 (Convert UNC path to local path to satisfy install script on Windows) - rust-lang#79383 (Fix bold code formatting in keyword docs) - rust-lang#79460 (Remove intermediate vectors from `add_bounds`) - rust-lang#79474 (Change comments on types to doc-comments) - rust-lang#79476 (Sync rustc_codegen_cranelift) - rust-lang#79478 (Expand docs on Peekable::peek_mut) - rust-lang#79486 (Slightly improve code samples in E0591) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mkdirwith the-pflag attempts to create//?if passed a UNC path. This fails on both MSYS2 and Git Bash.The UNC paths come from canonicalizing the install prefix path.
mkdir -pgets invoked on the install script.