Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for #[doc(keyword = "...")] attribute #79613

Merged
merged 5 commits into from
Dec 3, 2020
Merged

Add checks for #[doc(keyword = "...")] attribute #79613

merged 5 commits into from
Dec 3, 2020

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Dec 1, 2020 •
edited
Loading

The goal here is to extend check for #[doc(keyword = "...")].

cc @jyn514
r? @oli-obk

@rust-highfive
Copy link
Contributor

Updates src/tools/cargo.

cc @ehuss

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2020
@GuillaumeGomez
Copy link
Member Author

Removed the (invalid and unwanted) submodule update.

@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 2, 2020
@GuillaumeGomez GuillaumeGomez force-pushed the doc-keyword-checks branch 2 times, most recently from 224c732 to 15f9453 Compare December 2, 2020 23:44
@GuillaumeGomez
Copy link
Member Author

This should be ready for review now. :)

@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 3, 2020
Merged
@oli-obk
Copy link
Contributor

oli-obk commented Dec 3, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 3, 2020

📌 Commit 15f9453 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2020
@bors
Copy link
Collaborator

bors commented Dec 3, 2020

⌛ Testing commit 15f9453 with merge 1f95c91...

@bors
Copy link
Collaborator

bors commented Dec 3, 2020

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 1f95c91 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 3, 2020
@bors bors merged commit 1f95c91 into rust-lang:master Dec 3, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 3, 2020
@GuillaumeGomez GuillaumeGomez deleted the doc-keyword-checks branch December 3, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-highfive @oli-obk @bors @jyn514 @rustbot