Fix a crash when transmuting non-immediate to immediate types #7991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Removed my r+ pending adding the test from #7988.) |
The code to build the transmute intrinsic currently makes the invalid assumption that if the in-type is non-immediate, the out-type is non-immediate as well. But this is wrong, for example when transmuting [int, ..1] to int. So we need to handle this fourth case as well. Fixes rust-lang#7988
|
Landing as part of #7982. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 17, 2021
Fix bad suggestion on `option_if_let_else` when there is complex subpat closes rust-lang#7991 Prefer not warning any complex subpat in `option_if_let_else` rather than suggesting obscure suggestions. changelog: [`option_if_let_else`] does not warn when complex subpat is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to build the transmute intrinsic currently makes the invalid
assumption that if the in-type is non-immediate, the out-type is
non-immediate as well. But this is wrong, for example when transmuting
[int, ..1] to int. So we need to handle this fourth case as well.
Fixes #7988