-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollup of small-medium size pulls #7982
Conversation
I can see the need for something like this, but I'm a bit confused on the actual wording. It's called Also, cc #7766 |
@alexcrichton: The Random access iterators will allow generic algorithms (like sort or binary search) to work on any random access iterator, not just containers. For example you'll be able to chain together 2 vectors and a deque and sort them as a single range of values. |
There is a bikeshed: iterator vs range, right? Although random access iterators are not really iterators IHMO, C++ has been called them iterators for a long time... (I don't think Rust must use C++ term instead of dlang term. It's just an example.) |
@omasanori: it's not really the C++ term, languages like Python use the term iterator for what D calls an |
@thestinger yes, you are right. |
Fixed version of my PR that failed to test on windows: https://github.com/dotdash/rust/commits/transmute_ice |
The code to build the transmute intrinsic currently makes the invalid assumption that if the in-type is non-immediate, the out-type is non-immediate as well. But this is wrong, for example when transmuting [int, ..1] to int. So we need to handle this fourth case as well. Fixes #7988
Simplify Rc<T>/RcMut<T> by using ~T when allocating a reference counted box.
f0f4dcc r=huonw 25e9c4c r=graydon a87c2d1 r=brson 16f369d r=cmr 9f05cc8 r=bstrie e858055 r=huonw 5d80938 r=thestinger 05d03e7 r=cmr 8f86fa3 r=thestinger
Fix `needless_collect`'s tendency to suggest code requiring multiple mutable borrows of the same value. Fixes error specified in rust-lang#7975. changelog: [`needless_collect`] no longer suggests removal of `collect` when removal would create code requiring mutably borrowing a value multiple times.
f0f4dcc r=huonw
25e9c4c r=graydon
a87c2d1 r=brson
16f369d r=cmr
9f05cc8 r=bstrie
e858055 r=huonw
5d80938 r=thestinger
05d03e7 r=cmr
8f86fa3 r=thestinger