Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToStr for HashMap does not need value to implement Eq or Hash #7998

Closed
wants to merge 1 commit into from
Closed

ToStr for HashMap does not need value to implement Eq or Hash #7998

wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

No description provided.

@stepancheg
Copy link
Contributor Author

Renamed StructWithStrWithoutEqOrHash -> StructWithToStrWithoutEqOrHash.

When I did git push -f, github dropped comments.

@cmr asked whether ToStr implementation for HashMap needs Eq and Hash for key. I replied that Eq and Hash are currently used in implementation of HashMap::iter().

@thestinger
Copy link
Contributor

Landing as part of #7982.

@thestinger thestinger closed this Jul 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stepancheg @thestinger @emberian