Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings in preparation for #70951 #80452

Closed
wants to merge 27 commits into from
Closed

Refactorings in preparation for #70951 #80452

wants to merge 27 commits into from

Conversation

cjgillot
Copy link
Contributor

Split out of #70951 to investigate perf.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2020
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@oli-obk
Copy link
Contributor

oli-obk commented Dec 28, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Dec 28, 2020

⌛ Trying commit 18680f79638ca301cfd519e9fc95ded7f74288a1 with merge d60872e6f17fb2b7d675e0e4556cf62116d6fa96...

@bors
Copy link
Contributor

bors commented Dec 28, 2020

☀️ Try build successful - checks-actions
Build commit: d60872e6f17fb2b7d675e0e4556cf62116d6fa96 (d60872e6f17fb2b7d675e0e4556cf62116d6fa96)

@rust-timer
Copy link
Collaborator

Queued d60872e6f17fb2b7d675e0e4556cf62116d6fa96 with parent 2987785, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 28, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (d60872e6f17fb2b7d675e0e4556cf62116d6fa96): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 29, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Dec 29, 2020

Ok, so at least we know it's not related to moving it across crates, but just due to the dynamic dispatch (or most likely, due to the lack of inlining)

@cjgillot cjgillot force-pushed the anarchy-nomv branch 2 times, most recently from 28f255e to 37065a1 Compare January 4, 2021 23:28
@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 4, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 4, 2021

⌛ Trying commit 37065a1020ad6ba1b7d41dca496e351be0b0730d with merge de2a8b56260fa483d30f8c31c85624a493e62b04...

@bors
Copy link
Contributor

bors commented Jan 5, 2021

☀️ Try build successful - checks-actions
Build commit: de2a8b56260fa483d30f8c31c85624a493e62b04 (de2a8b56260fa483d30f8c31c85624a493e62b04)

@rust-timer
Copy link
Collaborator

Queued de2a8b56260fa483d30f8c31c85624a493e62b04 with parent 61f5a00, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 5, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (de2a8b56260fa483d30f8c31c85624a493e62b04): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 5, 2021
@bjorn3
Copy link
Member

bjorn3 commented Jan 5, 2021

Big regressions of up to 7%.

@cjgillot
Copy link
Contributor Author

cjgillot commented Jan 6, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 6, 2021

⌛ Trying commit fed215e43224e73c5fabb2562d8537076c7ab458 with merge 5b9b411f66cbd861eb57e9cc971f3f941acb7151...

@bors
Copy link
Contributor

bors commented Jan 6, 2021

☀️ Try build successful - checks-actions
Build commit: 5b9b411f66cbd861eb57e9cc971f3f941acb7151 (5b9b411f66cbd861eb57e9cc971f3f941acb7151)

@cjgillot
Decouple the on-disk cache from the query engine.
152266c
@cjgillot
Wrap TyCtxt inside a QueryCtxt for queries.
c783ecb
@cjgillot
Opacify query invocation.
469f24b
@cjgillot
Make QueryEngine opaque to TyCtxt.
8071c0a
@cjgillot
Make alloc_self_profile_query_strings a standalone function.
edf9687
@cjgillot
Move try_print_query_stack to rustc_interface.
adbba4b
@cjgillot
Move try_load_from_on_disk_cache to the QueryContext.
bc4ba06
@cjgillot
Move handle_deadlock where it is used.
f6d5aae
@cjgillot
Move definition of callbacks to parent module.
89d7a95
@cjgillot
Select caching strategy per query.
fd41767 
The per-Key choice was not used.
@cjgillot
Use a QueryContext for try_mark_green.
79be9be
@cjgillot
Use QueryCtxt in DepKindStruct.
c425641
@cjgillot
Split DepKindStruct in two.
fbb37a6
@cjgillot
Wrap QueryDescription into a macro.
7422391
@cjgillot
Move query names and Providers to parent module.
d15633b
@cjgillot
Make encode_query_results more generic.
b0927af
@Dylan-DPC-zz Dylan-DPC-zz added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 14, 2021
@cjgillot
Copy link
Contributor Author

Now that #81855 has been merged, and its perf has been validated:
@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 18, 2021
@bors
Copy link
Contributor

bors commented Feb 18, 2021

⌛ Trying commit b0927af with merge cfcfe8cab11f3081dc476759aec8d9e794b4afd7...

@bors
Copy link
Contributor

bors commented Feb 18, 2021

☀️ Try build successful - checks-actions
Build commit: cfcfe8cab11f3081dc476759aec8d9e794b4afd7 (cfcfe8cab11f3081dc476759aec8d9e794b4afd7)

@rust-timer
Copy link
Collaborator

Queued cfcfe8cab11f3081dc476759aec8d9e794b4afd7 with parent d1462d8, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (cfcfe8cab11f3081dc476759aec8d9e794b4afd7): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 18, 2021
@cjgillot cjgillot closed this Feb 20, 2021
@cjgillot cjgillot deleted the anarchy-nomv branch February 20, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjgillot @rust-log-analyzer @oli-obk @rust-timer @bors @bjorn3 @JohnCSimon @Dylan-DPC-zz @rust-highfive @rustbot