Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings in preparation for #70951 #80452

Closed
wants to merge 27 commits into from
Closed

Refactorings in preparation for #70951 #80452

wants to merge 27 commits into from

Commits on Feb 13, 2021

  1. Merge {get,ensure}_query.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    8684e9e View commit details
    Browse the repository at this point in the history

  2. Introduce query_stored module.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    4b42a6d View commit details
    Browse the repository at this point in the history

  3. Introduce query_storage.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    f8ab649 View commit details
    Browse the repository at this point in the history

  4. Return a Result for query cache.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    9f46259 View commit details
    Browse the repository at this point in the history

  5. Separate the query cache from the query state.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    15b0bc6 View commit details
    Browse the repository at this point in the history

  6. Drop the cache lock earlier.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    280a286 View commit details
    Browse the repository at this point in the history

  7. Check query cache before calling into the query engine.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    3fc8ed6 View commit details
    Browse the repository at this point in the history

  8. Group logic about the Providers struct.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    7495732 View commit details
    Browse the repository at this point in the history

  9. Don't require a QueryContext to access the DepGraph.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    6305835 View commit details
    Browse the repository at this point in the history

  10. Remove QueryAccessors::to_dep_node.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    fa4d3be View commit details
    Browse the repository at this point in the history

  11. Decouple QueryContext from DepContext.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    59b96b4 View commit details
    Browse the repository at this point in the history

  12. Decouple the on-disk cache from the query engine.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    152266c View commit details
    Browse the repository at this point in the history

  13. Wrap TyCtxt inside a QueryCtxt for queries.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    c783ecb View commit details
    Browse the repository at this point in the history

  14. Opacify query invocation.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    469f24b View commit details
    Browse the repository at this point in the history

  15. Make QueryEngine opaque to TyCtxt.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    8071c0a View commit details
    Browse the repository at this point in the history

  16. Make alloc_self_profile_query_strings a standalone function.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    edf9687 View commit details
    Browse the repository at this point in the history

  17. Move try_print_query_stack to rustc_interface.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    adbba4b View commit details
    Browse the repository at this point in the history

  18. Move try_load_from_on_disk_cache to the QueryContext.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    bc4ba06 View commit details
    Browse the repository at this point in the history

  19. Move handle_deadlock where it is used.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    f6d5aae View commit details
    Browse the repository at this point in the history

  20. Move definition of callbacks to parent module.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    89d7a95 View commit details
    Browse the repository at this point in the history

  21. Select caching strategy per query. 

    The per-Key choice was not used.
    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    fd41767 View commit details
    Browse the repository at this point in the history

  22. Use a QueryContext for try_mark_green.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    79be9be View commit details
    Browse the repository at this point in the history

  23. Use QueryCtxt in DepKindStruct.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    c425641 View commit details
    Browse the repository at this point in the history

  24. Split DepKindStruct in two.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    fbb37a6 View commit details
    Browse the repository at this point in the history

  25. Wrap QueryDescription into a macro.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    7422391 View commit details
    Browse the repository at this point in the history

  26. Move query names and Providers to parent module.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    d15633b View commit details
    Browse the repository at this point in the history

  27. Make encode_query_results more generic.

    @cjgillot
    cjgillot committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    b0927af View commit details
    Browse the repository at this point in the history