Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NO_BENCH variable to makefiles for turning off --bench #8111

Closed
wants to merge 2 commits into from

Conversation

brson
Copy link
Contributor

@brson brson commented Jul 29, 2013

No description provided.

brson added 2 commits July 29, 2013 12:38
bors added a commit that referenced this pull request Jul 31, 2013
@bors bors closed this Jul 31, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 2, 2024
…nly, r=xFrednet

reduce `single_char_pattern` to only lint on ascii chars

This should mostly fix the `single_char_pattern` lint, because with a single byte, the optimizer will usually see through the char-to-string-expansion and single loop iteration. This fixes rust-lang#11675 and rust-lang#8111.

Update: As per the meeting on November 28th, 2023, we voted to also downgrade the lint to pedantic.

---

changelog: downgrade [`single_char_pattern`] to `pedantic`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants