Remove usages of expr_method_call in derive(Ord,PartialOrd,RustcEncode,RustcDecode)

[Skgland]

Preparing for deprecation of expr_method_call (#81295), by removing the remaining usages not covered by (#81294).

I am not sure about the changes to derive(RustcEncode,RustcDecode)

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[tmiasko]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit df49341e7bdd092ea25e7ba5efbc0d56674b4680 with merge 1efaba40d3490e0210d6db6d5a7deb774e6f5cbf...

[bors]

☀️ Try build successful - checks-actions
Build commit: 1efaba40d3490e0210d6db6d5a7deb774e6f5cbf (1efaba40d3490e0210d6db6d5a7deb774e6f5cbf)

[rust-timer]

Queued 1efaba40d3490e0210d6db6d5a7deb774e6f5cbf with parent e708cbd, future comparison URL.

[rust-timer]

Finished benchmarking try commit (1efaba40d3490e0210d6db6d5a7deb774e6f5cbf): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[tmiasko]

Some of benchmarks fail to build with those changes:

error[E0599]: no function or associated item named `emit_struct` found for trait object `dyn Encodable` in the current scope
  --> /.../.cargo/registry/src/github.com-1ecc6299db9ec823/num-bigint-0.1.40/src/biguint.rs:43:48
   |
43 | #[cfg_attr(feature = "rustc-serialize", derive(RustcEncodable, RustcDecodable))]
   |                                                ^^^^^^^^^^^^^^ function or associated item not found in `dyn Encodable`
   |
   = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)

[Skgland]

oh, I mixed up the Encodable and Encoder traits in derive(RustcEncodable) in all places where Encoder should have been used. Respectively for RustcDecodable.

[Skgland]

The latest commit should have fixed that now.

[Skgland]

@rustbot label: -S-waiting-on-review +S-waiting-on-author

[Skgland]

@rustbot label: +S-waiting-on-review -S-waiting-on-author

[varkor]

I'm sorry for taking so long to get to this; the last couple of weeks have been very busy. This looks good to me, though I think we should check performance again now that the issue has been fixed.

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 49bd2c39c7499cea0c59102e9fc21739a188c899 with merge 0b541463d2675ae48c07dcd35b4a5a837d494786...

[bors]

☀️ Try build successful - checks-actions
Build commit: 0b541463d2675ae48c07dcd35b4a5a837d494786 (0b541463d2675ae48c07dcd35b4a5a837d494786)

[rust-timer]

Queued 0b541463d2675ae48c07dcd35b4a5a837d494786 with parent f9435f4, future comparison URL.

[rust-timer]

Finished benchmarking try commit (0b541463d2675ae48c07dcd35b4a5a837d494786): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

[varkor]

Thanks!

@bors r+

[bors]

📌 Commit 49bd2c39c7499cea0c59102e9fc21739a188c899 has been approved by varkor

[bors]

⌛ Testing commit 49bd2c39c7499cea0c59102e9fc21739a188c899 with merge 9593d79927740b22ecd14c10a73b0694ae9a0b27...

[bors]

💔 Test failed - checks-actions

[bors]

☔ The latest upstream changes (presumably #81384) made this pull request unmergeable. Please resolve the merge conflicts.

[Skgland]

Rebased to fix merge conflicts and ready for review again

[varkor]

Thanks; sorry, I didn't notice the conflict earlier was spurious.

@bors r+

[bors]

📌 Commit 0375022 has been approved by varkor

[bors]

⌛ Testing commit 0375022 with merge ca98712...

[bors]

☀️ Test successful - checks-actions
Approved by: varkor
Pushing ca98712 to master...