Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about formatting Duration values #81465

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Add documentation about formatting Duration values #81465

merged 1 commit into from
Mar 14, 2021

Conversation

joshtriplett
Copy link
Member

Explain why Duration has a Debug impl but not a Display impl, and
mention the use of Unicode.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joshtriplett joshtriplett force-pushed the duration-formatting-documentation branch from baa3f1f to 9004d72 Compare January 28, 2021 09:28
@joshtriplett
Copy link
Member Author

Test failure fixed.

pickfire
pickfire reviewed Jan 30, 2021
View reviewed changes
library/core/src/time.rs Outdated Show resolved Hide resolved
@joshtriplett joshtriplett force-pushed the duration-formatting-documentation branch from 9004d72 to 16467d7 Compare February 2, 2021 21:12
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@crlf0710 crlf0710 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2021
@Dylan-DPC-zz
Copy link

looks fine to me, but let's get a t-libs check

r? @m-ou-se

@rust-highfive rust-highfive assigned m-ou-se and unassigned sfackler Mar 13, 2021
m-ou-se
m-ou-se reviewed Mar 13, 2021
View reviewed changes
Copy link
Member

@m-ou-se m-ou-se left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit, but otherwise r=me:

m-ou-se
m-ou-se reviewed Mar 13, 2021
View reviewed changes
library/core/src/time.rs Outdated Show resolved Hide resolved
@joshtriplett
Add documentation about formatting Duration values
8fd2f0c 
Explain why Duration has a Debug impl but not a Display impl, and
mention the use of Unicode.
@joshtriplett joshtriplett force-pushed the duration-formatting-documentation branch from 16467d7 to 8fd2f0c Compare March 13, 2021 21:06
@joshtriplett
Copy link
Member Author

@bors r=@m-ou-se

@bors
Copy link
Contributor

bors commented Mar 13, 2021

📌 Commit 8fd2f0c has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 13, 2021
@JohnTitor JohnTitor mentioned this pull request Mar 14, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 14, 2021
@bors
Auto merge of rust-lang#83105 - JohnTitor:rollup-tqpm8pb, r=JohnTitor
1381dcf 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#81465 (Add documentation about formatting `Duration` values)
 - rust-lang#82121 (Implement Extend and FromIterator for OsString)
 - rust-lang#82617 (Document `everybody_loops`)
 - rust-lang#82789 (Get with field index from pattern slice instead of directly indexing)
 - rust-lang#82798 (Rename `rustdoc` to `rustdoc::all`)
 - rust-lang#82804 (std: Fix a bug on the wasm32-wasi target opening files)
 - rust-lang#82943 (Demonstrate best practice for feeding stdin of a child processes)
 - rust-lang#83066 (Add `reverse` search alias for Iterator::rev())
 - rust-lang#83070 (Update cargo)
 - rust-lang#83081 (Fix panic message of `assert_failed_inner`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6caa350 into rust-lang:master Mar 14, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 14, 2021
@joshtriplett joshtriplett deleted the duration-formatting-documentation branch March 28, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire left review comments

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.