Add documentation about formatting Duration values
#81465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
duration-formatting-documentation
branch
from
baa3f1f to
9004d72
Compare
|
Test failure fixed. |
pickfire
reviewed
Jan 30, 2021
pickfire
reviewed
Jan 30, 2021
joshtriplett
force-pushed
the
duration-formatting-documentation
branch
from
9004d72 to
16467d7
Compare
JohnCSimon
added
S-waiting-on-review
crlf0710
added
T-libs-api
|
looks fine to me, but let's get a t-libs check r? @m-ou-se |
m-ou-se
reviewed
Mar 13, 2021
m-ou-se
reviewed
Mar 13, 2021
Explain why Duration has a Debug impl but not a Display impl, and mention the use of Unicode.
joshtriplett
force-pushed
the
duration-formatting-documentation
branch
from
16467d7 to
8fd2f0c
Compare
|
📌 Commit 8fd2f0c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 14, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#81465 (Add documentation about formatting `Duration` values) - rust-lang#82121 (Implement Extend and FromIterator for OsString) - rust-lang#82617 (Document `everybody_loops`) - rust-lang#82789 (Get with field index from pattern slice instead of directly indexing) - rust-lang#82798 (Rename `rustdoc` to `rustdoc::all`) - rust-lang#82804 (std: Fix a bug on the wasm32-wasi target opening files) - rust-lang#82943 (Demonstrate best practice for feeding stdin of a child processes) - rust-lang#83066 (Add `reverse` search alias for Iterator::rev()) - rust-lang#83070 (Update cargo) - rust-lang#83081 (Fix panic message of `assert_failed_inner`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain why Duration has a Debug impl but not a Display impl, and
mention the use of Unicode.