Add reverse search alias for Iterator::rev()
#83066
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| #[doc(alias = "reverse")] | ||
| #[inline] | ||
| #[stable(feature = "rust1", since = "1.0.0")] |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I haven't seen anything indicating length-sorting in any of the contribution documentation, and I also haven't seen examples of that in the compiler source. From what I can tell, order is generally (in order of importance):
- Semantically significant ordering (if one attribute affects another)
- Grouping related attributes (e.g. multiple stability-related attributes)
- More-or-less alphabetical.
This ordering seems consistent with that, to me.
Is there some policy I'm unaware of?
There was a problem hiding this comment.
@joshtriplett I don't think there is a policy, you would know better than me if there was :) I just thought it looked better and more consistent that way.
There was a problem hiding this comment.
I just looked one or two examples elsewhere and just did that but I can also change it to that I guess :)
|
r=me, after the formatting discussion is resolved one way or the other. |
|
This should be fine now? @ibraheemdev |
|
@bors r=joshtriplett |
|
@Seppel3210: 🔑 Insufficient privileges: Not in reviewers |
|
😔 |
|
@joshtriplett , @ibraheemdev could one of you approve that then 🙂 |
|
I don't have sufficient privileges either. |
|
@bors r+ rollup |
|
📌 Commit f201746 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 10 pull requests Successful merges: - rust-lang#81465 (Add documentation about formatting `Duration` values) - rust-lang#82121 (Implement Extend and FromIterator for OsString) - rust-lang#82617 (Document `everybody_loops`) - rust-lang#82789 (Get with field index from pattern slice instead of directly indexing) - rust-lang#82798 (Rename `rustdoc` to `rustdoc::all`) - rust-lang#82804 (std: Fix a bug on the wasm32-wasi target opening files) - rust-lang#82943 (Demonstrate best practice for feeding stdin of a child processes) - rust-lang#83066 (Add `reverse` search alias for Iterator::rev()) - rust-lang#83070 (Update cargo) - rust-lang#83081 (Fix panic message of `assert_failed_inner`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
When searching for "reverse" in rustdoc you can't find the rev method on Iterator so here is a search alias for that.