Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #82263

Merged
merged 30 commits into from
Feb 18, 2021
Merged

Rollup of 10 pull requests #82263

merged 30 commits into from
Feb 18, 2021

Commits on Feb 13, 2021

  1. Configuration menu
    Copy the full SHA
    dfa581f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9bbd3e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0bf1d73 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9526c0c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    79f6f11 View commit details
    Browse the repository at this point in the history
  6. Make ProjectionTy::trait_ref truncate substs again

    Also make sure that type arguments of associated types are printed in
    some error messages.
    matthewjasper committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    dfee89f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d785c8c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    eeb82e4 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. the environment round here is awfully empty

    capitalism
    BoxyUwU committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    7e368e5 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Configuration menu
    Copy the full SHA
    0f04875 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43aed74 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2a66685 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    32c97da View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ec50a20 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2021

  1. Configuration menu
    Copy the full SHA
    5ae392f View commit details
    Browse the repository at this point in the history
  2. Update compiler/rustc_error_codes/src/error_codes/E0549.md

    Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
    jesusprubio and GuillaumeGomez authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    5112cf0 View commit details
    Browse the repository at this point in the history
  3. Update compiler/rustc_error_codes/src/error_codes/E0549.md

    Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
    jesusprubio and GuillaumeGomez authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    0e01c41 View commit details
    Browse the repository at this point in the history
  4. Update compiler/rustc_error_codes/src/error_codes/E0549.md

    Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
    jesusprubio and GuillaumeGomez authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    3c4fe1e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6165d1c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8a5c568 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#81546 - hyd-dev:libtest-run-out-of-threads,…

    … r=Mark-Simulacrum
    
    [libtest] Run the test synchronously when hitting thread limit
    
    libtest currently panics if it hits the thread limit. This often results in spurious test failures (<code>thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }'</code> ... `error: test failed, to rerun pass '--lib'`). This PR makes it continue to run the test synchronously if it runs out of threads.
    
    Closes rust-lang#78165.
    
    ``@rustbot`` label: A-libtest T-libs
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    55ab2e3 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#82066 - matthewjasper:trait-ref-fix, r=jack…

    …h726
    
    Ensure valid TraitRefs are created for GATs
    
    This fixes `ProjectionTy::trait_ref` to use the correct substs. Places that need all of the substs have been updated to not use `trait_ref`.
    
    r? ````@jackh726````
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    66211f6 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#82112 - BoxyUwU:tumbleweed, r=varkor

    const_generics: Dont evaluate array length const when handling yet another error
    
    Same ICE as rust-lang#82009 except triggered by a different error.
    cc ``@lcnr``
    r? ``@varkor``
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    928819a View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#82194 - estebank:arbitrary-bounds-suggestio…

    …n, r=petrochenkov
    
    In some limited cases, suggest `where` bounds for non-type params
    
    Partially address rust-lang#81971.
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    f01b339 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#82215 - TaKO8Ki:replace-if-let-while-let, r…

    …=varkor
    
    Replace if-let and while-let with `if let` and `while let`
    
    This pull request replaces if-let and while-let with `if let` and `while let`.
    
    closes rust-lang#82205
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    b3d3251 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#82218 - rylev:copy-pdbs, r=Mark-Simulacrum

    Make sure pdbs are copied along with exe and dlls when bootstrapping
    
    This makes it easier to find the pdbs when wanting to debug the compiler on Windows.
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    01104b5 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#82236 - matthiaskrgr:useless_conv, r=jyn514

    avoid converting types into themselves (clippy::useless_conversion)
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    04df75a View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#82246 - jesusprubio:add-long-explanation-e0…

    …549, r=GuillaumeGomez
    
    Add long explanation for E0549
    
    Helps with rust-lang#61137
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    5ca94cd View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#82248 - nhwn:optimize-counting-digits, r=va…

    …rkor
    
    Optimize counting digits in line numbers during error reporting
    
    Replaces `.to_string().len()` with simple loop and integer division, which avoids an unnecessary allocation.
    
    Although I couldn't figure out how to directly profile `rustc`'s error reporting, I ran a microbenchmark on my machine (2.9 GHz Dual-Core Intel Core i5) on the two strategies for `0..100_000`, and the results seem promising:
    ```
    test to_string_len ... bench:  12,124,792 ns/iter (+/- 700,652)
    test while_loop    ... bench:      30,333 ns/iter (+/- 562)
    ```
    The x86_64 disassembly reduces integer division to a multiplication + shift, so I don't think there's any problems with using integer division.
    
    For more (micro)optimization, it would be nice if we could avoid the initial check to see if the line number is nonzero, but I don't think `self.get_max_line_num(span, children)` _guarantees_ a nonzero line number.
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    555db2d View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#82256 - eddyb:time-passes-stderr, r=varkor

    Print -Ztime-passes (and misc stats/logs) on stderr, not stdout.
    
    I've tried not to change anything that looked similar to `rustc --print`, where people might use automation, and/or any "bulk" prints, such as dumping an entire Graphviz (`dot`) graph on stdout.
    
    The reason I want `-Ztime-passes` to be on stderr like debug logging is I can get a complete (and correctly interleaved) view just by looking at stderr, which is merely a convenience when running `rustc`/Cargo directly, but even more important when it's nested in a build script, as Cargo will split the build script output into stdout (named `output`) and `stderr`.
    Dylan-DPC authored Feb 18, 2021
    Configuration menu
    Copy the full SHA
    efdcb43 View commit details
    Browse the repository at this point in the history