Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #82574

Closed
wants to merge 38 commits into from

Commits on Feb 13, 2021

  1. Configuration menu
    Copy the full SHA
    38e4233 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2021

  1. Configuration menu
    Copy the full SHA
    fece59b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17176cc View commit details
    Browse the repository at this point in the history
  3. Apply tidy check

    0yoyoyo committed Feb 21, 2021
    Configuration menu
    Copy the full SHA
    ce1a521 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. ⬆️ rust-analyzer

    lnicola committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    5f7d663 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    888811b View commit details
    Browse the repository at this point in the history
  3. Rename rustdoc lints to be a tool lint instead of built-in.

    - Rename `broken_intra_doc_links` to `rustdoc::broken_intra_doc_links`
    - Ensure that the old lint names still work and give deprecation errors
    - Register lints even when running doctests
    
      Otherwise, all `rustdoc::` lints would be ignored.
    
    - Register all existing lints as removed
    
      This unfortunately doesn't work with `register_renamed` because tool
      lints have not yet been registered when rustc is running. For similar
      reasons, `check_backwards_compat` doesn't work either. Call
      `register_removed` directly instead.
    
    - Fix fallout
    
      + Rustdoc lints for compiler/
      + Rustdoc lints for library/
    
    Note that this does *not* suggest `rustdoc::broken_intra_doc_links` for
    `rustdoc::intra_doc_link_resolution_failure`, since there was no time
    when the latter was valid.
    jyn514 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    8f4d435 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b13398 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    203bf4b View commit details
    Browse the repository at this point in the history
  6. Improve error messages

    - Use `register_renamed` when rustdoc is running so the lint will still
      be active and use a structured suggestion
    - Test the behavior for rustc, not just for rustdoc (because it differs)
    jyn514 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    152635b View commit details
    Browse the repository at this point in the history
  7. Address review comments

    - Move MISSING_CRATE_LEVEL_DOCS to rustdoc directly
    - Update documentation
    
    This also takes the opportunity to make the `no-crate-level-doc-lint`
    test more specific.
    jyn514 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    edd4274 View commit details
    Browse the repository at this point in the history
  8. Update comments

    Note that the FIXME was removed because this can't be fixed,
    `register_renamed` calls LintId::of and there's no LintId for rustdoc
    lints when rustc is running.
    jyn514 committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    588c8e1 View commit details
    Browse the repository at this point in the history
  9. Update test cases

    0yoyoyo committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    75d1e30 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    24c23f5 View commit details
    Browse the repository at this point in the history
  11. Add tests

    petrochenkov committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c02d210 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fc9d578 View commit details
    Browse the repository at this point in the history
  13. Add a size() function to WASI's MetadataExt.

    WASI's `filestat` type includes a size field, so expose it in
    `MetadataExt` via a `size()` function, similar to the corresponding Unix
    function.
    sunfishcode committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    e8dcc02 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Enable API documentation for std::os::wasi.

    This adds API documentation support for `std::os::wasi` modeled after
    how `std::os::unix` works, so that WASI can be documented [here] along
    with the other platforms.
    
    [here]: https://doc.rust-lang.org/stable/std/os/index.html
    
    Two changes of particular interest:
    
     - This changes the `AsRawFd` for `io::Stdin` for WASI to return
       `libc::STDIN_FILENO` instead of `sys::stdio::Stdin.as_raw_fd()` (and
       similar for `Stdout` and `Stderr`), which matches how the `unix`
       version works. `STDIN_FILENO` etc. may not always be explicitly
       reserved at the WASI level, but as long as we have Rust's `std` and
       `libc`, I think it's reasonable to guarantee that we'll always use
       `libc::STDIN_FILENO` for stdin.
    
     - This duplicates the `osstr2str` utility function, rather than
       trying to share it across all the configurations that need it.
    sunfishcode committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    132ec26 View commit details
    Browse the repository at this point in the history
  2. Skip emitting closure diagnostic when closure_kind_origins has no entry

    Fixes rust-lang#82438
    
    This map is not guarnateed to have an entry for a closure.
    Aaron1011 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    46db4ba View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Use Oxform comma

    Co-authored-by: Nathan Nguyen <43092380+nhwn@users.noreply.github.com>
    pickfire and nhwn authored Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e56364f View commit details
    Browse the repository at this point in the history
  2. Cast libc::STDIN_FILENO to RawFd.

    WASI's `RawFd` is a `u32`, while `libc` uses `c_int`.
    sunfishcode committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    9ce567e View commit details
    Browse the repository at this point in the history
  3. Use super:: to refer to WASI-specific names.

    This ensures that these names resolve to the right place even when
    building the WASI support on other platforms for generating the
    documentation.
    sunfishcode committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    0208fca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e66e263 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    94e75ac View commit details
    Browse the repository at this point in the history
  6. x.py fmt

    sunfishcode committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7d5242a View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Configuration menu
    Copy the full SHA
    67f1734 View commit details
    Browse the repository at this point in the history
  2. Add for example word to spotlight doc

    As suggested by GuillaumeGomez
    pickfire authored Feb 26, 2021
    Configuration menu
    Copy the full SHA
    27f7a2e View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. Rollup merge of rust-lang#80527 - jyn514:rustdoc-lints, r=GuillaumeGomez

    Make rustdoc lints a tool lint instead of built-in
    
    - Rename `broken_intra_doc_links` to `rustdoc::broken_intra_doc_links` (and similar for other rustdoc lints; I don't expect any others to be used frequently, though).
    - Ensure that the old lint names still work and give deprecation errors
    - Register lints even when running doctests
    - Move lint machinery into a separate file
    - Add `declare_rustdoc_lint!` macro
    
    Unblocks rust-lang#80300, rust-lang#79816, rust-lang#80965. Makes the strangeness in rust-lang#77364 more apparent to the end user (note that `missing_docs` is *not* moved to rustdoc in this PR).
    
    ## Current status
    
    This is waiting on FCP: rust-lang#80527 (comment)
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    572e3b5 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#81794 - lcnr:relaxed_adt_unsize-tracking-is…

    …sue, r=camelid
    
    update tracking issue for `relaxed_struct_unsize`
    
    forgot to do this before rust-lang#80726 got merged. The tracking issue is rust-lang#81793
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    18f2fcd View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#82057 - upsuper-forks:cstr, r=davidtwco,wes…

    …leywiser
    
    Replace const_cstr with cstr crate
    
    This PR replaces the `const_cstr` macro inside `rustc_data_structures` with `cstr` macro from [cstr](https://crates.io/crates/cstr) crate.
    
    The two macros basically serve the same purpose, which is to generate `&'static CStr` from a string literal. `cstr` is better because it validates the literal at compile time, while the existing `const_cstr` does it at runtime when `debug_assertions` is enabled. In addition, the value `cstr` generates can be used in constant context (which is seemingly not needed anywhere currently, though).
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    86898eb View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#82370 - 0yoyoyo:update-issue-81650-point-an…

    …onymous-lifetime, r=estebank
    
    Improve anonymous lifetime note to indicate the target span
    
    Improvement for  rust-lang#81650
    Cc rust-lang#81995
    
    Message after this improvement:
    (Improve note in the middle)
    
    ```
    error[E0311]: the parameter type `T` may not live long enough
      --> src/main.rs:25:11
       |
    24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) {
       |              -- help: consider adding an explicit lifetime bound...: `T: 'a +`
    25 |     scope.spawn(move |_| {
       |           ^^^^^
       |
    note: the parameter type `T` must be valid for the anonymous lifetime defined on the function body at 24:40...
      --> src/main.rs:24:40
       |
    24 | fn play_with<T: Animal + Send>(scope: &Scope, animal: T) {
       |                                        ^^^^^
    note: ...so that the type `[closure@src/main.rs:25:17: 27:6]` will meet its required lifetime bounds
      --> src/main.rs:25:11
       |
    25 |     scope.spawn(move |_| {
       |           ^^^^^
    ```
    
    r? `````@estebank`````
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    7c092b5 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#82394 - lnicola:rust-analyzer-2021-02-22, r…

    …=jonas-schievink
    
    ⬆️ rust-analyzer
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    647d421 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#82396 - pickfire:patch-5, r=GuillaumeGomez

    Add Future trait for doc_spotlight feature doc
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    c9dae65 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#82404 - nagisa:nagisa/hexagon-enums-llvm-co…

    …mps, r=petrochenkov
    
    Test hexagon-enum only when llvm target is present
    
    See rust-lang#82379 (comment)
    
    r? `````@petrochenkov`````
    
    `````@bors````` rollup
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    e59e918 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#82419 - petrochenkov:inertord, r=Aaron1011

    expand: Preserve order of inert attributes during expansion
    
    Fixes rust-lang#67839
    Fixes rust-lang#81871
    r? ````@Aaron1011````
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    05677f8 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#82420 - sunfishcode:wasi-docs, r=alexcrichton

    Enable API documentation for `std::os::wasi`.
    
    This adds API documentation support for `std::os::wasi` modeled after
    how `std::os::unix` works, so that WASI can be documented [here] along
    with the other platforms.
    
    [here]: https://doc.rust-lang.org/stable/std/os/index.html
    
    Two changes of particular interest:
    
     - This changes the `AsRawFd` for `io::Stdin` for WASI to return
       `libc::STDIN_FILENO` instead of `sys::stdio::Stdin.as_raw_fd()` (and
       similar for `Stdout` and `Stderr`), which matches how the `unix`
       version works. `STDIN_FILENO` etc. may not always be explicitly
       reserved at the WASI level, but as long as we have Rust's `std` and
       `libc`, I think it's reasonable to guarantee that we'll always use
       `libc::STDIN_FILENO` for stdin.
    
     - This duplicates the `osstr2str` utility function, rather than
       trying to share it across all the configurations that need it.
    
    r? ``@alexcrichton``
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    3b142cc View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#82421 - sunfishcode:wasi-metadata-size, r=a…

    …lexcrichton
    
    Add a `size()` function to WASI's `MetadataExt`.
    
    WASI's `filestat` type includes a size field, so expose it in
    `MetadataExt` via a `size()` function, similar to the corresponding Unix
    function.
    
    r? `````@alexcrichton`````
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    13d8a56 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#82442 - Aaron1011:fix/closure-mut-crash, r=…

    …matthewjasper
    
    Skip emitting closure diagnostic when closure_kind_origins has no entry
    
    Fixes rust-lang#82438
    
    This map is not guarnateed to have an entry for a closure.
    Dylan-DPC authored Feb 27, 2021
    Configuration menu
    Copy the full SHA
    cd7737e View commit details
    Browse the repository at this point in the history