Make rustdoc lints a tool lint instead of built-in #80527

jyn514 · 2020-12-30T19:26:44Z

Rename broken_intra_doc_links to rustdoc::broken_intra_doc_links (and similar for other rustdoc lints; I don't expect any others to be used frequently, though).
Ensure that the old lint names still work and give deprecation errors
Register lints even when running doctests
Move lint machinery into a separate file
Add declare_rustdoc_lint! macro

Unblocks #80300, #79816, #80965. Makes the strangeness in #77364 more apparent to the end user (note that missing_docs is not moved to rustdoc in this PR). Closes #78786.

Current status

This is blocked on #82620 (see #80527 (comment))

rust-highfive · 2020-12-30T19:26:48Z

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

lopopolo · 2021-03-06T16:21:37Z

I would have liked to see the rustdoc lint group/tool name exist on stable before this change was merged.

It is not possible to run both nightly and stable builds with -D warnings and warn(broken_intra_doc_links)/warn(rustdoc:: broken_intra_doc_links) now because, despite allow(unknown_lints), the unknown tool name results in a hard error:

error[E0710]: an unknown tool name found in scoped lint: `rustdoc::broken_intra_doc_links`
 --> artichoke-core/src/lib.rs:9:9
  |
9 | #![warn(rustdoc::broken_intra_doc_links)]
  |         ^^^^^^^

jyn514 · 2021-03-06T17:34:24Z

It is not possible to run both nightly and stable builds with -D warnings and warn(broken_intra_doc_links)/warn(rustdoc:: broken_intra_doc_links) now because, despite allow(unknown_lints), the unknown tool name results in a hard error:

If you use the original name (broken_intra_doc_links) and allow(renamed_removed_lints), it should work.

lopopolo · 2021-03-06T17:58:48Z

@jyn514 does the introduction of a new tool name mean that declaring this lint as a crate level warn pragma will bump the MSRV of the crate?

lopopolo · 2021-03-06T18:03:09Z

If you use the original name (broken_intra_doc_links) and allow(renamed_removed_lints), it should work.

Since the lint has been removed, does this mean running nightly rustdoc will not detect broken intradoc links anymore?

jyn514 · 2021-03-06T18:14:48Z

Since the lint has been removed, does this mean running nightly rustdoc will not detect broken intradoc links anymore?

No, the lint name will still apply (since #82620).

@jyn514 does the introduction of a new tool name mean that declaring this lint as a crate level warn pragma will bump the MSRV of the crate?

Yes, unfortunately. There's no way to fix this because past releases are immutable (ideally the unknown tool name would only be a warning and not a hard error).

lopopolo · 2021-03-06T18:19:13Z

Thanks for the context. I think the best path forward for me is to remove the pragmas and add -D rustdoc::broken_intra_doc_links to CI via RUSTDOCFLAGS.

ideally the unknown tool name would only be a warning and not a hard error

Has this change landed in nightly/is there a ticket for it?

jyn514 · 2021-03-06T18:41:50Z

Has this change landed in nightly/is there a ticket for it?

I think #66079 (comment) is the closest issue.

lopopolo · 2021-03-06T18:43:20Z

Thank you!

…,GuillaumeGomez Rename `rustdoc` to `rustdoc::all` When rustdoc lints were changed to be tool lints, the `rustdoc` group was removed, leading to spurious warnings like ``` warning: unknown lint: `rustdoc` ``` The lint group still worked when rustdoc ran, since rustdoc added the group itself. This renames the group to `rustdoc::all` for consistency with `clippy::all` and the rest of the rustdoc lints. Follow-up to rust-lang#80527. r? `@Manishearth`

…,GuillaumeGomez Rename `rustdoc` to `rustdoc::all` When rustdoc lints were changed to be tool lints, the `rustdoc` group was removed, leading to spurious warnings like ``` warning: unknown lint: `rustdoc` ``` The lint group still worked when rustdoc ran, since rustdoc added the group itself. This renames the group to `rustdoc::all` for consistency with `clippy::all` and the rest of the rustdoc lints. Follow-up to rust-lang#80527. r? ``@Manishearth``

jyn514 · 2021-03-16T16:21:24Z

I would have liked to see the rustdoc lint group/tool name exist on stable before this change was merged.

@lopopolo I opened #83203 to turn off the warnings until this makes it to stable.

Don't warn about old rustdoc lint names (temporarily) Since rust-lang#80527, rustdoc users have an unpleasant situation: they can either use the new tool lint names (`rustdoc::non_autolinks`) or they can use the old names (`non_autolinks`). If they use the tool lints, they get a hard error on stable compilers, because rustc rejects all tool names it doesn't recognize (rust-lang#66079 (comment)). If they use the old name, they get a warning to rename the lint to the new name. The only way to compile without warnings is to add `#[allow(renamed_removed_lints)]`, which defeats the whole point of the change: we *want* people to switch to the new name. To avoid people silencing the lint and never migrating to the tool lint, this avoids warning about the old name, while still allowing you to use the new name. Once the new `rustdoc` tool name makes it to the stable channel, we can change these lints to warn again. This adds the new lint functions `register_alias` and `register_ignored` - I didn't see an existing way to do this. r? `@Manishearth` cc `@rust-lang/rustdoc`

Package changes: * bump bootstraps to 1.51.0. * adjust patches and cargo checksums as required * 1.51 failed to build natively on 32-bit armv7, there is hope that this is fixed with 1.52. (1.51 can be built with netbsd32 emulation on a aarch64 system). Upsteream changes: Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.] [cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.] [82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

Pkgsrc changes: * Bump bootstrap kit version to 1.51.0. * Adjust patches as needed. * Update checksum adjustments. * Fix syntax error in commands adjusting libserde_derive for Darwin Upstream changes: Version 1.52.1 (2021-05-10) ============================ This release disables incremental compilation, unless the user has explicitly opted in via the newly added RUSTC_FORCE_INCREMENTAL=1 environment variable. This is due to the widespread, and frequently occuring, breakage encountered by Rust users due to newly enabled incremental verification in 1.52.0. Notably, Rust users **should** upgrade to 1.52.0 or 1.52.1: the bugs that are detected by newly added incremental verification are still present in past stable versions, and are not yet fixed on any channel. These bugs can lead to miscompilation of Rust binaries. These problems only affect incremental builds, so release builds with Cargo should not be affected unless the user has explicitly opted into incremental. Debug and check builds are affected. See [84970] for more details. [84970]: rust-lang/rust#84970 Version 1.52.0 (2021-05-06) ============================ Language -------- - [Added the `unsafe_op_in_unsafe_fn` lint, which checks whether the unsafe code in an `unsafe fn` is wrapped in a `unsafe` block.][79208] This lint is allowed by default, and may become a warning or hard error in a future edition. - [You can now cast mutable references to arrays to a pointer of the same type as the element.][81479] Compiler -------- - [Upgraded the default LLVM to LLVM 12.][81451] Added tier 3\* support for the following targets. - [`s390x-unknown-linux-musl`][82166] - [`riscv32gc-unknown-linux-musl` & `riscv64gc-unknown-linux-musl`][82202] - [`powerpc-unknown-openbsd`][82733] \* Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [`OsString` now implements `Extend` and `FromIterator`.][82121] - [`cmp::Reverse` now has `#[repr(transparent)]` representation.][81879] - [`Arc<impl Error>` now implements `error::Error`.][80553] - [All integer division and remainder operations are now `const`.][80962] Stabilised APIs ------------- - [`Arguments::as_str`] - [`char::MAX`] - [`char::REPLACEMENT_CHARACTER`] - [`char::UNICODE_VERSION`] - [`char::decode_utf16`] - [`char::from_digit`] - [`char::from_u32_unchecked`] - [`char::from_u32`] - [`slice::partition_point`] - [`str::rsplit_once`] - [`str::split_once`] The following previously stable APIs are now `const`. - [`char::len_utf8`] - [`char::len_utf16`] - [`char::to_ascii_uppercase`] - [`char::to_ascii_lowercase`] - [`char::eq_ignore_ascii_case`] - [`u8::to_ascii_uppercase`] - [`u8::to_ascii_lowercase`] - [`u8::eq_ignore_ascii_case`] Rustdoc ------- - [Rustdoc lints are now treated as a tool lint, meaning that lints are now prefixed with `rustdoc::` (e.g. `#[warn(rustdoc::non_autolinks)]`).][80527] Using the old style is still allowed, and will become a warning in a future release. - [Rustdoc now supports argument files.][82261] - [Rustdoc now generates smart punctuation for documentation.][79423] - [You can now use "task lists" in Rustdoc Markdown.][81766] E.g. ```markdown - [x] Complete - [ ] Todo ``` Misc ---- - [You can now pass multiple filters to tests.][81356] E.g. `cargo test -- foo bar` will run all tests that match `foo` and `bar`. - [Rustup now distributes PDB symbols for the `std` library on Windows, allowing you to see `std` symbols when debugging.][82218] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Check the result cache before the DepGraph when ensuring queries][81855] - [Try fast_reject::simplify_type in coherence before doing full check][81744] - [Only store a LocalDefId in some HIR nodes][81611] - [Store HIR attributes in a side table][79519] Compatibility Notes ------------------- - [Cargo build scripts are now forbidden from setting `RUSTC_BOOTSTRAP`.][cargo/9181] - [Removed support for the `x86_64-rumprun-netbsd` target.][82594] - [Deprecated the `x86_64-sun-solaris` target in favor of `x86_64-pc-solaris`.][82216] - [Rustdoc now only accepts `,`, ` `, and `\t` as delimiters for specifying languages in code blocks.][78429] - [Rustc now catches more cases of `pub_use_of_private_extern_crate`][80763] - [Changes in how proc macros handle whitespace may lead to panics when used with older `proc-macro-hack` versions. A `cargo update` should be sufficient to fix this in all cases.][84136] [84136]: rust-lang/rust#84136 [80763]: rust-lang/rust#80763 [82166]: rust-lang/rust#82166 [82121]: rust-lang/rust#82121 [81879]: rust-lang/rust#81879 [82261]: rust-lang/rust#82261 [82218]: rust-lang/rust#82218 [82216]: rust-lang/rust#82216 [82202]: rust-lang/rust#82202 [81855]: rust-lang/rust#81855 [81766]: rust-lang/rust#81766 [81744]: rust-lang/rust#81744 [81611]: rust-lang/rust#81611 [81479]: rust-lang/rust#81479 [81451]: rust-lang/rust#81451 [81356]: rust-lang/rust#81356 [80962]: rust-lang/rust#80962 [80553]: rust-lang/rust#80553 [80527]: rust-lang/rust#80527 [79519]: rust-lang/rust#79519 [79423]: rust-lang/rust#79423 [79208]: rust-lang/rust#79208 [78429]: rust-lang/rust#78429 [82733]: rust-lang/rust#82733 [82594]: rust-lang/rust#82594 [cargo/9181]: rust-lang/cargo#9181 [`char::MAX`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.MAX [`char::REPLACEMENT_CHARACTER`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.REPLACEMENT_CHARACTER [`char::UNICODE_VERSION`]: https://doc.rust-lang.org/std/primitive.char.html#associatedconstant.UNICODE_VERSION [`char::decode_utf16`]: https://doc.rust-lang.org/std/primitive.char.html#method.decode_utf16 [`char::from_u32`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32 [`char::from_u32_unchecked`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_u32_unchecked [`char::from_digit`]: https://doc.rust-lang.org/std/primitive.char.html#method.from_digit [`Peekable::next_if`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if [`Peekable::next_if_eq`]: https://doc.rust-lang.org/stable/std/iter/struct.Peekable.html#method.next_if_eq [`Arguments::as_str`]: https://doc.rust-lang.org/stable/std/fmt/struct.Arguments.html#method.as_str [`str::split_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.split_once [`str::rsplit_once`]: https://doc.rust-lang.org/stable/std/primitive.str.html#method.rsplit_once [`slice::partition_point`]: https://doc.rust-lang.org/stable/std/primitive.slice.html#method.partition_point [`char::len_utf8`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf8 [`char::len_utf16`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.len_utf16 [`char::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_uppercase [`char::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_ascii_lowercase [`char::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.char.html#method.eq_ignore_ascii_case [`u8::to_ascii_uppercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_uppercase [`u8::to_ascii_lowercase`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.to_ascii_lowercase [`u8::eq_ignore_ascii_case`]: https://doc.rust-lang.org/stable/std/primitive.u8.html#method.eq_ignore_ascii_case

Warn when `rustdoc::` group is omitted from lint names When rustdoc lints were first made a tool lint, they gave an unconditional warning when you used the original name: ``` warning: lint `broken_intra_doc_links` has been renamed to `rustdoc::broken_intra_doc_links` --> $DIR/renamed-lint-still-applies.rs:2:9 | LL | #![deny(broken_intra_doc_links)] | ^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `rustdoc::broken_intra_doc_links` | = note: `#[warn(renamed_and_removed_lints)]` on by default ``` That was reverted in rust-lang#83203 because adding `rustdoc::x` lints would cause the code to break on old versions of the compiler (due to rust-lang#66079 (comment), "fixed" in rust-lang#83216 in the sense that you can now opt-in to not breaking on nightly, which is not ideal but `register_tool` is a long way from stabilizing). Since rust-lang#80527 is now on 1.52.0 stable, we can re-enable the warning. For nightly users, they can change immediately and still have their code work on stable; for stable users, they can change their code in 12 weeks and still have it work up to 3 releases back (about 18 weeks). That seems reasonable to me. r? `@Manishearth` cc `@rust-lang/rustdoc`

The lint has been renamed to `rustdoc::broken_intra_doc_links` and also it is now a warn-by-default so it makes less sense to enable it in the source code. cf. <rust-lang/rust#80527>

rust-highfive assigned GuillaumeGomez Dec 30, 2020

This comment has been minimized.

Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2020

This comment has been minimized.

Sign in to view

jyn514 mentioned this pull request Dec 31, 2020

Emit errors/warns on some wrong uses of rustdoc attributes #80300

Merged

GuillaumeGomez mentioned this pull request Jan 4, 2021

Cleanup rustdoc lint listing #80455

Closed

jyn514 mentioned this pull request Jan 4, 2021

Error when #[doc(alias)] has same name as the item #80686

Merged

poliorcetics mentioned this pull request Jan 5, 2021

Declare a new lint to properly deny warnings in rustdoc #79816

Closed

7 tasks

crlf0710 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2021

jyn514 changed the title ~~Make rustdoc lints to a tool lint instead of built-in~~ Make rustdoc lints a tool lint instead of built-in Jan 15, 2021

jyn514 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2021

jyn514 force-pushed the rustdoc-lints branch from e97ea2a to 998879b Compare January 15, 2021 22:08

This comment has been minimized.

Sign in to view

jyn514 force-pushed the rustdoc-lints branch from 8eb423a to 46e4053 Compare January 16, 2021 05:36

This comment has been minimized.

Sign in to view

jyn514 mentioned this pull request Jan 17, 2021

Don't make tools responsible for checking unknown and renamed lints #80524

Merged

jyn514 force-pushed the rustdoc-lints branch from 46e4053 to 29e2cf7 Compare January 17, 2021 15:59

This comment has been minimized.

Sign in to view

jyn514 mentioned this pull request Jan 17, 2021

Rename #[doc(spotlight)] to #[doc(notable_trait)] #80965

Merged

This comment has been minimized.

Sign in to view

jyn514 force-pushed the rustdoc-lints branch from 867d484 to 9b7f80a Compare January 17, 2021 16:46

rustbot added this to the 1.52.0 milestone Mar 4, 2021

jyn514 deleted the rustdoc-lints branch March 4, 2021 14:36

apiraino removed the to-announce Announce this issue on triage meeting label Mar 4, 2021

This was referenced Mar 5, 2021

Rename rustdoc to rustdoc::all #82798

Merged

Add --check for rustdoc rust-lang/cargo#8859

Closed

Emilgardis mentioned this pull request Mar 5, 2021

make getting expiration better and fix new rustdoc tool lint twitch-rs/twitch_oauth2#40

Merged

lopopolo mentioned this pull request Mar 6, 2021

Fix nightly build breakage due to rename of broken_intra_doc_links lint artichoke/artichoke#1119

Merged

This was referenced Mar 16, 2021

RFC: Create an RFC Process bevyengine/bevy#1662

Closed

Don't warn about old rustdoc lint names (temporarily) #83203

Merged

ehuss mentioned this pull request Apr 2, 2021

Add rustdoc to tool lints. rust-lang/reference#997

Merged

jyn514 mentioned this pull request Jul 3, 2021

Warn when rustdoc:: group is omitted from lint names #86849

Merged

brycx mentioned this pull request Oct 31, 2021

Fix warnings generated by nightly --release tests and bump MSRV to 1.52.0 orion-rs/orion#239

Merged

Nemo157 mentioned this pull request Sep 12, 2022

Tracking Issue for rustdoc::missing_doc_code_examples #101730

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make rustdoc lints a tool lint instead of built-in #80527

Make rustdoc lints a tool lint instead of built-in #80527

jyn514 commented Dec 30, 2020 •

edited

Loading

This comment has been minimized.

rust-highfive commented Dec 30, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lopopolo commented Mar 6, 2021 •

edited

Loading

jyn514 commented Mar 6, 2021 •

edited

Loading

lopopolo commented Mar 6, 2021 •

edited

Loading

lopopolo commented Mar 6, 2021

jyn514 commented Mar 6, 2021 •

edited

Loading

lopopolo commented Mar 6, 2021 •

edited

Loading

jyn514 commented Mar 6, 2021

lopopolo commented Mar 6, 2021

jyn514 commented Mar 16, 2021

Make rustdoc lints a tool lint instead of built-in #80527

Make rustdoc lints a tool lint instead of built-in #80527

Conversation

jyn514 commented Dec 30, 2020 • edited Loading

Current status

This comment has been minimized.

rust-highfive commented Dec 30, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

lopopolo commented Mar 6, 2021 • edited Loading

jyn514 commented Mar 6, 2021 • edited Loading

lopopolo commented Mar 6, 2021 • edited Loading

lopopolo commented Mar 6, 2021

jyn514 commented Mar 6, 2021 • edited Loading

lopopolo commented Mar 6, 2021 • edited Loading

jyn514 commented Mar 6, 2021

lopopolo commented Mar 6, 2021

jyn514 commented Mar 16, 2021

jyn514 commented Dec 30, 2020 •

edited

Loading

lopopolo commented Mar 6, 2021 •

edited

Loading

jyn514 commented Mar 6, 2021 •

edited

Loading

lopopolo commented Mar 6, 2021 •

edited

Loading

jyn514 commented Mar 6, 2021 •

edited

Loading

lopopolo commented Mar 6, 2021 •

edited

Loading