-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation of conversion from String to OsString #83700
Fix documentation of conversion from String to OsString #83700
Conversation
I’m also adding a few more minor cleanup things to this PR regarding |
6dc7d1f
to
5264ef2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
I’m also adding a few more minor cleanup things to this PR regarding
From
implementations
Do you have more cleanups other than 5264ef2 on this PR?
I can try to do some more “cleanups” like that, haven’t put in the work so far... most notably there’s also more problems with some of the documentations about string conversion, e.g. |
Ah, in case you were just asking about what I was referring to, no I haven’t got anything beyond 5264ef2 yet. Anything extra can also go into a new PR if this one gets approved in the meantime. |
Wait, @rust-highfive didn’t even assign anyone!? |
Error: Only Rust team members can ping teams. Please let |
well, okay, that didn’t work, @pietroalbini
|
Guess I can do it manually |
please do not ping people :D yeah it's a known thing and sometimes it happens. The infra team is aware about it. r? @Dylan-DPC |
|
One step ahead of you ;) |
📌 Commit 5264ef2a8063ab539f11e0081851a00b5c1ef62d has been approved by |
It's also in the commit message, which is why I commented instead of changing it myself. |
5264ef2
to
f5e7dbb
Compare
removed typo in the commit message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was late a bit but...
More links, one more occurrence of “a OsString” Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
eb3228e
to
7509aa1
Compare
Thanks again :) |
📌 Commit 7509aa1 has been approved by |
…on_documentation, r=JohnTitor Fix documentation of conversion from String to OsString From [this question on URLO](https://users.rust-lang.org/t/does-converting-a-string-into-a-pathbuf-allocate-new-buffer/57678), I noticed that the documentation of `From<String> for OsString` incorrectly claims to be copying data. `@rustbot` modify labels: T-doc, T-libs
…on_documentation, r=JohnTitor Fix documentation of conversion from String to OsString From [this question on URLO](https://users.rust-lang.org/t/does-converting-a-string-into-a-pathbuf-allocate-new-buffer/57678), I noticed that the documentation of `From<String> for OsString` incorrectly claims to be copying data. ``@rustbot`` modify labels: T-doc, T-libs
…on_documentation, r=JohnTitor Fix documentation of conversion from String to OsString From [this question on URLO](https://users.rust-lang.org/t/does-converting-a-string-into-a-pathbuf-allocate-new-buffer/57678), I noticed that the documentation of `From<String> for OsString` incorrectly claims to be copying data. ```@rustbot``` modify labels: T-doc, T-libs
Rollup of 5 pull requests Successful merges: - rust-lang#83015 (Add regression tests for rust-lang#79825 and rust-lang#81555) - rust-lang#83699 (Add a regression test for issue-68830) - rust-lang#83700 (Fix documentation of conversion from String to OsString) - rust-lang#83711 (Clarify `--print target-list` is a rustc's option) - rust-lang#83712 (Update LLVM with another wasm simd fix) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
From this question on URLO, I noticed that the documentation of
From<String> for OsString
incorrectly claims to be copying data.@rustbot modify labels: T-doc, T-libs