Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give a better error when std or core are missing #84450

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Give a better error when std or core are missing #84450

merged 1 commit into from
Apr 26, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 22, 2021 •
edited
Loading

  • Suggest using rustup target add if RUSTUP_HOME is set. I don't know if there's any precedent for doing this, but it seems harmless enough and it will be a big help.
  • On nightly, suggest using cargo build -Z build-std if CARGO is set
  • Add a note about #![no_std] if std is missing but not core
  • Add a note that std may be unsupported if std is missing but not core

Fixes #84418.

r? @petrochenkov

@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints A-resolve Area: Name resolution T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 22, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2021
@jyn514
Copy link
Member Author

jyn514 commented Apr 22, 2021

Oh. Well. I guess there aren't any tests for missing std/core :/

@jyn514 jyn514 changed the title [WIP] Give a better error when std or core are missing Give a better error when std or core are missing Apr 22, 2021
@petrochenkov
Copy link
Contributor

Is it possible to add a test for this?
For example using some target that is built-in, but tier 3 so it doesn't have a standard library.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 force-pushed the missing-std branch 2 times, most recently from fcbd1de to 4eff920 Compare April 25, 2021 14:49
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2021
@petrochenkov
Copy link
Contributor

Could you also squash commits after addressing the remaining comments?

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2021
@jyn514
Give a better error when std or core are missing
d326a4b 
- Suggest using `rustup target add` if `RUSTUP_HOME` is set. I don't know if there's any precedent for doing this, but it seems harmless enough and it will be a big help.
- Add a note about `#![no_std]` if `std` is missing but not core
- On nightly, suggest using `cargo build -Z build-std` if `CARGO` is set
- Add a note that std may be unsupported if `std` is missing but not core
- Don't suggest `#![no_std]` when the load isn't injected by the
  compiler
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Apr 25, 2021

📌 Commit d326a4b has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 25, 2021
@jyn514 jyn514 mentioned this pull request Apr 25, 2021
Merged
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 25, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2021
@bors
Auto merge of rust-lang#84564 - Dylan-DPC:rollup-wxa2yr0, r=Dylan-DPC
f8f5968 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#84235 (refactor StyledBuffer)
 - rust-lang#84450 (Give a better error when `std` or `core` are missing)
 - rust-lang#84486 (Handle pretty printing of `else if let` clauses without ICEing)
 - rust-lang#84499 (Tweak trait not `use`d suggestion)
 - rust-lang#84516 (Add suggestion to "use break" when attempting to implicit-break a loop)
 - rust-lang#84520 (Improve diagnostics for function passed when a type was expected.)
 - rust-lang#84541 (Inline most raw socket, fd and handle conversions)
 - rust-lang#84547 (Get rid of is_min_const_fn)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 379a55c into rust-lang:master Apr 26, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 26, 2021
@bors
Copy link
Contributor

bors commented Apr 26, 2021

⌛ Testing commit d326a4b with merge f8f5968...

@jyn514 jyn514 deleted the missing-std branch April 26, 2021 02:06
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jul 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-resolve Area: Name resolution S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

When std is missing the error message is very poor
6 participants
@jyn514 @petrochenkov @rust-log-analyzer @bors @rust-highfive @rustbot