Add suggestion to "use break" when attempting to implicit-break a loop #84516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Could you add some tests exercising these changes? |
added 2 commits
April 24, 2021 18:49
Sure, it's ready now. |
estebank
reviewed
Apr 24, 2021
|
|
||
| loop { | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
Can you add another case of loop { 1 } as foo's tail expression? That could suggest either return or break, right?
There was a problem hiding this comment.
Done. Yes, I thought it best to output no more than one of the suggestions, so that case is suggesting return as before. Note that this is also the case with the third error, hence this new test case may seem a bit redundant.
|
@bors r+ |
|
📌 Commit 3b50461 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 25, 2021
Add suggestion to "use break" when attempting to implicit-break a loop Fixes rust-lang#84114
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 25, 2021
Add suggestion to "use break" when attempting to implicit-break a loop Fixes rust-lang#84114
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 25, 2021
Add suggestion to "use break" when attempting to implicit-break a loop Fixes rust-lang#84114
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 25, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#84235 (refactor StyledBuffer) - rust-lang#84450 (Give a better error when `std` or `core` are missing) - rust-lang#84486 (Handle pretty printing of `else if let` clauses without ICEing) - rust-lang#84499 (Tweak trait not `use`d suggestion) - rust-lang#84516 (Add suggestion to "use break" when attempting to implicit-break a loop) - rust-lang#84520 (Improve diagnostics for function passed when a type was expected.) - rust-lang#84541 (Inline most raw socket, fd and handle conversions) - rust-lang#84547 (Get rid of is_min_const_fn) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84114