Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync rustc_codegen_cranelift #84746

Closed
wants to merge 59 commits into from
Closed

Sync rustc_codegen_cranelift #84746

wants to merge 59 commits into from

Conversation

XAMPPRocky
Copy link
Member

Sync rustc_codegen_cranelift with the latest main.

r? @bjorn3

bjorn3 and others added 30 commits March 29, 2021 10:45
This wrapper implements StableAddress and falls back to directly reading
the file on wasm32
This doesn't enable unwinding as cg_clif doesn't support it yet. It does
allow for linking to a cg_llvm compiled libstd.so, which uses
`-Cpanic=unwind`.
It is broken and needs to be rewritten from scratch
It isn't effective with the new backend framework
This reverts commit afe74d7. It
shouldn't have been pushed to master as it isn't ready yet.
Changes `librustc_X` to `rustc_X`, only in documentation comments.
Plain code comments are left unchanged.

Also fix incorrect file paths.
This simplifies the jit driver a lot
@rust-highfive
Copy link
Collaborator

Some changes occured to rustc_codegen_cranelift

cc @bjorn3

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@XAMPPRocky
Copy link
Member Author

Closing in favour of #84749

@XAMPPRocky XAMPPRocky closed this Apr 30, 2021
@XAMPPRocky XAMPPRocky deleted the cranelift-sync branch April 30, 2021 14:09
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 1, 2021
Sync `rustc_codegen_cranelift`

Retrying rust-lang#84746

r? `@bjorn3`

---

Edit(bjorn3): Since the last sync there have been some refactorings around the driver code in preparation for a planned new feature. In addition `@mominul` implemented `-Ctarget-cpu` support and `@XAMPPRocky` fixed compilation of cg_clif itself for Windows with the MSVC toolchain.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 1, 2021
Sync `rustc_codegen_cranelift`

Retrying rust-lang#84746

r? ``@bjorn3``

---

Edit(bjorn3): Since the last sync there have been some refactorings around the driver code in preparation for a planned new feature. In addition ``@mominul`` implemented `-Ctarget-cpu` support and ``@XAMPPRocky`` fixed compilation of cg_clif itself for Windows with the MSVC toolchain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants