-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync rustc_codegen_cranelift
#84749
Merged
Merged
Sync rustc_codegen_cranelift
#84749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wrapper implements StableAddress and falls back to directly reading the file on wasm32
This doesn't enable unwinding as cg_clif doesn't support it yet. It does allow for linking to a cg_llvm compiled libstd.so, which uses `-Cpanic=unwind`.
It is broken and needs to be rewritten from scratch
It isn't effective with the new backend framework
This reverts commit afe74d7. It shouldn't have been pushed to master as it isn't ready yet.
Changes `librustc_X` to `rustc_X`, only in documentation comments. Plain code comments are left unchanged. Also fix incorrect file paths.
Isolate mono items
This simplifies the jit driver a lot
Support -Ctarget-cpu
Some changes occured to rustc_codegen_cranelift cc @bjorn3 |
bjorn3
reviewed
Apr 30, 2021
Looks like you included the entirety of #81746 in this PR too. Edit: Didn't see #81746 (comment) yet. I would prefer making a new PR as the sync should be fine as is, but the rest will need to be reviewed independently. |
5b48834
to
9d07b92
Compare
* No-op register_jit on Windows Co-authored-by: bjorn3 <bjorn3@users.noreply.github.com>
📌 Commit ef53ebc has been approved by |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 1, 2021
Sync `rustc_codegen_cranelift` Retrying rust-lang#84746 r? `@bjorn3` --- Edit(bjorn3): Since the last sync there have been some refactorings around the driver code in preparation for a planned new feature. In addition `@mominul` implemented `-Ctarget-cpu` support and `@XAMPPRocky` fixed compilation of cg_clif itself for Windows with the MSVC toolchain.
This was referenced May 1, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 1, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#84601 (rustdoc: Only store locations in Cache::extern_locations and calculate the other info on-demand) - rust-lang#84704 (platform-support.md: Update for consistency with Target Tier Policy) - rust-lang#84724 (Replace llvm::sys::fs::F_None with llvm::sys::fs::OF_None) - rust-lang#84740 (Reset the docs' copy path button after 1 second) - rust-lang#84749 (Sync `rustc_codegen_cranelift`) - rust-lang#84756 (Add a ToC to the Target Tier Policy documentation) - rust-lang#84765 (Update cargo) - rust-lang#84774 (Fix misspelling) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-codegen
Area: Code generation
A-cranelift
Things relevant to the [future] cranelift backend
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrying #84746
r? @bjorn3
Edit(bjorn3): Since the last sync there have been some refactorings around the driver code in preparation for a planned new feature. In addition @mominul implemented
-Ctarget-cpu
support and @XAMPPRocky fixed compilation of cg_clif itself for Windows with the MSVC toolchain.