-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #85553
Rollup of 5 pull requests #85553
Conversation
This bug was only visible on mac. Also, print_step_rusage is a relatively new internal feature, that is not heavily used, and has no tests. All of these factors contributed to how this went uncaught this long. Thanks to Josh Triplett for pointing it out!
…komatsakis Add DerefOfRawPointer and CallToFunctionWith to THIR unsafeck Extends THIR unsafeck to check for two more cases of unsafe operations: dereferences of raw pointers and calls to functions with `#[target_feature]` (RFC 2396). The check for the latter is pretty much copy-pasted from the existing MIR equivalent. This will clash with rust-lang#83842 and rust-lang#85273 which are arguably more important, let's maybe focus on getting those merged first, this can wait. r? `@nikomatsakis` cc rust-lang/project-thir-unsafeck#7
…nikomatsakis Check for use of mutable/extern statics in THIR unsafeck Extends THIR unsafeck to check for use of mutable and extern statics. r? `@ghost` (I don't want to flood Niko's review queue) cc rust-lang/project-thir-unsafeck#7
…r=jsha Reset "focusedByTab" field when doing another search Fixes rust-lang#85467. The problem was simply that we forget to reset the `focusedByTab` field, which was still referring to removed DOM elements. r? `@jsha`
Remove dead toggle JS code Explanations on how I got there: I randomly saw `adjustToggle` while browsing through code, checked where it was called, put a `debugger;` instruction in it and checked on all pages while playing with settings and toggles. The breakpoint was never triggered. I then looked at `collapseNonInherent` (its grand-parent). In there, the breakpoint was triggered so I look at what was being done and in fact... nothing. So I simply removed it all, re-ran the tests and play with the UI. Everything is working as expected. Better double check in case I forgot to check a case though, but if nothing has been left out, then it's a great cleanup once again. :) r? `@jsha`
…c, r=Mark-Simulacrum facepalm: operator precedence fail on my part. This bug was only visible on mac. Also, print_step_rusage is a relatively new internal feature, that is not heavily used, and has no tests. All of these factors contributed to how this went uncaught this long. Thanks to Josh Triplett for pointing it out!
@bors: r+ p=5 rollup=never |
📌 Commit 0e4b51c has been approved by |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@GuillaumeGomez The error is due to #85306 and #85419 conflicting. I can file a PR merging the three THIR-unsafeck PRs together to fix the error and failed merge if you want |
⌛ Testing commit 0e4b51c with merge da5ca3e545f4f3ac6c54bcc63de1dd03fba49d11... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@LeSeulArtichaut That'd be nice. :) |
#85555 :) |
Successful merges:
Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup