td align attribute #85974
Merged
td align attribute #85974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
added
T-rustdoc
|
In general I think the right approach is to introduce a linter with exclusions for known issues (and possible non-issues), then gradually whittle down the exclusions or let them become permanent. So: Let's ignore the lint here. Changing to center aligned looks very bad. Also, align is deprecated but it still works. I'm guessing the markdown generator uses it because that allows being independent of CSS (though I suppose they could add an inline style). |
|
The center alignement is the current display. Otherwise I'm fine with ignoring this issue. |
|
Ah, if we can make it look better (left align) and also satisfy tidy, I'm happy about that. |
|
I removed the useless commits. With this change, the align is not centered anymore. |
|
@bors r+ rollup |
|
📌 Commit 38ec87c has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 5, 2021
td align attribute This is a follow-up of rust-lang#85972. I have put this one on its own because it changes the display:  Without align:  I also opened an issue about it: pulldown-cmark/pulldown-cmark#533. However, I'm not sure if this is the right course of action... Should we instead ignore the warning? r? `@jsha`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2021
…laumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#83646 (Add a map method to Bound) - rust-lang#85501 (Fix `deny(invalid_doc_attributes)`) - rust-lang#85503 (rustdoc: add tooltips to some buttons) - rust-lang#85710 (Document `From` impls in path.rs) - rust-lang#85760 (Possible errors when accessing file metadata are platform specific) - rust-lang#85974 (td align attribute) - rust-lang#86014 (msp430 linker does not accept -znoexecstack. Set linker_is_gnu to fal…) Failed merges: - rust-lang#85972 (Rustdoc html fixes) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #85972. I have put this one on its own because it changes the display:
Without align:
I also opened an issue about it: pulldown-cmark/pulldown-cmark#533. However, I'm not sure if this is the right course of action... Should we instead ignore the warning?
r? @jsha