-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #86032
Merged
Merged
Rollup of 7 pull requests #86032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular the `is_dir`, `is_file` and `exists` functions says that querying a file requires querying the directory. On Windows this is not normally true.
…se as workaround for now.
Add a map method to std::ops::range::Bound, patterned off of the method of the same name on Option
Add a map method to Bound Add a map method to std::ops::range::Bound, patterned off of the method of the same name on Option. Have left off creating a tracking issue initially, but as soon as I get the go-ahead from a reviewer I'll make that right away 😄
Fix `deny(invalid_doc_attributes)` Fixes rust-lang#85497.
rustdoc: add tooltips to some buttons
Document `From` impls in path.rs
…fic, r=m-ou-se Possible errors when accessing file metadata are platform specific In particular the `is_dir`, `is_file` and `exists` functions suggests that querying a file requires querying the directory. On Windows this is not normally true. r? `@m-ou-se`
td align attribute This is a follow-up of rust-lang#85972. I have put this one on its own because it changes the display: ![Screenshot from 2021-06-03 21-49-11](https://user-images.githubusercontent.com/3050060/120703622-d533d280-c4b5-11eb-9519-ea1131a40bee.png) Without align: ![Screenshot from 2021-06-03 21-49-15](https://user-images.githubusercontent.com/3050060/120703623-d5cc6900-c4b5-11eb-95f9-878d3915c7fb.png) I also opened an issue about it: pulldown-cmark/pulldown-cmark#533. However, I'm not sure if this is the right course of action... Should we instead ignore the warning? r? ``@jsha``
msp430 linker does not accept -znoexecstack. Set linker_is_gnu to fal… …se as workaround for now. Tested locally and works. Closes rust-lang#85948.
@bors: r+ p=7 rollup=never |
📌 Commit 16504f6 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jun 5, 2021
Some pr's common with #86029 |
Weird, how come it wasn't listed... |
☀️ Test successful - checks-actions |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
deny(invalid_doc_attributes)
#85501 (Fixdeny(invalid_doc_attributes)
)From
impls in path.rs #85710 (DocumentFrom
impls in path.rs)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup