-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RELEASES.md for 1.54.0 #86696
Conversation
Co-authored-by: Michael <5672750+mibac138@users.noreply.github.com>
Co-authored-by: Joshua Nelson <jyn514@gmail.com>
Co-authored-by: Jeff Parsons <jeff@parsons.io>
#85574 is a breaking change for soundness, which is likely to stay unless crater reveals widespread breakage. We should add a compatibility note for it. |
Unless something changed in the meantime, 1.54 also enables mutable noalias for LLVM >= 12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A number of these seem to belong to 1.55.0 instead.
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
@XAMPPRocky It looks like there are several comments outstanding here (one compat note, one note I just added, at least) and a few more relnotes marked issues:
|
We should also note #86063 in the compat notes. |
@bors r+ |
📌 Commit 9fc2bfa has been approved by |
@bors rollup |
☀️ Test successful - checks-actions |
…lacrum Prepare 1.54.0 release This PR builds the stable artifacts for the 1.54.0 release. Backports included: * rust-lang#86696 * rust-lang#87167 * rust-lang#87210 I was *not* able to cherry-pick rust-lang#87390 as that didn't apply cleanly to the stable branch. `@GuillaumeGomez` `@notriddle` could it be possible to get a PR targeting `stable` backporting that fix? Also, this **enables** incremental compilation on the stable channel. r? `@Mark-Simulacrum` cc `@rust-lang/release`
…crum Prepare beta 1.55.0 Included backports: * rust-lang#86696 * rust-lang#87390 (squashed) Reverted: * rust-lang#86623 cc `@rust-lang/release` `@Mark-Simulacrum`
@CryZe do you happen to have a link to the PR that reenabled it? I've been having trouble finding it. |
Add mutable-noalias to the release notes for 1.54 It was enabled in rust-lang#82834 and disabled in 1.53 by rust-lang#86036, but it was never disabled on (then) nightly, so it still landed in 1.54. This was mentioned on rust-lang#86696 but never made it into the release notes. r? `@XAMPPRocky` cc `@nikic`
Rendered
r? @Mark-Simulacrum
cc @rust-lang/release