-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustdoc accessibility: use real headers for doc items #87390
Rustdoc accessibility: use real headers for doc items #87390
Conversation
This is a pretty annoying workaround: the specifications literally contradict each other on the matter of whether headers may be nested inside of summaries. We need the headers for people who use outline mode to browse rustdoc, mostly in screen readers, and the headers need to be inside the summary tag so that they're visible when the details tag is collapsed. HTML5 says it's okay, but the ordinary button semantics in ARIA say that headers nested in buttons are ignored, and summary is a button. Which means some screen readers, like NVDA, work, while others, like JAWS, don't.
Some changes occurred in HTML/CSS/JS. |
r? @CraftSpider (rust-highfive has picked a reviewer for you, use r? to override) |
1b7232f
to
0147ce7
Compare
To get ahead of the "can you check it please": yes, this works at least with my setup, and it looks like you just made my day. Also apparently I missed the table of contents headers one if that's not part of this one, but that's also very nice. |
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
This comment has been minimized.
This comment has been minimized.
@GuillaumeGomez okay, I fixed the tooltip and all of the test cases. |
@notriddle: 🔑 Insufficient privileges: Not in reviewers |
@bors: r+ squash |
📌 Commit 7e888bd has been approved by |
…atch, r=GuillaumeGomez Rustdoc accessibility: use real headers for doc items Part of rust-lang#87059 Partially reverts rust-lang#84703 Preview at: https://notriddle.com/notriddle-rustdoc-test/real-headers/std/index.html
☀️ Test successful - checks-actions |
This has been merged. |
…lacrum Prepare 1.54.0 release This PR builds the stable artifacts for the 1.54.0 release. Backports included: * rust-lang#86696 * rust-lang#87167 * rust-lang#87210 I was *not* able to cherry-pick rust-lang#87390 as that didn't apply cleanly to the stable branch. `@GuillaumeGomez` `@notriddle` could it be possible to get a PR targeting `stable` backporting that fix? Also, this **enables** incremental compilation on the stable channel. r? `@Mark-Simulacrum` cc `@rust-lang/release`
Part of rust-lang#87059 Partially reverts rust-lang#84703 Backport of rust-lang#87390 Preview at: https://notriddle.com/notriddle-rustdoc-test/real-headers/std/index.html
Actually, this will also need to be backported to 1.55.0 beta as it was merged after the beta cutoff. |
Included in #87508 |
…crum Prepare beta 1.55.0 Included backports: * rust-lang#86696 * rust-lang#87390 (squashed) Reverted: * rust-lang#86623 cc `@rust-lang/release` `@Mark-Simulacrum`
Part of #87059
Partially reverts #84703
Preview at: https://notriddle.com/notriddle-rustdoc-test/real-headers/std/index.html