-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #87095
Merged
Merged
Rollup of 11 pull requests #87095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
present perfect passive constructions need to use the past participle form, which for run is "run".
Split MaybeUninit::write into new feature gate and stabilize it This splits off the `MaybeUninit::write` function from the `maybe_uninit_extra` feature gate into a new `maybe_uninit_write` feature gate and stabilizes it. Earlier work to improve the documentation of the write function: rust-lang#86220 Tracking issue: rust-lang#63567
Remove unstable `io::Cursor::remaining` Adding `io::Cursor::remaining` in rust-lang#86037 caused a conflict with the implementation of `bytes::Buf` for `io::Cursor`, leading to an error in nightly, see rust-lang#86369 (comment). This fixes the error by temporarily removing the `remaining` function. r? `@yaahc`
…riplett stdio_locked: add tracking issue Add the tracking issue number rust-lang#86845 to the stability attributes for the implementation in rust-lang#86799. r? `@joshtriplett` `@rustbot` label +A-io +C-cleanup +T-libs-api
rustdoc: remove dead code in `clean` Builds on rust-lang#86886 and should not be merged before.
…Mark-Simulacrum Fix rust-analyzer install when not available. This changes it so that `x.py install` won't fail if rust-analyzer isn't available. This was changed in rust-lang#86568 to handle the case where installing on stable/beta, and `extended=true`, to skip rust-analyzer. But I neglected to update the install part to also ignore it. Fixes rust-lang#86999
…play, r=notriddle Fix implementors display Part of rust-lang#86632. This PR does a few things: * It fixes of the JS rendered implementors. * It generates anchors for JS rendered implementors to make it coherent with the others. * It adds a test to ensure that we won't have the same issue again. * It changes the way we render the rustdoc-gui crates to simplify it a bit and also to allow to have dependencies without going through compiletest. Before: ![Screenshot from 2021-07-10 13-30-13](https://user-images.githubusercontent.com/3050060/125174172-b4048700-e1c3-11eb-8f0e-c46081371d4f.png) After: ![Screenshot from 2021-07-10 21-11-15](https://user-images.githubusercontent.com/3050060/125174173-b49d1d80-e1c3-11eb-8740-1dbbff70c2eb.png) I plan to add the `[src]` links in another PR because this one is already big enough. cc `@Mark-Simulacrum` (for the bootstrap changes) r? `@Nemo157`
Fix ICE with unsized type in const pattern Fixes rust-lang#87046. The `deref_const()` query currently contains the following check: https://github.com/rust-lang/rust/blob/e9a387d6cf5961a7f2dcb671da3147bd413355c4/compiler/rustc_mir/src/const_eval/mod.rs#L191-L204 i.e. this will cause an ICE for every unsized type except slices. An error is reported with my changes if such a type is used as a const pattern (this should not be a breaking change, since so far, this has caused an ICE).
…-obk Simplify future incompatible reporting. This simplifies the implementation of the future incompatible reporting system. Instead of having a separate field in the future_incompatible definition, this reuses the `FutureIncompatibilityReason` enum. It also drops the "date" field. Cargo does not use the date field, and there isn't much of a need for this to be structured, and I am skeptical that the date can be predicted reliably. The date or release version can be listed in the lint text if desired.
…=lnicola ⬆️ rust-analyzer `@bors` r+
Rustdoc: suggest removing disambiguator if linking to field This fixes rust-lang#85615. `@rustbot` label T-rustdoc
…-obk CTFE engine: small cleanups I noticed these while preparing a large PR, and figured I'd better send them ahead to not muddy the diff unnecessarily. - remove remaining use of Pointer in Allocation API (I missed those in rust-lang#85472) - remove unnecessary deallocate_local hack (this logic does not seem necessary any more) r? `@oli-obk`
@bors r+ p=11 rollup=never |
📌 Commit e46b790 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Jul 12, 2021
☀️ Test successful - checks-actions |
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
io::Cursor::remaining
#86811 (Remove unstableio::Cursor::remaining
)clean
#86887 (rustdoc: remove dead code inclean
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup