fix performance regression from invalid IR #8724
Closed
+3
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monomorphize's normalization results in a 2% decrease in non-optimized code size for libstd, so there's a negligible cost to removing it. This also fixes several visit glue bugs because normalize wasn't considering the differences in visit glue between types. Closes #8720
bors
added a commit
that referenced
this pull request
Aug 24, 2013
Monomorphize's normalization results in a 2% decrease in non-optimized code size for libstd, so there's a negligible cost to removing it. This also fixes several visit glue bugs because normalize wasn't considering the differences in visit glue between types. Closes #8720
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 5, 2022
[FP] identity_op in front of if fix rust-lang#8724 changelog: FP: [`identity_op`]: is now allowed in front of if statements, blocks and other expressions where the suggestion would be invalid. Resolved simular problems with blocks, mathces, and loops. identity_op always does NOT suggest reducing `0 + if b { 1 } else { 2 } + 3` into `if b { 1 } else { 2 } + 3` even in the case that the expression is in `f(expr)` or `let x = expr;` for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monomorphize's normalization results in a 2% decrease in non-optimized
code size for libstd, so there's a negligible cost to removing it. This
also fixes several visit glue bugs because normalize wasn't considering
the differences in visit glue between types.
Closes #8720