Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd remove compiler workaround. #87457

Merged
merged 1 commit into from
Jul 27, 2021
Merged

freebsd remove compiler workaround. #87457

merged 1 commit into from
Jul 27, 2021

Conversation

devnexen
Copy link
Contributor

related issue #43575

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2021
@bjorn3
Copy link
Member

bjorn3 commented Jul 25, 2021

Have you tested if the original problem no longer happens on FreeBSD? FreeBSD is a tier 2 platform, which means that tests are not run for it. It is only checked that it keeps building.

@devnexen
Copy link
Contributor Author

Yes the issue does not occur any longer.

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 25, 2021

📌 Commit 76d1453 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 26, 2021
…laumeGomez

Rollup of 8 pull requests

Successful merges:

 - rust-lang#87436 (Suggest `;` on parse error where applicable)
 - rust-lang#87444 (Flatten nested `format!` calls)
 - rust-lang#87447 (Miri: santiy check that null pointer can never have an AllocId)
 - rust-lang#87457 (freebsd remove compiler workaround.)
 - rust-lang#87458 (Fix help message for modification to &T created by &{t})
 - rust-lang#87464 (Remove unnecessary `structhead` parameter from `render_union`)
 - rust-lang#87473 (Notify the Rust 2021 edition working group in zulip of edition bugs)
 - rust-lang#87474 (Add missing whitespace after attribute in HTML template)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e3c6cd2 into rust-lang:master Jul 27, 2021
@rustbot rustbot added this to the 1.56.0 milestone Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants