Rollup of 8 pull requests #87480
Merged
Rollup of 8 pull requests #87480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related issue rust-lang#43575
`structhead` is used for `render_struct` so that the logic for rendering structs can be shared between struct variants and struct items. However, `render_union` is not used anywhere except for rendering union items, so its `structhead` parameter is unnecessary.
Suggest `;` on parse error where applicable fixes rust-lang#87197
…n514 Flatten nested `format!` calls
Miri: santiy check that null pointer can never have an AllocId
…petrochenkov freebsd remove compiler workaround. related issue rust-lang#43575
…r=oli-obk
Fix help message for modification to &T created by &{t}
Previous:
```rust
error[E0594]: cannot assign to `*x` which is behind a `&` reference
--> src/main.rs:3:5
|
2 | let x: &usize = &mut{0};
| ------- help: consider changing this to be a mutable reference: `&mut mut{0}`
3 | *x = 1;
| ^^^^^^ `x` is a `&` reference, so the data it refers to cannot be written
```
Remove unnecessary `structhead` parameter from `render_union` `structhead` is used for `render_struct` so that the logic for rendering structs can be shared between struct variants and struct items. However, `render_union` is not used anywhere except for rendering union items, so its `structhead` parameter is unnecessary.
…jyn514 Notify the Rust 2021 edition working group in zulip of edition bugs Notifying the group of these issues will make it easier for us to track them. r? `@jyn514`
…fter-attr, r=notriddle Add missing whitespace after attribute in HTML template Firefox (even though it worked) highlights it as red when you look at the source code because there is a missing whitespace. r? `@notriddle`
|
@bors: r+ p=8 rollup=never |
|
📌 Commit 12c2092 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 12c2092 with merge 48351bee698897cc208e8cb2008f68ccd55ec976... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Timeout. @bors: retry |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
;on parse error where applicable #87436 (Suggest;on parse error where applicable)format!calls #87444 (Flatten nestedformat!calls)structheadparameter fromrender_union#87464 (Remove unnecessarystructheadparameter fromrender_union)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup