Improve non_fmt_panics suggestion based on trait impls.

[m-ou-se]

This improves the non_fmt_panics lint suggestions by checking first which trait (Display or Debug) are actually implemented on the type.

Fixes #87313

Fixes #87999

Before:

help: add a "{}" format string to Display the message
  |
2 |     panic!("{}", Some(1));
  |            +++++
help: or use std::panic::panic_any instead
  |
2 |     std::panic::panic_any(Some(1));
  |     ~~~~~~~~~~~~~~~~~~~~~

After:

help: add a "{:?}" format string to use the Debug implementation of `Option<i32>`
  |
2 |     panic!("{:?}", Some(1));
  |            +++++++
help: or use std::panic::panic_any instead
  |
2 |     std::panic::panic_any(Some(1));
  |     ~~~~~~~~~~~~~~~~~~~~~

r? @estebank

[estebank]

Isn't this logic reversed?

[m-ou-se]

No. It marks the format-string suggestion (adding "{}" or "{:?}") as machine applicable only when the panic_any suggestion isn't, as there shouldn't be more than one alternative marked as machine applicable.

[estebank]

LGTM, except for the concern around applicability.

[estebank]

@bors r+

[bors]

📌 Commit ab8cbc3 has been approved by estebank

[m-ou-se]

Raising priority so it can be part of the edition migration crater run.

@bors p=1

[bors]

⌛ Testing commit ab8cbc3 with merge d83da1d...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing d83da1d to master...