- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
          feat(rustc_typeck): suggest removing bad parens in (recv.method)()
          #88841
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | r? @estebank (rust-highfive has picked a reviewer for you, use r? to override) | 
c57622e    to
    90265b9      
    Compare
  
    90265b9    to
    5dab3c5      
    Compare
  
    
              
                    estebank
  
              
              approved these changes
              
                  
                    Sep 12, 2021 
                  
              
              
            
            
| @estebank it's been converted to a multipart suggestion. | 
| @bors r+ | 
| 📌 Commit 8be729c has been approved by  | 
    
  workingjubilee 
      added a commit
        to workingjubilee/rustc
      that referenced
      this pull request
    
      Sep 14, 2021 
    
    
      
  
    
      
    
  
…r=estebank feat(rustc_typeck): suggest removing bad parens in `(recv.method)()` Fixes rust-lang#88803
    
  workingjubilee 
      added a commit
        to workingjubilee/rustc
      that referenced
      this pull request
    
      Sep 14, 2021 
    
    
      
  
    
      
    
  
…r=estebank feat(rustc_typeck): suggest removing bad parens in `(recv.method)()` Fixes rust-lang#88803
    
  Manishearth 
      added a commit
        to Manishearth/rust
      that referenced
      this pull request
    
      Sep 14, 2021 
    
    
      
  
    
      
    
  
…r=estebank feat(rustc_typeck): suggest removing bad parens in `(recv.method)()` Fixes rust-lang#88803
    
  Manishearth 
      added a commit
        to Manishearth/rust
      that referenced
      this pull request
    
      Sep 14, 2021 
    
    
      
  
    
      
    
  
…r=estebank feat(rustc_typeck): suggest removing bad parens in `(recv.method)()` Fixes rust-lang#88803
    
  Manishearth 
      added a commit
        to Manishearth/rust
      that referenced
      this pull request
    
      Sep 14, 2021 
    
    
      
  
    
      
    
  
…r=estebank feat(rustc_typeck): suggest removing bad parens in `(recv.method)()` Fixes rust-lang#88803
    
  Manishearth 
      added a commit
        to Manishearth/rust
      that referenced
      this pull request
    
      Sep 14, 2021 
    
    
      
  
    
      
    
  
…r=estebank feat(rustc_typeck): suggest removing bad parens in `(recv.method)()` Fixes rust-lang#88803
    
  Manishearth 
      added a commit
        to Manishearth/rust
      that referenced
      this pull request
    
      Sep 15, 2021 
    
    
      
  
    
      
    
  
…r=estebank feat(rustc_typeck): suggest removing bad parens in `(recv.method)()` Fixes rust-lang#88803
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Sep 16, 2021 
    
    
      
  
    
      
    
  
…arth Rollup of 8 pull requests Successful merges: - rust-lang#87320 (Introduce -Z remap-cwd-prefix switch) - rust-lang#88690 (Accept `m!{ .. }.method()` and `m!{ .. }?` statements. ) - rust-lang#88775 (Revert anon union parsing) - rust-lang#88841 (feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`) - rust-lang#88907 (Highlight the `const fn` if error happened because of a bound on the impl block) - rust-lang#88915 (`Wrapping<T>` has the same layout and ABI as `T`) - rust-lang#88933 (Remove implementation of `min_align_of` intrinsic) - rust-lang#88951 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes #88803