Skip to content

Conversation

notriddle
Copy link
Contributor

Fixes #88803

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2021
@notriddle notriddle force-pushed the notriddle/method-parens branch from c57622e to 90265b9 Compare September 11, 2021 01:26
@notriddle notriddle force-pushed the notriddle/method-parens branch from 90265b9 to 5dab3c5 Compare September 11, 2021 01:29
@notriddle
Copy link
Contributor Author

@estebank it's been converted to a multipart suggestion.

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 13, 2021

📌 Commit 8be729c has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
…r=estebank

feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`

Fixes rust-lang#88803
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 14, 2021
…r=estebank

feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`

Fixes rust-lang#88803
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
…r=estebank

feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`

Fixes rust-lang#88803
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
…r=estebank

feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`

Fixes rust-lang#88803
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
…r=estebank

feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`

Fixes rust-lang#88803
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 14, 2021
…r=estebank

feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`

Fixes rust-lang#88803
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 15, 2021
…r=estebank

feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`

Fixes rust-lang#88803
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2021
…arth

Rollup of 8 pull requests

Successful merges:

 - rust-lang#87320 (Introduce -Z remap-cwd-prefix switch)
 - rust-lang#88690 (Accept `m!{ .. }.method()` and `m!{ .. }?` statements. )
 - rust-lang#88775 (Revert anon union parsing)
 - rust-lang#88841 (feat(rustc_typeck): suggest removing bad parens in `(recv.method)()`)
 - rust-lang#88907 (Highlight the `const fn` if error happened because of a bound on the impl block)
 - rust-lang#88915 (`Wrapping<T>` has the same layout and ABI as `T`)
 - rust-lang#88933 (Remove implementation of `min_align_of` intrinsic)
 - rust-lang#88951 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1bf94a1 into rust-lang:master Sep 16, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 16, 2021
@notriddle notriddle deleted the notriddle/method-parens branch September 16, 2021 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With over-parenthesized method call, E0615 suggests adding parentheses in the wrong place
5 participants