Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #89525

Closed
wants to merge 35 commits into from

Commits on Aug 29, 2021

  1. Fix an ICE caused by type mismatch errors being ignored

    theo-lw authored and tlwang committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    dec7fc3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ab73cf View commit details
    Browse the repository at this point in the history
  3. VecDeque: improve performance for From<[T; N]>

    Create VecDeque directly from the array instead of inserting items one-by-one.
    xu-cheng committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    c3cff0a View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Add a try_clone() function to OwnedFd.

    As suggested in rust-lang#88564. This adds a `try_clone()` to `OwnedFd` by
    refactoring the code out of the existing `File`/`Socket` code.
    sunfishcode committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    18c14ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    622dfcc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c986c6b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2d6a4c8 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Configuration menu
    Copy the full SHA
    09d55d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Improve wording of map_or_else docs

    Changes doc text to refer to the "default" parameter as the "default"
    function.
    Nitepone committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    35b0015 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7ed75ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2c6e671 View commit details
    Browse the repository at this point in the history
  4. from review: code style

    Co-authored-by: Ivan Tham <pickfire@riseup.net>
    the8472 and pickfire committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    6654a0b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ffd7ade View commit details
    Browse the repository at this point in the history
  6. [aarch64] add target feature outline-atomics

    Enable outline-atomics by default as enabled in clang by the following commit
    https://reviews.llvm.org/rGc5e7e649d537067dec7111f3de1430d0fc8a4d11
    
    Performance improves by several orders of magnitude when using the LSE instructions
    instead of the ARMv8.0 compatible load/store exclusive instructions.
    
    Tested on Graviton2 aarch64-linux with
    x.py build && x.py install && x.py test
    Sebastian Pop committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    0f9f241 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Include the length in BTree hashes

    This change makes it consistent with `Hash` for all other collections.
    cuviper committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    d6fde80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d92c683 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    277a018 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2021

  1. Consistently use 'supertrait'.

    A subset of places referred to 'super-trait', so this changes them
    to all use 'supertrait'. This matches 'supertype' and some other
    usages. An exception is 'auto-trait' which is consistently used
    in that manner.
    waywardmonkeys committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    058a21d View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2021

  1. Configuration menu
    Copy the full SHA
    3818981 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a28a78f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Stabilize const_panic

    jhpratt committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    bce8621 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#83655 - sebpop:arm64-outline-atomics, r=wor…

    …kingjubilee
    
    [aarch64] add target feature outline-atomics
    
    Enable outline-atomics by default as enabled in clang by the following commit
    https://reviews.llvm.org/rGc5e7e649d537067dec7111f3de1430d0fc8a4d11
    
    Performance improves by several orders of magnitude when using the LSE instructions
    instead of the ARMv8.0 compatible load/store exclusive instructions.
    
    Tested on Graviton2 aarch64-linux with
    x.py build && x.py install && x.py test
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    02d1f83 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#87091 - the8472:more-advance-by-impls, r=jo…

    …shtriplett
    
    implement advance_(back_)_by on more iterators
    
    Add more efficient, non-default implementations for `feature(iter_advance_by)` (rust-lang#77404) on more iterators and adapters.
    
    This PR only contains implementations where skipping over items doesn't elide any observable side-effects such as user-provided closures or `clone()` functions. I'll put those in a separate PR.
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    6a00ed9 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#88451 - theo-lw:issue-87771, r=jackh726

    Fix an ICE caused by type mismatch errors being ignored
    
    This PR fixes rust-lang#87771. It turns out that the check on `compiler/rustc_typeck/src/check/demand.rs:148` leads to the ICE. I removed it because the early return in [`check_expr_assign`](https://github.com/theo-lw/rust/blob/dec7fc3ced5bc3c18d0e5d29921d087f93189cb8/compiler/rustc_typeck/src/check/expr.rs#L928) already prevents unnecessary error messages from the call to `check_expr_coercable_to_type`.
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    7b1ad3e View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#88452 - xu-cheng:vecdeque-from-array, r=m-o…

    …u-se
    
    VecDeque: improve performance for From<[T; N]>
    
    Create `VecDeque` directly from the array instead of inserting items one-by-one.
    
    Benchmark
    ```
    ./x.py bench library/alloc --test-args vec_deque::bench_from_array_1000
    ```
    
    * Before
    ```
    test vec_deque::bench_from_array_1000                    ... bench:       3,991 ns/iter (+/- 717)
    ```
    
    * After
    ```
    test vec_deque::bench_from_array_1000                    ... bench:         268 ns/iter (+/- 37)
    ```
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    fe0759f View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#88794 - sunfishcode:sunfishcode/try-clone, …

    …r=joshtriplett
    
    Add a `try_clone()` function to `OwnedFd`.
    
    As suggested in rust-lang#88564. This adds a `try_clone()` to `OwnedFd` by
    refactoring the code out of the existing `File`/`Socket` code.
    
    r? `@joshtriplett`
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    b5301d8 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#89400 - Nitepone:nitepone/map-or-else-docfi…

    …x, r=dtolnay
    
    Improve wording of `map_or_else` docs
    
    Changes doc text to refer to the "default" parameter as the "default"
    function.
    
    Previously, the doc text referred to the "f" parameter as the "default" function; and the "default" parameter as the "fallback" function.
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    fd4974b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#89407 - pierwill:recommend-clean-E0514, r=d…

    …avidtwco
    
    Recommend running `cargo clean` in E0514 output
    
    This suggestion has worked for me before. Seems to me it could help others.
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    54f9a67 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#89443 - cuviper:btree-hash-len, r=dtolnay

    Include the length in BTree hashes
    
    This change makes it consistent with `Hash` for all other collections.
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    337ad5b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#89444 - notriddle:notriddle/contains-str, r…

    …=jyn514
    
    rustdoc: use slice::contains instead of open-coding it
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    dd925cc View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#89447 - FabianWolff:issue-89388, r=davidtwco

    Improve error message for missing angle brackets in `[_]::method`
    
    Fixes rust-lang#89388.
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    9d081ce View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#89453 - waywardmonkeys:consistent-supertrai…

    …t-usage, r=nagisa
    
    Consistently use 'supertrait'.
    
    A subset of places referred to 'super-trait', so this changes them
    to all use 'supertrait'. This matches 'supertype' and some other
    usages. An exception is 'auto-trait' which is consistently used
    in that manner.
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    e122009 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#89483 - hkmatsumoto:patch-diagnostics-2, r=…

    …estebank
    
    Practice diagnostic message convention
    
    Detected by rust-lang#89455.
    
    r? `@estebank`
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    e11685f View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#89500 - FabianWolff:issue-87308, r=petroche…

    …nkov
    
    Fix ICE with buffered lint referring to AST node deleted by everybody_loops
    
    Fixes rust-lang#87308. Note the following comment:
    https://github.com/rust-lang/rust/blob/08759c691e2e9799a3c6780ffdf910240ebd4a6b/compiler/rustc_lint/src/early.rs#L415-L417
    
    As it turns out, this is not _always_ a bug, because `-Zunpretty=everybody_loops` causes a lot of AST nodes to be deleted, and thus some buffered lints will refer to non-existent node ids. To fix this, my changes simply ignore buffered lints if `-Zunpretty=everybody_loops` is enabled, which, from my understanding, shouldn't be a big issue because it only affects pretty-printing. Of course, a more elegant solution would only ignore buffered lints that actually point at deleted node ids, but I haven't figured out an easy way of achieving this.
    
    For the concrete example in rust-lang#87308, the buffered lint is created [here](https://github.com/rust-lang/rust/blob/08759c691e2e9799a3c6780ffdf910240ebd4a6b/compiler/rustc_expand/src/mbe/macro_rules.rs#L145-L151) with the `lint_node_id` from [here](https://github.com/rust-lang/rust/blob/08759c691e2e9799a3c6780ffdf910240ebd4a6b/compiler/rustc_expand/src/mbe/macro_rules.rs#L319), i.e. it points at the macro _expansion_, which then gets deleted by `ReplaceBodyWithLoop` [here](https://github.com/rust-lang/rust/blob/08759c691e2e9799a3c6780ffdf910240ebd4a6b/compiler/rustc_interface/src/passes.rs#L377).
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    ecd5bb8 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#89508 - jhpratt:stabilize-const_panic, r=jo…

    …shtriplett
    
    Stabilize `const_panic`
    
    Closes rust-lang#51999
    
    FCP completed in rust-lang#89006
    
    `@rustbot` label +A-const-eval +A-const-fn +T-lang
    
    cc `@oli-obk` for review (not `r?`'ing as not on lang team)
    Manishearth authored Oct 4, 2021
    Configuration menu
    Copy the full SHA
    2914d1d View commit details
    Browse the repository at this point in the history