Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject closures in patterns #90028

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Reject closures in patterns #90028

merged 1 commit into from
Oct 22, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Oct 18, 2021 •
edited
Loading

Fixes #90013.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Oct 18, 2021

cc @spastorino

@camelid
Copy link
Member

camelid commented Oct 18, 2021 •
edited
Loading

Fixes #90013.

It'd probably be good to add the MCVE there as another test.

@spastorino
Copy link
Member

👍, as @camelid has said, can you add the MCVE as a test and then @bors r=me

@bors
Copy link
Contributor

bors commented Oct 19, 2021

📌 Commit d384caae9dc040e614edb9487c86e05bee5d5cb3 has been approved by `me``

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2021
@spastorino
Copy link
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 19, 2021
@spastorino
Copy link
Member

spastorino commented Oct 19, 2021 •
edited
Loading

I thought bors wasn't parsing things inside ` `

@spastorino
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 20, 2021

📌 Commit c97cf7f has been approved by spastorino

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 20, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 20, 2021
@matthiaskrgr
Rollup merge of rust-lang#90028 - tmiasko:structural-match-closure, r…
b73bf3b 
…=spastorino

Reject closures in patterns

Fixes rust-lang#90013.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 20, 2021
Closed
@davidtwco davidtwco assigned spastorino and unassigned davidtwco Oct 21, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 21, 2021
@JohnTitor
Rollup merge of rust-lang#90028 - tmiasko:structural-match-closure, r…
ea4f062 
…=spastorino

Reject closures in patterns

Fixes rust-lang#90013.
@JohnTitor JohnTitor mentioned this pull request Oct 21, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 21, 2021
@JohnTitor
Rollup merge of rust-lang#90028 - tmiasko:structural-match-closure, r…
b678d34 
…=spastorino

Reject closures in patterns

Fixes rust-lang#90013.
@JohnTitor JohnTitor mentioned this pull request Oct 21, 2021
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2021
@JohnTitor
Rollup merge of rust-lang#90028 - tmiasko:structural-match-closure, r…
a93e7e0 
…=spastorino

Reject closures in patterns

Fixes rust-lang#90013.
@JohnTitor JohnTitor mentioned this pull request Oct 22, 2021
Closed
@JohnTitor JohnTitor mentioned this pull request Oct 22, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2021
@bors
Auto merge of rust-lang#90161 - JohnTitor:rollup-1j2qc8m, r=JohnTitor
45b600c 
Rollup of 14 pull requests

Successful merges:

 - rust-lang#87537 (Clarify undefined behaviour in binary heap, btree and hashset docs)
 - rust-lang#88624 (Stabilize feature `saturating_div` for rust 1.58.0)
 - rust-lang#89257 (Give better error for `macro_rules name`)
 - rust-lang#89665 (Ensure that pushing empty path works as before on verbatim paths)
 - rust-lang#89895 (Don't mark for loop iter expression as desugared)
 - rust-lang#89922 (Update E0637 description to mention `&` w/o an explicit lifetime name)
 - rust-lang#89944 (Change `Duration::[try_]from_secs_{f32, f64}` underflow error)
 - rust-lang#89991 (rustc_ast: Turn `MutVisitor::token_visiting_enabled` into a constant)
 - rust-lang#90028 (Reject closures in patterns)
 - rust-lang#90069 (Fix const qualification when executed after promotion)
 - rust-lang#90078 (Add a regression test for issue-83479)
 - rust-lang#90114 (Add some tests for const_generics_defaults)
 - rust-lang#90115 (Add test for issue rust-lang#78561)
 - rust-lang#90129 (triagebot: Treat `I-*nominated` like `I-nominated`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9ed9025 into rust-lang:master Oct 22, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 22, 2021
@tmiasko tmiasko deleted the structural-match-closure branch October 22, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spastorino spastorino

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

ICE: Closure in inline const block causes an error.
7 participants
@tmiasko @rust-highfive @camelid @spastorino @bors @davidtwco @rustbot