-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #90105
Closed
Closed
Rollup of 10 pull requests #90105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on some LLVM patches in concert with a Rust patch, and it's helping me quite a bit to have this as an option. It doesn't seem that hard, so I figured I'd formalize it in x.py and send it upstream.
use array explicitly instead of vec for const content (even if optimizer smart enought to remove allocation)
…zer smart enought to remove allocation)
Now explicitly says negative value.
…d on foreign trait implementations
Change `Duration::[try_]from_secs_{f32, f64}` underflow error The error message now says that it was a negative value. Fixes rust-lang#89913.
…=spastorino Reject closures in patterns Fixes rust-lang#90013.
…mulacrum config: add the option to enable LLVM tests I'm working on some LLVM patches in concert with a Rust patch, and it's helping me quite a bit to have this as an option. It doesn't seem that hard, so I figured I'd formalize it in x.py and send it upstream.
… r=jsha Add test for line-number setting The first commit updates the version of the package to be able to have multi-line commands (which looks much nicer for this test). r? `@jsha`
Update the minimum external LLVM to 11 With this change, we'll have stable support for LLVM 11..=13. For reference, the previous increase to LLVM 10 was rust-lang#83387. r? `@nagisa` `@nikic`
Remove hir::map::blocks and use FnKind instead The principal tool is `FnLikeNode`, which is not often used and can be easily implemented using `rustc_hir::intravisit::FnKind`.
2229 migrations small cleanup This removes needless `format!`'ing of empty string and replaces `vec!` with const strings with const array.
…ntry-reexported-macro, r=notriddle Add test for duplicated sidebar entries for reexported macro Fixes rust-lang#90015. r? `@notriddle`
…l-missing-doc-code-examples, r=jyn514 Add test to ensure that the missing_doc_code_examples is not triggered on foreign trait implementations Fixes rust-lang#76450. r? `@jyn514`
…olnay Fix MIRI UB in `Vec::swap_remove` Fixes rust-lang#90055 I find it weird that `Vec::swap_remove` read the last element to the stack just to immediately put it back in the `Vec` in place of the one at index `index`. It seems much more natural to me to just read the element at position `index` and then move the last element in its place. I guess this might also slightly improve codegen.
@bors r+ p=10 rollup=never |
📌 Commit 2c31c96 has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Oct 20, 2021
⌛ Testing commit 2c31c96 with merge 318e35595e958906df769df3c81eb5b18b06f0d6... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Duration::[try_]from_secs_{f32, f64}
underflow error #89944 (ChangeDuration::[try_]from_secs_{f32, f64}
underflow error)Vec::swap_remove
#90099 (Fix MIRI UB inVec::swap_remove
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup