Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdarch #90881

Closed
wants to merge 1 commit into from
Closed

Update stdarch #90881

wants to merge 1 commit into from

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 13, 2021

17 commits in 5fdbc47..05e8072
2021-09-20 17:19:05 +0100 to 2021-11-15 03:12:25 +0000

@rust-highfive
Copy link
Collaborator

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 13, 2021
@rust-log-analyzer

This comment has been minimized.

@ehuss
Copy link
Contributor Author

ehuss commented Nov 14, 2021

Blocked on rust-lang/stdarch#1252.

@ehuss
Copy link
Contributor Author

ehuss commented Nov 15, 2021

This should be ready for review now.

Maybe:
r? @Amanieu

@rust-highfive rust-highfive assigned Amanieu and unassigned dtolnay Nov 15, 2021
@Amanieu
Copy link
Member

Amanieu commented Nov 15, 2021

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Nov 15, 2021

📌 Commit 84f6ee8 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2021
@bors
Copy link
Contributor

bors commented Nov 16, 2021

⌛ Testing commit 84f6ee8 with merge ce5cd03c45a8a5798e1db91e74b2f0a6839fcf35...

@rust-log-analyzer
Copy link
Collaborator

The job wasm32 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] build_script_build test:false 0.567
error[E0432]: unresolved import `crate::core_arch::wasm32`
   --> library/core/src/../../stdarch/crates/core_arch/src/mod.rs:162:35
    |
162 |         pub use crate::core_arch::wasm32::*;
    |                                   ^^^^^^ could not find `wasm32` in `core_arch`

error[E0432]: unresolved import `core::arch::wasm32::v128`
 --> library/core/src/../../portable-simd/crates/core_simd/src/vendor/wasm32.rs:2:5
  |
2 | use core::arch::wasm32::v128;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `v128` in `core_arch::arch::wasm32`
For more information about this error, try `rustc --explain E0432`.
[RUSTC-TIMING] core test:false 12.504
error: could not compile `core` due to 2 previous errors
Build completed unsuccessfully in 0:15:40

@bors
Copy link
Contributor

bors commented Nov 16, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Nov 16, 2021

Commented on rust-lang/stdarch#1241 (comment)

@apiraino apiraino added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Nov 18, 2021
@bors
Copy link
Contributor

bors commented Nov 18, 2021

☔ The latest upstream changes (presumably #90382) made this pull request unmergeable. Please resolve the merge conflicts.

@ehuss
Copy link
Contributor Author

ehuss commented Nov 18, 2021

Resolved via #90382.

@ehuss ehuss closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants