-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining insturctions #1250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
SparrowLii
force-pushed
the
vmmla
branch
2 times, most recently
from
November 9, 2021 10:42
f02305b
to
93c4ed0
Compare
SparrowLii
force-pushed
the
vmmla
branch
4 times, most recently
from
November 9, 2021 11:42
5fa1cd3
to
a0f68f8
Compare
Amanieu
reviewed
Nov 9, 2021
crates/stdarch-gen/neon.spec
Outdated
|
||
aarch64 = frint32x | ||
link-aarch64 = frint32x._EXT_ | ||
// v8.5a is no_runtime feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be changed to frintts as discussed in #148.
I think the C tests are failing because they are using clang-12 but some of these intrinsics were only added in clang-13. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2021
Update stdarch 5 commits in 815d55c..cfba59f 2021-11-08 00:58:47 +0000 to 2021-11-19 01:29:04 +0000 - Work-around buggy Intel chips erroneously reporting BMI1/BMI2 support (rust-lang/stdarch#1249) - complete armv8 instructions (rust-lang/stdarch#1256) - Fix i8mm feature with bootstrap compiler. (rust-lang/stdarch#1252) - Fix unused link_name attribute. (rust-lang/stdarch#1251) - Add remaining insturctions (rust-lang/stdarch#1250)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
vmmla
vusmmla
vsm4e
vsm3
vrax1
vxar
vsha512
vbcax
veor3
neon instructionsFIXES #1233